Repository navigation
[10.0.101] Fix the SR10 test failures - #37949
Merged
kubaflo merged 5 commits intoAug 31, 2026
Merged
Conversation
TamilarasanSF4853
temporarily deployed
to
copilot-pat-pool
August 28, 2026 13:26 — with
GitHub Actions
Inactive
Contributor
|
Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
TamilarasanSF4853
temporarily deployed
to
copilot-pat-pool
August 28, 2026 13:26 — with
GitHub Actions
Inactive
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
TamilarasanSF4853
temporarily deployed
to
copilot-pat-pool
August 28, 2026 13:27 — with
GitHub Actions
Inactive
TamilarasanSF4853
temporarily deployed
to
copilot-pat-pool
August 28, 2026 13:29 — with
GitHub Actions
Inactive
TamilarasanSF4853
temporarily deployed
to
copilot-pat-pool
August 28, 2026 13:31 — with
GitHub Actions
Inactive
TamilarasanSF4853
temporarily deployed
to
copilot-pat-pool
August 28, 2026 13:32 — with
GitHub Actions
Inactive
…otnet#37726)" This reverts commit 470a24a, reversing changes made to a02bcc0.
…und null (dotnet#36769) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Issue Details PR dotnet#33346 changed UpdateBackground(UIButton, Paint?) to unconditionally reset BackgroundColor = UIColor.Clear when paint is null. Since MAUI maps every property during initial setup — including Background = null (the default) — the native constructor-set color gets wiped before the button is ever shown. ### Description of Change <!-- Enter description of the fix in this section --> Added a Window check to UpdateBackground, matching the identical guard already present in UpdateTextColor. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes dotnet#36749 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> **Tested the behavior in the following platforms.** - [ ] Android - [ ] Windows - [x] iOS - [x] Mac | Before | After | |---------|--------| | **iOS**<br> <img src="https://github.com/user-attachments/assets/ddffc469-e4ee-4ead-ac27-5f04599b0409" width="300" height="600"> | **iOS**<br> <img src="https://github.com/user-attachments/assets/f08ca4c8-12a5-4ab4-8baa-f16e7139df5a" width="300" height="600"> | (cherry picked from commit a6e2d41)
(cherry picked from commit 1870062)
(cherry picked from commit cef018c)
Contributor
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Warning 🔍 Automated review could not completeA trusted setup or review stage could not finish before producing review artifacts. Common causes include a transient GitHub/CI API failure, a CI-agent failure, or a pre-existing break on the target branch; this notice does not identify a merge conflict in your change. Please re-comment 🔍 Automated message from the .NET MAUI Copilot reviewer pipeline · build log |
This was referenced Sep 25, 2026
Open
3 tasks done
This was referenced Sep 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor UI adjustment to the
Issue35826test case in the host app. The only change is to the padding of thepickerAvailabilityLabel, increasing the top padding to improve visual spacing.Removed the unnecessary changes added by Copilot that caused an exception in the test, while retaining the original test and the fix from #36769
Fixes: #37746