Skip to content

[10.0.101] Fix the SR10 test failures - #37949

Merged
kubaflo merged 5 commits into
dotnet:inflight/10.0.101from
TamilarasanSF4853:Issue35826-Change
Aug 31, 2026
Merged

kubaflo merged 5 commits into
dotnet:inflight/10.0.101from
TamilarasanSF4853:Issue35826-Change

Conversation

@TamilarasanSF4853

@TamilarasanSF4853 TamilarasanSF4853 commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

This pull request makes a minor UI adjustment to the Issue35826 test case in the host app. The only change is to the padding of the pickerAvailabilityLabel, increasing the top padding to improve visual spacing.

  • UI Adjustment:
    • Increased the top padding of pickerAvailabilityLabel from 0 to 150 in Issue35826.cs to prevent the label from being hidden behind the status bar, which could cause a timeout exception during the test.

Removed the unnecessary changes added by Copilot that caused an exception in the test, while retaining the original test and the fix from #36769

Fixes: #37746

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Aug 28, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@TamilarasanSF4853! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Aug 28, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info platform/android labels Aug 28, 2026
TamilarasanSF4853 and others added 4 commits August 28, 2026 19:43
…und null (dotnet#36769)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details
PR dotnet#33346 changed UpdateBackground(UIButton, Paint?) to unconditionally
reset BackgroundColor = UIColor.Clear when paint is null. Since MAUI
maps every property during initial setup — including Background = null
(the default) — the native constructor-set color gets wiped before the
button is ever shown.

### Description of Change

<!-- Enter description of the fix in this section -->
Added a Window check to UpdateBackground, matching the identical guard
already present in UpdateTextColor.

### Issues Fixed

<!-- Please make sure that there is a bug logged for the issue being
fixed. The bug should describe the problem and how to reproduce it. -->

Fixes dotnet#36749

<!--
Are you targeting main? All PRs should target the main branch unless
otherwise noted.
-->

**Tested the behavior in the following platforms.**
- [ ] Android
- [ ] Windows
- [x] iOS
- [x] Mac

| Before  | After  |
|---------|--------|
| **iOS**<br> <img
src="https://github.com/user-attachments/assets/ddffc469-e4ee-4ead-ac27-5f04599b0409"
width="300" height="600"> | **iOS**<br> <img
src="https://github.com/user-attachments/assets/f08ca4c8-12a5-4ab4-8baa-f16e7139df5a"
width="300" height="600"> |

(cherry picked from commit a6e2d41)
(cherry picked from commit 1870062)
(cherry picked from commit cef018c)
@kubaflo

kubaflo commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@kubaflo

This comment has been minimized.

@github-actions github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Aug 30, 2026
@MauiBot

This comment has been minimized.

@MauiBot

This comment has been minimized.

@MauiBot MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Aug 30, 2026
@kubaflo

This comment has been minimized.

@github-actions github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Aug 30, 2026
@MauiBot

This comment has been minimized.

@MauiBot

MauiBot commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

Warning

🔍 Automated review could not complete

A trusted setup or review stage could not finish before producing review artifacts. Common causes include a transient GitHub/CI API failure, a CI-agent failure, or a pre-existing break on the target branch; this notice does not identify a merge conflict in your change.

Please re-comment /review to retry on a fresh agent.

🔍 Automated message from the .NET MAUI Copilot reviewer pipeline · build log

@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants