Skip to content

Fix race in WeakEventProxy field access #37568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kubaflo merged 1 commit into from
Aug 18, 2026
Merged

Fix race in WeakEventProxy field access #37568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Controls/src/Core/Internals/WeakEventProxy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ abstract class WeakEventProxy<TSource, TEventHandler>

public bool TryGetSource([MaybeNullWhen(false)] out TSource source)
{
if (_source is not null && _source.TryGetTarget(out source))
var sourceReference = _source;
if (sourceReference is not null && sourceReference.TryGetTarget(out source))
{
return source is not null;
}
Expand All @@ -35,7 +36,8 @@ public bool TryGetSource([MaybeNullWhen(false)] out TSource source)

public bool TryGetHandler([MaybeNullWhen(false)] out TEventHandler handler)
{
if (_handler is not null && _handler.TryGetTarget(out handler))
var handlerReference = _handler;
if (handlerReference is not null && handlerReference.TryGetTarget(out handler))
{
return handler is not null;
}
Expand Down
Loading