Repository navigation
[YML] Removed duplicate deviceType code. - #37389
Merged
Merged
Conversation
Ahamed-Ali
temporarily deployed
to
copilot-pat-pool
August 13, 2026 08:44 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 37389Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 37389" |
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Ahamed-Ali
temporarily deployed
to
copilot-pat-pool
August 13, 2026 08:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Ahamed-Ali
added
area-testing
Ahamed-Ali
temporarily deployed
to
copilot-pat-pool
August 13, 2026 08:45 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
dotnet-policy-service
Bot
added
the
partner/syncfusion
Ahamed-Ali
temporarily deployed
to
copilot-pat-pool
August 13, 2026 08:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Ahamed-Ali
temporarily deployed
to
copilot-pat-pool
August 13, 2026 08:47 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Ahamed-Ali
temporarily deployed
to
copilot-pat-pool
August 13, 2026 08:48 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
sheiksyedm
marked this pull request as ready for review
August 13, 2026 13:12
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the UI test pipeline script in .NET MAUI by removing a duplicated block that set the deviceType variable and appended the Android emulator skin argument (--skin) to the test command, ensuring the argument is applied only once.
Changes:
- Removed the second/duplicate
$deviceTypehandling block that appended--skin. - Kept a single, centralized device-skin append block earlier in the command construction.
kubaflo
approved these changes
Aug 13, 2026
Ahamed-Ali
added a commit
to Ahamed-Ali/maui
that referenced
this pull request
Aug 14, 2026
### Description of Change This pull request makes a minor update to the UI test pipeline configuration - Pipeline configuration simplification: * Removed the **duplicate** code that set the `$deviceType` variable and appended the `--skin` argument to the test command in `eng/pipelines/common/ui-tests-steps.yml`. The same code was already added at [line 133](https://github.com/dotnet/maui/blob/main/eng/pipelines/common/ui-tests-steps.yml#L133) as part of [PR dotnet#33409](dotnet#33409). The duplicate code was also added at [line 156](https://github.com/dotnet/maui/blob/main/eng/pipelines/common/ui-tests-steps.yml#L156) as part of [PR dotnet#31631](dotnet#31631).
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request makes a minor update to the UI test pipeline configuration
$deviceTypevariable and appended the--skinargument to the test command ineng/pipelines/common/ui-tests-steps.yml.The same code was already added at line 133 as part of PR #33409.
The duplicate code was also added at line 156 as part of PR #31631.