Revert - Fix TalkBack not correctly narrating RadioButtons with Content - #35625
Conversation
<!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## What Restrict the agentic-labeler to apply **exactly one `area-*` label** per item, while still allowing multiple `platform/*` labels. ## Why Backfilling the 26 items affected by the `max:1` bug (fixed in dotnet#35540) revealed that the labeler occasionally applies multiple `area-*` labels for ambiguous cases: - **dotnet#35501** got both `area-layout` and `area-safearea` - **dotnet#35490** got both `area-navigation` and `area-controls-tabbedpage` The intended behavior is exactly one best-fit `area-*` per item (a label-quota distinction not expressible via `safe-outputs.add-labels.max:` — that field counts total labels, not labels per prefix). The fix has to live in the agent's instructions. ## Changes ### `.github/skills/agentic-labeler/SKILL.md` - Scope section: "Exactly one `area-*`" / "One or more `platform/*`". - Area rules section: renamed heading, changed "pick one or more" → "apply exactly one". - New **tie-breaking heuristics** for the area-* selection: - Specific control beats generic area (`area-controls-tabbedpage` over `area-navigation`) - Sub-area beats parent area (`area-safearea` over `area-layout`) - Subject-matter focus beats incidental touch - When genuinely tied, prefer the user-visible feature - Mixed-PR rule clarified: infra-primary PRs get only `area-infrastructure` (no second product area). ### `.github/workflows/agentic-labeler.md` - Added explicit reinforcement in the workflow prompt: "Apply exactly one `area-*` label … and one or more `platform/*` labels". - Fixed two stale `max: 1` comments left over from dotnet#35540 (the cap is now `max: 10`). ### `.github/workflows/agentic-labeler.lock.yml` - Regenerated via `gh aw compile`. Diff is frontmatter-hash + heredoc rotations only — no semantic change to the compiled config. ## Validation - Reviewed all 21 existing eval scenarios in `tests/eval.yaml` — none assert multiple `area-*` labels, so no test updates needed. - The `max: 10` cap in `safe-outputs` is preserved as a blast-radius safeguard (one area + several platforms still fit comfortably). ## Follow-ups (not in this PR) If accuracy of the "one area" rule drops below ~95% in eval runs, consider adding a deterministic post-step that strips extra `area-*` labels per a known precedence list (Option B from the design discussion). Co-authored-by: bot <bot@test> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
## Description
Extends the `maui-copilot` DevDiv pipeline (pipeline 27723) with a
3-stage architecture that runs real UI tests on platform-pool agents and
reports results directly in the AI summary PR comment.
### Pipeline Workflow
```
┌─────────────────────────────────────────────────────────┐
│ Stage 1: ReviewPR │
│ │
│ STEP 1: Branch Setup (checkout + cherry-pick PR) │
│ STEP 2: Detect UI Test Categories │
│ STEP 3: Run Detected UI Tests (in-process, fast) │
│ STEP 4: Regression Cross-Reference │
│ STEP 5: Gate — verify tests fail/pass before/after fix │
│ STEP 6: Code Review — deep analysis via Copilot agent │
│ │
│ Outputs → CopilotLogs artifact + detectedCategories │
└──────────────────────┬──────────────────────────────────┘
│
┌──────────────────────▼──────────────────────────────────┐
│ Stage 2: RunDeepUITests (platform-pool agent) │
│ │
│ iOS: AcesShared Tahoe + iOS 26.4 │
│ Android: ubuntu-22.04 + KVM + AVD │
│ │
│ Runs BuildAndRunHostApp.ps1 per detected category │
│ Outputs → drop-deep-uitests artifact (TRX + diffs) │
└──────────────────────┬──────────────────────────────────┘
│
┌──────────────────────▼──────────────────────────────────┐
│ Stage 3: PostResults │
│ │
│ 1. Download CopilotLogs (review content files) │
│ 2. Download drop-deep-uitests (TRX results) │
│ 3. Merge deep results into uitests/content.md │
│ 4. Post full AI Summary comment on PR │
│ 5. Apply labels (s/agent-reviewed, etc.) │
│ │
│ One comment with everything — no patching needed │
└─────────────────────────────────────────────────────────┘
```
### What's New
**Deep UI Test Execution (Stage 2)**
- Runs detected UI test categories on proper platform-pool agents (not
in-process on Linux)
- **iOS**: AcesShared Tahoe agents with iOS 26.4 simulator, iPhone 11
Pro (matching `ios-26` baselines from PR dotnet#35061)
- **Android**: ubuntu-22.04 with KVM, AVD boot with `-partition-size
2048`, `ignoreHiddenApiPolicyError` capability
- TRX results + snapshot-diff PNGs published as `drop-deep-uitests`
artifact
**Unified Comment Posting (Stage 3)**
- Comment posting and label application deferred to Stage 3 (after deep
tests complete)
- Single AI summary comment includes ALL results: code review + deep
test results
- Nested collapsible `<details>` for failed tests with full error +
stack trace
- Dynamic section title: `🧪 UI Tests — CollectionView, TabbedPage`
- Artifact download link for snapshot-diff PNGs
**Android Emulator Improvements**
- AVD boot step with proper partition size, ADB key pre-authorization,
boot wait
- `DEVICE_UDID` pass-through prevents double emulator boot
- Disk cleanup on hosted ubuntu agents (frees ~22GB)
- KVM enablement + `appium:ignoreHiddenApiPolicyError` for API 30
**iOS Simulator Improvements**
- Tahoe pool demand ensures macOS 26.x agents
- Explicit iOS 26.4 download via latest Xcode
- Auto-creates iPhone 11 Pro for baseline resolution match
### Validation
Tested across 30+ pipeline iterations on 6 PRs:
| PR | iOS | Android |
|---|---|---|
| 35358 (ViewBaseTests) | **112/112 ALL PASS** ✅ | **118/119 PASS** ✅ |
| 35359 (TabbedPage) | 44/50 (1 real failure) | 74/75 (1 real failure) |
| 35356 (CollectionView) | **415/417 PASS** ✅ | 593/619 (26 real
failures) |
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…35589) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! Backport of dotnet#35460 to `main`. /cc @PureWeen Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35625Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35625" |
|
/review -b feature/enhanced-reviewer |
MauiBot
left a comment
There was a problem hiding this comment.
AI Review Summary
@devanathan-vaithiyanathan — new AI review results are available based on this last commit:
9bac50c.
** Revert "Fix TalkBack not correctly narrating RadioButtons with Content (#34521)"** To request a deterministic rerun after new comments or commits, comment/review rerun.
Review Sessions — click to expand
Gate — Test Before & After Fix
Gate Result: ✅ PASSED
Platform: ANDROID · Base: main · Merge base: b0ea772f
| Test | Without Fix (expect FAIL) | With Fix (expect PASS) |
|---|---|---|
📱 RadioButtonTests RadioButtonTests |
✅ FAIL — 953s | ✅ PASS — 1192s |
🔴 Without fix — 📱 RadioButtonTests: FAIL ✅ · 953s
(truncated to last 15,000 chars)
d.dll.so
[46/133] Xamarin.AndroidX.Lifecycle.ViewModelSavedState.Android.dll -> Xamarin.AndroidX.Lifecycle.ViewModelSavedState.Android.dll.so
[122/133] System.Threading.ThreadPool.dll -> System.Threading.ThreadPool.dll.so
[47/133] Xamarin.AndroidX.Loader.dll -> Xamarin.AndroidX.Loader.dll.so
[123/133] System.Text.Json.dll -> System.Text.Json.dll.so
[124/133] System.Threading.dll -> System.Threading.dll.so
[125/133] System.Xml.Linq.dll -> System.Xml.Linq.dll.so
[48/133] Xamarin.AndroidX.Navigation.Common.Android.dll -> Xamarin.AndroidX.Navigation.Common.Android.dll.so
[126/133] System.Xml.ReaderWriter.dll -> System.Xml.ReaderWriter.dll.so
[127/133] System.Xml.XDocument.dll -> System.Xml.XDocument.dll.so
[49/133] Xamarin.AndroidX.Navigation.Fragment.dll -> Xamarin.AndroidX.Navigation.Fragment.dll.so
[128/133] System.dll -> System.dll.so
[129/133] netstandard.dll -> netstandard.dll.so
[50/133] Xamarin.AndroidX.Navigation.Runtime.Android.dll -> Xamarin.AndroidX.Navigation.Runtime.Android.dll.so
[130/133] Mono.Android.Runtime.dll -> Mono.Android.Runtime.dll.so
[51/133] Xamarin.AndroidX.Navigation.UI.dll -> Xamarin.AndroidX.Navigation.UI.dll.so
[131/133] Java.Interop.dll -> Java.Interop.dll.so
[52/133] Xamarin.AndroidX.RecyclerView.dll -> Xamarin.AndroidX.RecyclerView.dll.so
[53/133] Xamarin.AndroidX.SavedState.SavedState.Android.dll -> Xamarin.AndroidX.SavedState.SavedState.Android.dll.so
[54/133] Xamarin.AndroidX.SwipeRefreshLayout.dll -> Xamarin.AndroidX.SwipeRefreshLayout.dll.so
[55/133] Xamarin.AndroidX.ViewPager.dll -> Xamarin.AndroidX.ViewPager.dll.so
[56/133] Xamarin.AndroidX.ViewPager2.dll -> Xamarin.AndroidX.ViewPager2.dll.so
[57/133] Xamarin.Google.Android.Material.dll -> Xamarin.Google.Android.Material.dll.so
[132/133] Mono.Android.dll -> Mono.Android.dll.so
[58/133] Xamarin.GooglePlayServices.Base.dll -> Xamarin.GooglePlayServices.Base.dll.so
[59/133] Xamarin.GooglePlayServices.Basement.dll -> Xamarin.GooglePlayServices.Basement.dll.so
[60/133] Xamarin.GooglePlayServices.Maps.dll -> Xamarin.GooglePlayServices.Maps.dll.so
[61/133] Xamarin.GooglePlayServices.Tasks.dll -> Xamarin.GooglePlayServices.Tasks.dll.so
[62/133] Xamarin.Kotlin.StdLib.dll -> Xamarin.Kotlin.StdLib.dll.so
[63/133] Xamarin.KotlinX.Coroutines.Core.Jvm.dll -> Xamarin.KotlinX.Coroutines.Core.Jvm.dll.so
[64/133] Xamarin.KotlinX.Serialization.Core.Jvm.dll -> Xamarin.KotlinX.Serialization.Core.Jvm.dll.so
[65/133] xunit.abstractions.dll -> xunit.abstractions.dll.so
[66/133] xunit.assert.dll -> xunit.assert.dll.so
[67/133] xunit.core.dll -> xunit.core.dll.so
[68/133] xunit.execution.dotnet.dll -> xunit.execution.dotnet.dll.so
[69/133] xunit.runner.utility.netcoreapp10.dll -> xunit.runner.utility.netcoreapp10.dll.so
[70/133] System.Collections.Concurrent.dll -> System.Collections.Concurrent.dll.so
[71/133] System.Collections.Immutable.dll -> System.Collections.Immutable.dll.so
[72/133] System.Collections.NonGeneric.dll -> System.Collections.NonGeneric.dll.so
[133/133] System.Private.CoreLib.dll -> System.Private.CoreLib.dll.so
[73/133] System.Collections.Specialized.dll -> System.Collections.Specialized.dll.so
[74/133] System.Collections.dll -> System.Collections.dll.so
[75/133] System.ComponentModel.Primitives.dll -> System.ComponentModel.Primitives.dll.so
[76/133] System.ComponentModel.TypeConverter.dll -> System.ComponentModel.TypeConverter.dll.so
[77/133] System.ComponentModel.dll -> System.ComponentModel.dll.so
[78/133] System.Console.dll -> System.Console.dll.so
[79/133] System.Diagnostics.Debug.dll -> System.Diagnostics.Debug.dll.so
[80/133] System.Diagnostics.DiagnosticSource.dll -> System.Diagnostics.DiagnosticSource.dll.so
[81/133] System.Diagnostics.Process.dll -> System.Diagnostics.Process.dll.so
[82/133] System.Diagnostics.Tools.dll -> System.Diagnostics.Tools.dll.so
[83/133] System.Diagnostics.TraceSource.dll -> System.Diagnostics.TraceSource.dll.so
[84/133] System.Diagnostics.Tracing.dll -> System.Diagnostics.Tracing.dll.so
[85/133] System.Drawing.Primitives.dll -> System.Drawing.Primitives.dll.so
[86/133] System.Drawing.dll -> System.Drawing.dll.so
[87/133] System.Formats.Asn1.dll -> System.Formats.Asn1.dll.so
[88/133] System.Globalization.dll -> System.Globalization.dll.so
[89/133] System.IO.Compression.Brotli.dll -> System.IO.Compression.Brotli.dll.so
[90/133] System.IO.Compression.dll -> System.IO.Compression.dll.so
[91/133] System.IO.FileSystem.dll -> System.IO.FileSystem.dll.so
[92/133] System.IO.Pipelines.dll -> System.IO.Pipelines.dll.so
[93/133] System.IO.dll -> System.IO.dll.so
[94/133] System.Linq.Expressions.dll -> System.Linq.Expressions.dll.so
[95/133] System.Linq.dll -> System.Linq.dll.so
[96/133] System.Memory.dll -> System.Memory.dll.so
[97/133] System.Net.Http.dll -> System.Net.Http.dll.so
[98/133] System.Net.NameResolution.dll -> System.Net.NameResolution.dll.so
[99/133] System.Net.Primitives.dll -> System.Net.Primitives.dll.so
[100/133] System.Net.Requests.dll -> System.Net.Requests.dll.so
[101/133] System.Net.Sockets.dll -> System.Net.Sockets.dll.so
[102/133] System.Numerics.Vectors.dll -> System.Numerics.Vectors.dll.so
[103/133] System.ObjectModel.dll -> System.ObjectModel.dll.so
[104/133] System.Private.Uri.dll -> System.Private.Uri.dll.so
[105/133] System.Private.Xml.Linq.dll -> System.Private.Xml.Linq.dll.so
[106/133] System.Private.Xml.dll -> System.Private.Xml.dll.so
[107/133] System.Reflection.Extensions.dll -> System.Reflection.Extensions.dll.so
[108/133] System.Reflection.TypeExtensions.dll -> System.Reflection.TypeExtensions.dll.so
[109/133] System.Reflection.dll -> System.Reflection.dll.so
[110/133] System.Runtime.Extensions.dll -> System.Runtime.Extensions.dll.so
[111/133] System.Runtime.InteropServices.RuntimeInformation.dll -> System.Runtime.InteropServices.RuntimeInformation.dll.so
[112/133] System.Runtime.InteropServices.dll -> System.Runtime.InteropServices.dll.so
[113/133] System.Runtime.Loader.dll -> System.Runtime.Loader.dll.so
[114/133] System.Runtime.Numerics.dll -> System.Runtime.Numerics.dll.so
[115/133] System.Runtime.dll -> System.Runtime.dll.so
[116/133] System.Security.Cryptography.dll -> System.Security.Cryptography.dll.so
[117/133] System.Text.Encoding.dll -> System.Text.Encoding.dll.so
[118/133] System.Text.Encodings.Web.dll -> System.Text.Encodings.Web.dll.so
[119/133] System.Text.Json.dll -> System.Text.Json.dll.so
[120/133] System.Text.RegularExpressions.dll -> System.Text.RegularExpressions.dll.so
[121/133] System.Threading.Tasks.dll -> System.Threading.Tasks.dll.so
[122/133] System.Threading.Thread.dll -> System.Threading.Thread.dll.so
[123/133] System.Threading.ThreadPool.dll -> System.Threading.ThreadPool.dll.so
[124/133] System.Threading.dll -> System.Threading.dll.so
[125/133] System.Xml.Linq.dll -> System.Xml.Linq.dll.so
[126/133] System.Xml.ReaderWriter.dll -> System.Xml.ReaderWriter.dll.so
[127/133] System.Xml.XDocument.dll -> System.Xml.XDocument.dll.so
[128/133] System.dll -> System.dll.so
[129/133] netstandard.dll -> netstandard.dll.so
[130/133] Java.Interop.dll -> Java.Interop.dll.so
[131/133] Mono.Android.Runtime.dll -> Mono.Android.Runtime.dll.so
[132/133] Mono.Android.dll -> Mono.Android.dll.so
[133/133] System.Private.CoreLib.dll -> System.Private.CoreLib.dll.so
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:11:11.33
[11.0.0-prerelease.26230.4+92962e5c46ac08a66ded4c5696209cc60f1a232f] XHarness command issued: android test --app /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk --package-name com.microsoft.maui.controls.devicetests --device-id emulator-5554 -o artifacts/log --timeout 01:00:00 -v --arg TestFilter=RadioButtonTests
�[40m�[37mdbug�[39m�[22m�[49m: ADBRunner using ADB.exe supplied from /home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/tools/net10.0/any/../../../runtimes/any/native/adb/linux/adb
�[40m�[37mdbug�[39m�[22m�[49m: Full resolved path:'/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb'
�[40m�[32minfo�[39m�[22m�[49m: Will attempt to find device supporting architectures: 'arm64-v8a', 'x86_64'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb start-server'
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[32minfo�[39m�[22m�[49m: Finding attached devices/emulators...
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb devices -l'
�[40m�[37mdbug�[39m�[22m�[49m: Found 1 possible devices
�[40m�[37mdbug�[39m�[22m�[49m: Evaluating output line for device serial: emulator-5554 device product:sdk_gphone_x86_64 model:sdk_gphone_x86_64 device:generic_x86_64_arm64 transport_id:1
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 shell getprop ro.product.cpu.abilist'
�[40m�[37mdbug�[39m�[22m�[49m: Found 1 possible devices. Using 'emulator-5554'
�[40m�[32minfo�[39m�[22m�[49m: Active Android device set to serial 'emulator-5554'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 -s emulator-5554 shell getprop ro.product.cpu.abi'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 -s emulator-5554 shell getprop ro.build.version.sdk'
�[40m�[32minfo�[39m�[22m�[49m: Waiting for device to be available (max 5 minutes)
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 wait-for-device'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 -s emulator-5554 shell getprop sys.boot_completed'
�[40m�[37mdbug�[39m�[22m�[49m: sys.boot_completed = '1'
�[40m�[37mdbug�[39m�[22m�[49m: Waited 0 seconds for device boot completion
�[40m�[37mdbug�[39m�[22m�[49m: Working with emulator-5554 (API 30)
�[40m�[37mdbug�[39m�[22m�[49m: Check current adb install and/or package verification settings
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 shell settings get global verifier_verify_adb_installs'
�[40m�[37mdbug�[39m�[22m�[49m: verifier_verify_adb_installs = 0
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 shell settings get global package_verifier_enable'
�[40m�[37mdbug�[39m�[22m�[49m: package_verifier_enable =
�[40m�[1m�[33mwarn�[39m�[22m�[49m: Installing debug apks on a device might be rejected with INSTALL_FAILED_VERIFICATION_FAILURE. Make sure to set 'package_verifier_enable' to '0'
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[40m�[1m�[33mwarn�[39m�[22m�[49m: Hit broken pipe error; Will make one attempt to restart ADB server, and retry the uninstallation
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 kill-server'
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 start-server'
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[41m�[30mfail�[39m�[22m�[49m: Error: Exit code: 20
Std out:
Std err:
- waiting for device -
cmd: Can't find service: package
�[40m�[32minfo�[39m�[22m�[49m: Attempting to install /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 install /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk'
�[41m�[30mfail�[39m�[22m�[49m: Error:
Exit code: 1
Std out:
Serving...
Performing Incremental Install
cmd: Can't find service: package
Performing Streamed Install
Std err:
adb: failed to install /home/vsts/work/1/s/artifacts/bin/Controls.DeviceTests/Release/net10.0-android/com.microsoft.maui.controls.devicetests-Signed.apk: cmd: Can't find service: package
�[41m�[1m�[37mcrit�[39m�[22m�[49m: Install failure: Test command cannot continue
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[41m�[30mfail�[39m�[22m�[49m: Error: Exit code: 20
Std out:
Std err:
cmd: Can't find service: package
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[41m�[30mfail�[39m�[22m�[49m: Error: Exit code: 20
Std out:
Std err:
cmd: Can't find service: package
XHarness exit code: 78 (PACKAGE_INSTALLATION_FAILURE)
Tests completed with exit code: 78
🟢 With fix — 📱 RadioButtonTests: PASS ✅ · 1192s
(truncated to last 15,000 chars)
334 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:18.324 15698 19345 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:22.119 15698 19356 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:25.938 15698 19367 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:29.805 15698 19379 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:33.660 15698 19390 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:37.483 15698 19401 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:41.284 15698 19412 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:45.116 15698 19423 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:48.938 15698 19434 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:52.744 15698 19445 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:05:56.570 15698 19452 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:00.885 15698 19463 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:04.715 15698 19474 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:08.520 15698 19485 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:12.379 15698 19496 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:16.198 15698 19507 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:20.030 15698 19518 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:25.047 15698 19529 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:28.912 15698 19541 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:32.744 15698 19552 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:36.572 15698 19563 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:40.433 15698 19574 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:44.250 15698 19585 I DOTNET : [PASS] Handler Does Not Leak
06-01 08:06:49.651 15698 19590 I DOTNET : [PASS] CollectionView Header/Footer Doesn't Leak
06-01 08:06:57.729 15698 19595 I DOTNET : [PASS] FlyoutPage Detail Navigation Does Not Leak
06-01 08:06:57.729 15698 19595 I DOTNET : Microsoft.Maui.DeviceTests.Memory.MemoryTests 271.2424895 ms
06-01 08:06:57.730 15698 19595 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.SearchBarTests
06-01 08:06:57.741 15698 19595 I DOTNET : [PASS] RotationYConsistent
06-01 08:06:57.747 15698 19595 I DOTNET : [PASS] ScaleConsistent
06-01 08:06:57.752 15698 19595 I DOTNET : [PASS] ScaleXConsistent
06-01 08:06:57.765 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly at Initialization
06-01 08:06:57.777 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly at Initialization
06-01 08:06:57.784 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly after Initialization
06-01 08:06:57.797 15698 19601 I DOTNET : [PASS] Text is Transformed Correctly after Initialization
06-01 08:06:57.804 15698 19601 I DOTNET : [PASS] VerifySearchBarOpacityProperty
06-01 08:06:57.811 15698 19601 I DOTNET : [PASS] SearchBarTranslationConsistent
06-01 08:06:57.817 15698 19601 I DOTNET : [PASS] RotationXConsistent
06-01 08:06:57.823 15698 19601 I DOTNET : [PASS] VerifySearchBarIsEnabledProperty
06-01 08:06:57.829 15698 19601 I DOTNET : [PASS] ScaleYConsistent
06-01 08:06:57.837 15698 19601 I DOTNET : [PASS] VerifySearchBarIsVisibleProperty
06-01 08:06:57.843 15698 19601 I DOTNET : [PASS] RotationConsistent
06-01 08:06:57.843 15698 19601 I DOTNET : Microsoft.Maui.DeviceTests.SearchBarTests 0.1076797 ms
06-01 08:06:57.843 15698 19601 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_InvokeDotNet
06-01 08:06:58.513 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:06:58.513 15698 15717 I DOTNET : InvokeDotNet endpoint missing or invalid request header
06-01 08:06:59.025 15698 19607 I DOTNET : [PASS] GetRequestsAreBlocked
06-01 08:06:59.757 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:06:59.757 15698 15717 I DOTNET : InvokeDotNet endpoint missing or invalid request header
06-01 08:07:00.267 15698 19613 I DOTNET : [PASS] InvalidTokenHeaderIsBlocked
06-01 08:07:00.268 15698 19613 I DOTNET : [IGNORED] IframeRequestIsBlocked
06-01 08:07:00.914 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:00.914 15698 15717 I DOTNET : InvokeDotNet request missing X-Maui-Request-Body header
06-01 08:07:01.209 15698 19619 I DOTNET : [PASS] EmptyBodyIsBlocked
06-01 08:07:01.890 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:01.890 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: The invoke data did not provide a method name.
06-01 08:07:01.890 15698 15717 I DOTNET : System.InvalidOperationException: The invoke data did not provide a method name.
06-01 08:07:01.890 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:02.392 15698 19625 I DOTNET : [PASS] ValidRequestIsNotBlocked
06-01 08:07:03.086 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:03.086 15698 15717 I DOTNET : InvokeDotNet endpoint only accepts POST requests. Received: GET
06-01 08:07:03.597 15698 19631 I DOTNET : [PASS] GetRequestWithHeaderIsBlocked
06-01 08:07:04.395 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:04.395 15698 15717 I DOTNET : InvokeDotNet endpoint missing or invalid request header
06-01 08:07:04.939 15698 19637 I DOTNET : [PASS] MissingTokenHeaderIsBlocked
06-01 08:07:05.624 15698 15717 I DOTNET : fail: Microsoft.Maui.Platform.MauiHybridWebViewClient[0]
06-01 08:07:05.624 15698 15717 I DOTNET : InvokeDotNet request missing X-Maui-Request-Body header
06-01 08:07:06.203 15698 19643 I DOTNET : [PASS] MissingBodyHeaderIsBlocked
06-01 08:07:06.203 15698 19643 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_InvokeDotNet 8.2321229 ms
06-01 08:07:06.203 15698 19643 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_EvaluateJavaScriptAsync
06-01 08:07:06.881 15698 19649 I DOTNET : [PASS] EvaluateJavaScriptAndGetResult
06-01 08:07:06.881 15698 19649 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_EvaluateJavaScriptAsync 0.6768011 ms
06-01 08:07:06.881 15698 19649 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling
06-01 08:07:08.102 15698 19655 I DOTNET : [PASS] CSharpMethodThatSucceeds_ShouldStillWorkNormally
06-01 08:07:08.813 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:08.813 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: Async test exception
06-01 08:07:08.813 15698 15717 I DOTNET : System.InvalidOperationException: Async test exception
06-01 08:07:08.813 15698 15717 I DOTNET : at Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling.TestExceptionMethods.ThrowExceptionAsync()
06-01 08:07:08.813 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetMethodAsync(Type targetType, Object jsInvokeTarget, JSInvokeMethodData invokeData)
06-01 08:07:08.813 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:09.312 15698 19661 I DOTNET : [PASS] CSharpAsyncMethodThatThrowsException_ShouldPropagateToJavaScript
06-01 08:07:10.038 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:10.038 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: Test exception message
06-01 08:07:10.038 15698 15717 I DOTNET : System.InvalidOperationException: Test exception message
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling.TestExceptionMethods.ThrowException()
06-01 08:07:10.038 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
06-01 08:07:10.038 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )
06-01 08:07:10.038 15698 15717 I DOTNET : --- End of stack trace from previous location ---
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.GetDotNetMethodReturnValue(Object jsInvokeTarget, MethodInfo dotnetMethod, Object[] invokeParamValues)
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetMethodAsync(Type targetType, Object jsInvokeTarget, JSInvokeMethodData invokeData)
06-01 08:07:10.038 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:10.550 15698 19667 I DOTNET : [PASS] CSharpMethodThatThrowsException_ShouldPropagateToJavaScript
06-01 08:07:11.264 15698 15717 I DOTNET : fail: Microsoft.Maui.Handlers.HybridWebViewHandler[0]
06-01 08:07:11.264 15698 15717 I DOTNET : An error occurred while invoking a .NET method from JavaScript: Custom argument exception
06-01 08:07:11.264 15698 15717 I DOTNET : System.ArgumentException: Custom argument exception
06-01 08:07:11.264 15698 15717 I DOTNET : at Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling.TestExceptionMethods.ThrowCustomException()
06-01 08:07:11.264 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
06-01 08:07:11.265 15698 15717 I DOTNET : at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags )
06-01 08:07:11.265 15698 15717 I DOTNET : --- End of stack trace from previous location ---
06-01 08:07:11.265 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.GetDotNetMethodReturnValue(Object jsInvokeTarget, MethodInfo dotnetMethod, Object[] invokeParamValues)
06-01 08:07:11.265 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetMethodAsync(Type targetType, Object jsInvokeTarget, JSInvokeMethodData invokeData)
06-01 08:07:11.265 15698 15717 I DOTNET : at Microsoft.Maui.Handlers.HybridWebViewHandler.InvokeDotNetAsync(Stream streamBody, String stringBody)
06-01 08:07:11.775 15698 19673 I DOTNET : [PASS] CSharpMethodThatThrowsCustomException_ShouldIncludeExceptionDetails
06-01 08:07:11.775 15698 19673 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_ExceptionHandling 4.8904472 ms
06-01 08:07:11.775 15698 19673 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.PickerTests
06-01 08:07:11.959 15698 19678 I DOTNET : [PASS] PickerBackgroundColorConsistent
06-01 08:07:11.968 15698 19678 I DOTNET : [PASS] ItemsUpdateWithCollectionChanges
06-01 08:07:11.972 15698 19678 I DOTNET : [PASS] RotationYConsistent
06-01 08:07:12.039 15698 19678 I DOTNET : [PASS] ScaleConsistent
06-01 08:07:12.044 15698 19678 I DOTNET : [PASS] VerifyPickerOpacityProperty
06-01 08:07:12.047 15698 19678 I DOTNET : [PASS] ScaleYConsistent
06-01 08:07:12.050 15698 19678 I DOTNET : [PASS] ScaleXConsistent
06-01 08:07:12.052 15698 19678 I DOTNET : [PASS] RotationXConsistent
06-01 08:07:12.057 15698 19678 I DOTNET : [PASS] ItemsUpdateWithNewItemSource
06-01 08:07:12.059 15698 19678 I DOTNET : [PASS] RotationConsistent
06-01 08:07:12.059 15698 19678 I DOTNET : Microsoft.Maui.DeviceTests.PickerTests 0.2191462 ms
06-01 08:07:12.060 15698 19678 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.HybridWebViewTests_SetInvokeJavaScriptTarget
06-01 08:07:13.208 15698 19684 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:14.461 15698 19690 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:15.625 15698 19696 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:16.975 15698 19702 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:18.232 15698 19708 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:19.455 15698 19714 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:20.684 15698 19720 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:21.897 15698 19726 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:23.116 15698 19732 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:24.358 15698 19738 I DOTNET : [PASS] InvokeDotNet
06-01 08:07:24.358 15698 19738 I DOTNET : Microsoft.Maui.DeviceTests.HybridWebViewTests_SetInvokeJavaScriptTarget 12.1550019 ms
06-01 08:07:24.358 15698 19738 I DOTNET : Test collection for Microsoft.Maui.DeviceTests.Memory.WindowOverlayTests
06-01 08:07:26.338 15698 19743 I DOTNET : [PASS] Does Not Leak
06-01 08:07:26.338 15698 19743 I DOTNET : Microsoft.Maui.DeviceTests.Memory.WindowOverlayTests 1.9796238 ms
06-01 08:07:26.370 15698 17436 I DOTNET : Xml file was written to the provided writer.
06-01 08:07:26.370 15698 17436 I DOTNET : Tests run: 953 Passed: 940 Inconclusive: 0 Failed: 0 Ignored: 0
�[40m�[32minfo�[39m�[22m�[49m: <<XHARNESS_RESULT_START>>
{
"version": 1,
"machineName": "runnervmm79r7",
"exitCode": 0,
"exitCodeName": "SUCCESS",
"platform": "android",
"instrumentationExitCode": 0,
"device": "emulator-5554",
"deviceOsVersion": "API 30",
"architecture": "x86_64",
"files": [
{
"name": "testResults.xml",
"type": "test-results"
},
{
"name": "adb-logcat-com.microsoft.maui.controls.devicetests-default.log",
"type": "logcat"
}
]
}
<<XHARNESS_RESULT_END>>
�[40m�[32minfo�[39m�[22m�[49m: Attempting to remove apk 'com.microsoft.maui.controls.devicetests'..
�[40m�[37mdbug�[39m�[22m�[49m: Executing command: '/home/vsts/.nuget/packages/microsoft.dotnet.xharness.cli/11.0.0-prerelease.26230.4/runtimes/any/native/adb/linux/adb -s emulator-5554 uninstall com.microsoft.maui.controls.devicetests'
�[40m�[32minfo�[39m�[22m�[49m: Successfully uninstalled com.microsoft.maui.controls.devicetests
XHarness exit code: 0
Tests completed successfully
📁 Fix files reverted (3 files)
eng/pipelines/ci-copilot.ymlsrc/Controls/src/Core/RadioButton/RadioButton.cssrc/Core/src/Platform/Android/SemanticExtensions.cs
UI Tests — RadioButton,ViewBaseTests
Detected UI test categories: RadioButton,ViewBaseTests
❌ Deep UI tests — 0 passed; 2 category setup failures (146 impacted tests marked failed by TRX) across 2 categories on platform-pool agent (replaces in-process counts above).
🧪 UI Test Execution Results (deep, platform pool)
| Category | Tests | Snapshot diffs |
|---|---|---|
RadioButton |
0/27 (setup failed; 27 marked failed) | — |
ViewBaseTests |
0/119 (setup failed; 119 marked failed) | — |
⚠️ RadioButton — fixture setup failed for 27 tests
NUnit reported a OneTimeSetUp/fixture setup failure before test bodies ran; the TRX marked each affected test failed.
Multiple setup failure signatures were present; showing the first one. See the TRX artifact for all details.
OneTimeSetUp: System.TimeoutException : ContentPresenter just rendering component string in .Net9
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
at Microsoft.Maui.TestCases.Tests._IssuesUITest.NavigateToIssue(String issue) in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 54
at Microsoft.Maui.TestCases.Tests._IssuesUITest.TryToResetTestState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_IssuesUITest.cs:line 25
at Microsoft.Maui.TestCases.Tests.UITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 576
at UITest.Appium.NUnit.UITestBase.OneTimeSetup() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 221
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
at System.Run
...
⚠️ ViewBaseTests — fixture setup failed for 119 tests
NUnit reported a OneTimeSetUp/fixture setup failure before test bodies ran; the TRX marked each affected test failed.
Multiple setup failure signatures were present; showing the first one. See the TRX artifact for all details.
OneTimeSetUp: System.TimeoutException : Timed out waiting for Go To Test button to appear
at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2757
at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2784
at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 793
at Microsoft.Maui.TestCases.Tests.UtilExtensions.NavigateToGallery(IApp app, String page) in /_/src/Controls/tests/TestCases.Shared.Tests/UtilExtensions.cs:line 37
at Microsoft.Maui.TestCases.Tests._GalleryUITest.FixtureSetup() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/_GalleryUITest.cs:line 57
at UITest.Appium.NUnit.UITestBase.OneTimeSetup() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 221
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStac
...
📎 Download drop-deep-uitests artifact (TRX + snapshot diffs)
Pre-Flight — Context & Validation
Pre-Flight Summary
PR: #35625
Platform for testing: Android
Gate: Already completed externally — PASSED. Gate output was not modified.
Context
PR #35625 changes RadioButton accessibility behavior by reverting the semantic-content extraction and Android semantic-node updates introduced by the earlier RadioButton accessibility fix. GitHub CLI authentication is unavailable in this environment, so context was gathered from local repository state, public GitHub API access where available, and full source/diff review.
Changed Files
src/Controls/src/Core/RadioButton/RadioButton.cssrc/Core/src/Platform/Android/SemanticExtensions.cssrc/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs
Code Review Summary
Verdict: NEEDS_CHANGES
Confidence: high
The PR appears over-broad: it removes the original accessibility fix and its regression tests instead of addressing likely narrow regressions. The main risks are reintroducing type-name announcements for templated/view-content RadioButtons and losing Android TalkBack role/state for templated RadioButtons.
Try-Fix Inputs
Problem: Preserve correct RadioButton accessibility semantics for templated/view-content RadioButtons on Android while avoiding regressions from the previous implementation.
Target files:
src/Controls/src/Core/RadioButton/RadioButton.cssrc/Core/src/Platform/Android/SemanticExtensions.cssrc/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs
Relevant failure modes:
- View-based RadioButton content should expose child label/semantic text, not a CLR type name.
- Explicit
SemanticProperties.Descriptionshould not be overwritten by content-derived semantics. - Android templated RadioButtons should expose radio-button role and checked state to TalkBack.
- If no text is found in view-based content, fallback should continue to
ValueorContentAsString()rather than returningnull.
Code Review — Deep Analysis
Code Review — PR #35625
Independent Assessment
What this changes: PR #35625 removes the RadioButton semantic-content extraction added by the prior accessibility fix, removes Android AccessibilityNodeInfoCompat radio-button role/state population for IRadioButton, and deletes the corresponding Android device regression tests.
Inferred motivation: The PR appears to be a revert of PR #34521, likely due to a regression in that fix, but the available local/GitHub metadata did not expose a concrete replacement strategy.
Reconciliation with PR Narrative
Author claims: GitHub CLI authentication was unavailable; public API data was partially accessible via curl, but the review is based primarily on local diff/source context and PR metadata.
Agreement/disagreement: The diff does simplify the code, but it also reintroduces the original accessibility regression for templated/view-content RadioButtons and removes the tests proving the behavior.
Findings
❌ Error — Issue #34322 behavior is reintroduced for view-based RadioButton content
src/Controls/src/Core/RadioButton/RadioButton.cs changes UpdateSemantics() back from semantic extraction to ContentAsString(). For Content values that are IView/layout instances, ContentAsString() ultimately uses ToString(), so a templated RadioButton with content like VerticalStackLayout { Label("Dog") } can expose a type name instead of the intended accessible label.
❌ Error — Android templated RadioButtons lose explicit role/state semantics
src/Core/src/Platform/Android/SemanticExtensions.cs removes the IRadioButton block that set ClassName, Checkable, and Checked on AccessibilityNodeInfoCompat. Native non-templated Android radio buttons may still get this from AppCompatRadioButton, but templated RadioButtons use container views and need explicit role/value information for TalkBack.
❌ Error — Regression tests are deleted without replacement
src/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs removes tests for templated RadioButton semantic label extraction and explicit semantic-description precedence. A revert might be justified if PR #34521 introduced a distinct bug, but this PR does not preserve coverage for the original issue or add coverage for the alleged regression.
⚠️ Warning — The prior implementation likely had a surgical bug rather than requiring a wholesale revert
The removed GetSemanticDescriptionFromContent() returned null when Content is IView but no textual semantic description was found, preventing fallback to Value or ContentAsString(). That is a small control-flow bug that can be fixed by falling through when recursive extraction fails.
Failure Modes
- Templated RadioButton with
Content = new VerticalStackLayout { Children = { new Label { Text = "Dog" } } }: accessible description may becomeMicrosoft.Maui.Controls.VerticalStackLayoutinstead ofDog. - Android templated RadioButton: TalkBack may not announce role/state (
radio button,checked/not checked) because the platform view is not anAppCompatRadioButton. Content is IViewwith no text butValue = "Dog": the prior fix can returnnullinstead of falling back toValueunless corrected surgically.
Blast Radius
Affects MAUI RadioButton accessibility on Android and cross-platform semantics for templated/view-content RadioButtons. Native non-templated string-content RadioButtons are lower risk.
Devil's Advocate
The PR may be responding to a real regression from PR #34521, especially around Android native role duplication or the null-return fallback path. However, the broad revert removes both the useful semantic extraction and the Android templated role/state support, so the safer path is a narrower alternative fix.
Verdict: NEEDS_CHANGES
Confidence: high
Summary: The PR reverts a legitimate accessibility fix and deletes its tests. A better candidate should preserve view-content semantic extraction, preserve Android role/state for templated RadioButtons, and fix any regression surgically.
Try-Fix Hints
- Root problem: retain RadioButton accessibility semantics while avoiding regressions introduced by the previous broad implementation.
- Target files:
src/Controls/src/Core/RadioButton/RadioButton.cs,src/Core/src/Platform/Android/SemanticExtensions.cs,src/Controls/tests/DeviceTests/Elements/RadioButton/RadioButtonTests.cs. - Candidate direction: make
GetSemanticDescriptionFromContent()fall through toValue/ContentAsString()when recursive extraction fromIViewfails. - Candidate direction: apply Android
AccessibilityNodeInfoCompatradio-button role/state only for non-native/templated RadioButtons, avoiding duplication onAppCompatRadioButton.
Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix | Preserve RadioButton accessibility fix; add fallback when view-content semantic extraction fails; guard Android role/state injection to non-native platform views | ✅ PASS | 2 files | Better than PR #35625 because it keeps the accessibility behavior and regression tests instead of reverting them wholesale. |
| PR | PR #35625 | Broad revert of RadioButton semantic extraction, Android IRadioButton semantic node info, and regression tests | ✅ PASSED (Gate) | 3 files | Gate passed, but code review found it reintroduces the accessibility regression. |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| maui-expert-reviewer | 1 | Yes | Surgical preserve-and-fix candidate: fall through from failed view-content extraction and guard Android native radio-button role/state duplication. |
Exhausted: No — stopped because Candidate #1 passed the Android regression test command and is materially better than the PR's current broad revert.
Selected Fix: Candidate #1 — Retains correct accessibility semantics while addressing likely regressions narrowly.
Report — Final Recommendation
Comparative Report - PR #35625
Candidates compared
| Rank | Candidate | Regression result | Assessment |
|---|---|---|---|
| 1 | try-fix-1 |
PASS | Best candidate. It preserves the RadioButton accessibility fix and tests while narrowly addressing the Android regression by falling back only when semantic extraction finds no text and avoiding radio-button node-state injection for native CompoundButton platform views. |
| 2 | pr-plus-reviewer |
Not independently rerun | Good direction and effectively converges on the same surgical approach as try-fix-1, but it is a reviewer-derived sandbox candidate rather than the empirically tested Step 5a candidate. |
| 3 | pr |
Gate PASSED | The submitted PR fixes the immediate Android gate scenario but is over-broad: it reintroduces the templated RadioButton accessibility regression by using ContentAsString() for view content, removes Android role/state semantics for templated RadioButtons, and deletes regression tests. |
Analysis
The raw PR should not win because the expert review found a concrete accessibility regression on an added/modified diff line. ContentAsString() is not safe for templated RadioButtons with view content because it can announce a CLR type name instead of meaningful child text, which was the behavior fixed by the earlier accessibility change.
pr-plus-reviewer is materially better than the raw PR because it applies the expert reviewer's feedback: keep semantic extraction and fix only the Android-specific problematic path. However, among the non-raw candidates, try-fix-1 has the same surgical design and has an explicit Android device-test PASS from STEP 5a.
Winner
try-fix-1 is the single winning candidate. It is the highest-ranked candidate with passing regression evidence and avoids both the Android crash/regression targeted by PR #35625 and the accessibility regression reintroduced by the submitted PR.
Future Action — alternative fix proposed (try-fix-1)
Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against automatically generated candidates and selected try-fix-1 as the strongest fix.
Why: try-fix-1 wins because it passed the Android regression test and fixes the issue surgically while preserving the templated RadioButton accessibility behavior and tests. The raw PR passes the gate but reintroduces a known accessibility regression; pr-plus-reviewer converges on the same approach as try-fix-1 but lacks separate Step 5a regression evidence.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (try-fix-1)
diff --git a/src/Controls/src/Core/RadioButton/RadioButton.cs b/src/Controls/src/Core/RadioButton/RadioButton.cs
index 53855d94e1..fdac49a931 100644
--- a/src/Controls/src/Core/RadioButton/RadioButton.cs
+++ b/src/Controls/src/Core/RadioButton/RadioButton.cs
@@ -775,8 +775,10 @@ namespace Microsoft.Maui.Controls
{
// Don't fall back to ContentAsString() for view-based content — it calls ToString()
// on the view and returns a type name rather than meaningful text.
- TryGetSemanticDescription(contentView, out var semanticDescription);
- return semanticDescription;
+ if (TryGetSemanticDescription(contentView, out var semanticDescription))
+ {
+ return semanticDescription;
+ }
}
if (Value is string valueText && !string.IsNullOrWhiteSpace(valueText))
diff --git a/src/Core/src/Platform/Android/SemanticExtensions.cs b/src/Core/src/Platform/Android/SemanticExtensions.cs
index 222b2d91dc..710aadd43b 100644
--- a/src/Core/src/Platform/Android/SemanticExtensions.cs
+++ b/src/Core/src/Platform/Android/SemanticExtensions.cs
@@ -92,7 +92,7 @@ namespace Microsoft.Maui.Platform
if (!string.IsNullOrWhiteSpace(newText))
info.Text = newText;
- if (virtualView is IRadioButton radioButton)
+ if (virtualView is IRadioButton radioButton && platformView is not CompoundButton)
{
info.ClassName = s_radioButtonClassName;
info.Checkable = true;
…nt (#35625) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue details: A regression was introduced by PR #[34521](#34521) on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3. ### Description of changes: Fully reverts PR #[34521](#34521). Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #[34322](#34322) and their helper methods. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #35584 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
…RadioButtons with Content (#35694) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! Backport of #35625 to `release/10.0.1xx-sr7`. /cc @PureWeen Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com>
Discovered during SR8 dogfooding: SR branches in dotnet/maui ALWAYS cut from
main, never from inflight/staging/backport refs. The original script defaulted
ExcludeBranches to 'origin/main,origin/inflight/current', which was wrong —
comparing SR contents against inflight produces incorrect 'what's shipping'
answers.
Changes:
* Hard validation in Resolve-Context refuses inflight/*, staging/*, and
backport/* as SR refs (throws a clear error). Also drops any inflight/*
exclude branch with a warning.
* New -Candidate switch for pre-flight: when the next SR branch doesn't exist
yet ('Is SR8 ready?' but only sr7 exists), pass -Candidate with the most
recent SR as the baseline. The script then treats origin/main as the
'SR-to-be' and excludes the prior SR. Report header is clearly labeled
'CANDIDATE for next SR'.
* Default ExcludeBranches changed from 'origin/main,origin/inflight/current'
to 'origin/main' (the inflight ref was always wrong).
* Fix: sourcePrCount field was missing from JSON output (only sourcePrs
array was populated).
* New unit tests for the validation rules (6 cases). Existing E2E continues
to pass against SR7. Total: 21/21 tests pass.
* Agent file updated with a new step 0 'Hard rule' section, a step 1b
'Candidate mode' section, and a new anti-pattern about inflight refs.
Verified on dogfood run: 'main vs sr7' surfaced 112 candidate commits + 11
regression issues, and correctly flagged #35584 as merged-non-main-only
(fix PR #35625 went to inflight/current but not to main — needs to flow).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Three improvements driven by SR8 dogfood: 1. New -InheritFromPriorSr flag for candidate mode. dotnet/maui's SR workflow is 'cut SRn+1 from main, then merge SRn into it' — so the SR-to-be contents = main-since-priorSR ∪ priorSR-only commits. The prior candidate model only saw main-since-priorSR, which made fixes that live only in SR7 look 'missing from SR8'. The new flag does a second 'git log priorSR ^main' pass and unions the source PRs, tagging each commit with origin = primary | inherited. Report header reads 'CANDIDATE for next SR (main + inherited from <prior>)' and the contents section splits into 'from main' vs 'inherited from <prior>'. 2. Skip Revert PRs as candidate fixes. If a 'Fixes #N' link points to a PR whose title starts with 'Revert ...', that PR is a rollback, not a fix — counting it as the fix produces false 'in-sr-active' verdicts when the actual fix has been backed out. When the only candidates are reverts the issue is classified needs-human-review with evidence 'All candidate fix PRs were Revert PRs — original fix may be missing or in a revert-of-revert chain.' This catches the #35584 / #35625 / #35694 chain cleanly. 3. Hard rule on the agent: report-only. The release-readiness agent and skill now declare in their first section that they NEVER mutate the dotnet/maui repo — no branch cuts, no SR merges, no tags, no pushes to release/* refs. If asked to perform a release operation, the agent refuses and surfaces copy-pasteable commands for the human release captain. Test coverage: 5 new tests cover the -InheritFromPriorSr happy path, the param-validation guard, the union semantics, and the well-known SR7-only backport (#35428) showing up via inheritance. All 26 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…xx-sr8 (#35810) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Cut-then-merge step 2 of 2 SR8 was cut from `main` at [`e02d6b6dc2`](e02d6b6) (commit "Add gh-aw rerun review scanner (#35685)"). This PR pulls the SR7 stabilization work into SR8 so SR8 contains everything that's in SR7. - **Base:** `release/10.0.1xx-sr8` @ [`e02d6b6dc2`](e02d6b6) - **Merging in:** `release/10.0.1xx-sr7` @ [`9da598b4a1`](9da598b) (PatchVersion bump to 71) - **Merge base:** [`f8cb875e`](f8cb875eee) ("[Testing] The Windows WebView category is removed from CI…" #35335) - **Strategy:** non-fast-forward merge commit (preserves both branches' history) ## Conflict resolution Two trivial conflicts, both resolved by taking the SR8 (`HEAD`) side: | File | Why it conflicted | Resolution | | --- | --- | --- | | [`eng/Versions.props`](https://github.com/dotnet/maui/blob/release/10.0.1xx-sr8/eng/Versions.props) | SR7 bumped `PatchVersion` 70→71 (#35786); SR8 starts at 80 | Keep `PatchVersion=80` (SR8 is the higher patch band) | | `src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs` | Whitespace-only difference (`false; //` vs `false; //`) in two comments | Keep SR8's whitespace | No semantic conflicts. ## Inherited from SR7 26 SR7-only commits land in SR8 via this merge. The source PRs are: <details> <summary>Source PRs (43, deduped by commit)</summary> #35020, #35072, #35092, #35150, #35223, #35299, #35305, #35347, #35356, #35359, #35360, #35421, #35423, #35424, #35425, #35426, #35427, #35428, #35430, #35434, #35441, #35447, #35461, #35480, #35503, #35520, #35521, #35559, #35566, #35585, #35625, #35642, #35664, #35689, #35690, #35691, #35692, #35693, #35694, #35703, #35744, #35768, #35786 Includes the SR7 revert chain: - #35689 — Revert PR #30068 (FontImageSource centering on Windows) - #35694 — Revert TalkBack RadioButton fix - #35703 — Revert Shell.NavBarIsVisible fix - #35744 — Revert HybridWebView WebView fix - #35461, #35503 — additional Android reverts </details> After this lands, the release-readiness tracker can survey `release/10.0.1xx-sr8` directly instead of using `-Candidate -InheritFromPriorSr` mode against SR7.
…nt (#35625) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue details: A regression was introduced by PR #[34521](#34521) on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3. ### Description of changes: Fully reverts PR #[34521](#34521). Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #[34322](#34322) and their helper methods. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #35584 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
Discovered during SR8 dogfooding: SR branches in dotnet/maui ALWAYS cut from
main, never from inflight/staging/backport refs. The original script defaulted
ExcludeBranches to 'origin/main,origin/inflight/current', which was wrong —
comparing SR contents against inflight produces incorrect 'what's shipping'
answers.
Changes:
* Hard validation in Resolve-Context refuses inflight/*, staging/*, and
backport/* as SR refs (throws a clear error). Also drops any inflight/*
exclude branch with a warning.
* New -Candidate switch for pre-flight: when the next SR branch doesn't exist
yet ('Is SR8 ready?' but only sr7 exists), pass -Candidate with the most
recent SR as the baseline. The script then treats origin/main as the
'SR-to-be' and excludes the prior SR. Report header is clearly labeled
'CANDIDATE for next SR'.
* Default ExcludeBranches changed from 'origin/main,origin/inflight/current'
to 'origin/main' (the inflight ref was always wrong).
* Fix: sourcePrCount field was missing from JSON output (only sourcePrs
array was populated).
* New unit tests for the validation rules (6 cases). Existing E2E continues
to pass against SR7. Total: 21/21 tests pass.
* Agent file updated with a new step 0 'Hard rule' section, a step 1b
'Candidate mode' section, and a new anti-pattern about inflight refs.
Verified on dogfood run: 'main vs sr7' surfaced 112 candidate commits + 11
regression issues, and correctly flagged #35584 as merged-non-main-only
(fix PR #35625 went to inflight/current but not to main — needs to flow).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Three improvements driven by SR8 dogfood: 1. New -InheritFromPriorSr flag for candidate mode. dotnet/maui's SR workflow is 'cut SRn+1 from main, then merge SRn into it' — so the SR-to-be contents = main-since-priorSR ∪ priorSR-only commits. The prior candidate model only saw main-since-priorSR, which made fixes that live only in SR7 look 'missing from SR8'. The new flag does a second 'git log priorSR ^main' pass and unions the source PRs, tagging each commit with origin = primary | inherited. Report header reads 'CANDIDATE for next SR (main + inherited from <prior>)' and the contents section splits into 'from main' vs 'inherited from <prior>'. 2. Skip Revert PRs as candidate fixes. If a 'Fixes #N' link points to a PR whose title starts with 'Revert ...', that PR is a rollback, not a fix — counting it as the fix produces false 'in-sr-active' verdicts when the actual fix has been backed out. When the only candidates are reverts the issue is classified needs-human-review with evidence 'All candidate fix PRs were Revert PRs — original fix may be missing or in a revert-of-revert chain.' This catches the #35584 / #35625 / #35694 chain cleanly. 3. Hard rule on the agent: report-only. The release-readiness agent and skill now declare in their first section that they NEVER mutate the dotnet/maui repo — no branch cuts, no SR merges, no tags, no pushes to release/* refs. If asked to perform a release operation, the agent refuses and surfaces copy-pasteable commands for the human release captain. Test coverage: 5 new tests cover the -InheritFromPriorSr happy path, the param-validation guard, the union semantics, and the well-known SR7-only backport (#35428) showing up via inheritance. All 26 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Problem The milestone-drift automation (`Fix-MilestoneDrift.ps1`) maps a commit found on an SR release branch to a milestone using **only the branch name** — `release/10.0.1xx-sr7` → `.NET 10 SR7`. But a single SR release branch ships **many servicing drops** over its lifetime (`10.0.70` = SR7, `10.0.71` = SR7.1, `10.0.72` = SR7.2, …), so the base SR is too coarse. A revert/hotfix that lands **after** the base SR shipped actually goes out in a later sub-patch. Milestoning it as the base SR is wrong — and can even **downgrade** an already-correct SR7.1 issue back to SR7. ### Concrete case that motivated this - PR #35694 is a backport to `release/10.0.1xx-sr7`; its commit is contained only in tag `10.0.71` → it ships in **SR7.1**. - It directly links the issue via `Fixes #35584`. - Before this change the script resolved #35694 → **SR7** (branch name), which would *downgrade* issue #35584 from SR7.1 → SR7. ## Root cause `Find-ReleaseBranchForCommit` resolved the milestone via `ConvertBranchToMilestone` (branch-name only), which has no notion of sub-patches. ## Fix (general — no special-casing) Add `Get-RefinedReleaseMilestone`: for a commit found on an **SR** branch, resolve the milestone from the **earliest SR-family tag** (`X.0.{sr}{sub}`) that actually contains the commit (git ancestry). Rules: - **Earliest release wins** — return the earliest family tag that contains the commit. - If no family tag contains it yet (the drop isn't tagged), use the **next sub-patch** after the latest shipped family tag — **clamped to the SR family** so it never crosses into the next SR (an exhausted SR7 at `.79` falls back to base SR7, never predicts SR8). - **Non-SR** milestones (preview/rc/GA) are returned unchanged. It's wired into both match paths of `Find-ReleaseBranchForCommit`. The PR-number grep fallback now captures the **oldest** on-branch SHA (`--reverse`, so a later revert that re-mentions `(#NNN)` can't hijack the result) and is hardened against stderr noise (`2>$null` + strict 40-hex SHA filter). Result: #35694 → **SR7.1**, so its existing `Fixes #35584` link marks the issue **SR7.1**. The existing earliest-release-wins guard reconciles the issue regardless of merge order. Note: PR #35625 (the same revert on `inflight/current`) intentionally stays **SR9** — a PR's milestone tracks the physical branch it merged into; the *issue* converges to the earliest customer-facing release (SR7.1). ## Verification - ✅ Dry-run #35694 → `.NET 10 SR7.1` (was SR7); issue #35584 already-correct (no downgrade). - ✅ Regression dry-runs unchanged: #34620 → SR6, #35016 → SR6, #30132 → preview3. - ✅ Pester suite: **162 passed, 0 failed** (9 new unit tests for the helper, incl. the family-boundary clamp). ## Review Reviewed with three independent models (GPT-5.5, Gemini 3.1 Pro, Claude Opus 4.8). Consensus on correctness and contained blast radius (refinement only ever moves *within* one SR family). Their concrete findings — boundary clamp, stderr hardening, oldest-match grep, and a dead parameter — were all addressed in this PR. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…nt (#35625) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue details: A regression was introduced by PR #[34521](#34521) on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3. ### Description of changes: Fully reverts PR #[34521](#34521). Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #[34322](#34322) and their helper methods. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #35584 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
…nt (#35625) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue details: A regression was introduced by PR #[34521](#34521) on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3. ### Description of changes: Fully reverts PR #[34521](#34521). Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #[34322](#34322) and their helper methods. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #35584 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
…nt (#35625) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue details: A regression was introduced by PR #[34521](#34521) on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3. ### Description of changes: Fully reverts PR #[34521](#34521). Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #[34322](#34322) and their helper methods. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #35584 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com>
## What's Coming .NET MAUI inflight/candidate introduces significant improvements across all platforms with focus on quality, performance, and developer experience. This release includes 153 commits with various improvements, bug fixes, and enhancements. ## Activityindicator - [Android] Fix CollectionView ActivityIndicator not animating after header height change by @Vignesh-SF3580 in #35358 <details> <summary>🔧 Fixes</summary> - [CollectionView items fail to update ActivityIndicator state after header height change](#33780) </details> ## Animation - [Android] Fix Shadow property affecting transform matrix. by @Shalini-Ashokan in #32962 <details> <summary>🔧 Fixes</summary> - [[Android] Applying Shadow property affects the properties in Visual Transform Matrix](#32731) </details> ## API - Add delegate-based alert dialog extensibility convention (no public API changes) by @Redth in #35095 <details> <summary>🔧 Fixes</summary> - [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`, `DisplayPromptAsync`) needs a public extensibility point](#34104) </details> ## Blazor - [Android] Fix for BlazorWebView predictive back callback blocks Android back-to-home animation by @BagavathiPerumal in #35538 <details> <summary>🔧 Fixes</summary> - [[Android] BlazorWebView predictive back callback blocks Android back-to-home animation](#35397) </details> - [Android] Fix BlazorWebView back callback can swallow the first Back press when its callback is stale-enabled by @devanathan-vaithiyanathan in #35611 <details> <summary>🔧 Fixes</summary> - [[inflight regression] Android BlazorWebView back callback can swallow the first Back press when its callback is stale-enabled](#35573) </details> ## Border - [Windows] Fixed the ContentView clip is not updated when wrapping inside the Border by @Ahamed-Ali in #30408 <details> <summary>🔧 Fixes</summary> - [[Windows] ContentView clip is not updated when wrapping inside the Border](#30404) </details> - Fix Border.StrokeDashArray leaks dashed Borders when using a shared Application resource by @devanathan-vaithiyanathan in #35544 <details> <summary>🔧 Fixes</summary> - [`Border.StrokeDashArray` leaks dashed Borders when using a shared Application resource](#35492) </details> - [Windows] Border: Add AutomationPeer support by @Vignesh-SF3580 in #35577 <details> <summary>🔧 Fixes</summary> - [Adding AutomationPeers to Windows Borders](#27627) </details> - [Windows] Fixed BoxView improper rendering inside Border by @Dhivya-SF4094 in #28465 <details> <summary>🔧 Fixes</summary> - [[Windows] Issues with BoxView Placement Inside Border](#19668) </details> ## Button - Prevent NullReferenceException in LayoutButton by @GamesAgeddon in #35284 <details> <summary>🔧 Fixes</summary> - [NullReferenceException on iOS in Button.LayoutButton from WrapperView.LayoutSubviews](#31048) </details> - Fix TextColor null reset to restore platform defaults on iOS and Android by @Shalini-Ashokan in #35563 <details> <summary>🔧 Fixes</summary> - [[Windows, Android, iOS & Mac]Button TextColor does not restore to platform default when reset to null after dynamic update](#35513) </details> ## CollectionView - Fix CollectionView grid spacing updates for first row and column by @KarthikRajaKalaimani in #34527 <details> <summary>🔧 Fixes</summary> - [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item Spacing - horizontally updating the spacing only applies to the second column](#34257) </details> - [MacCatalyst] Fix CollectionView Header/Footer Not Expanding to Content Width by @KarthikRajaKalaimani in #35213 <details> <summary>🔧 Fixes</summary> - [[MacOS][CV2] I8_View header and footer_Horizontal_View - Footer on the right doesn't adapt when resizing the window](#35113) </details> - [iOS/MacCatalyst] Fix IndicatorView not updating when IndicatorSize is changed to default value by @Shalini-Ashokan in #35215 <details> <summary>🔧 Fixes</summary> - [[iOS/MacCatalyst] IndicatorView does not update when IndicatorSize is dynamically changed to the default value](#35214) </details> - CollectionView selecteditem background lost if collectionview (or parent) IsEnabled changed. by @KarthikRajaKalaimani in #31540 <details> <summary>🔧 Fixes</summary> - [CollectionView selecteditem background lost if collectionview (or parent) IsEnabled changed.](#20615) </details> - [iOS/macOS] CollectionView: Fix FlowDirection not working on EmptyView by @Dhivya-SF4094 in #32674 <details> <summary>🔧 Fixes</summary> - [[iOS, MacOS] FlowDirection not working on EmptyView in CollectionView](#32404) - [[iOS, Mac] CollectionView EmptyViewTemplate content text is mirrored when FlowDirection is RightToLeft](#34522) </details> - Fix iOS CollectionView stale layout invalidations by @filipnavara in #35245 <details> <summary>🔧 Fixes</summary> - [[iOS] CollectionView tries to invalidate cells with invalid indexes](#35244) </details> - Fix Android grouped CollectionView header/footer rebind leak by @AdamEssenmacher in #35368 <details> <summary>🔧 Fixes</summary> - [Memory leak when scrolling a CollectionView with IsGrouped=true](#17698) </details> - [Windows] Fix for Item should scrolled based on the GroupHeaderTemplate by @SuthiYuvaraj in #28074 <details> <summary>🔧 Fixes</summary> - [I9_Scroll by object for grouped data - The group name is always pined at the top after clicking 'Scroll to Proboscis Monkey' button](#27922) </details> - [Android] Fix ScrollTo regression when IsGrouped true on CollectionView by @SubhikshaSf4851 in #35356 <details> <summary>🔧 Fixes</summary> - [[10.0.60] ScrollTo(0) not working anymore on CollectionView when IsGrouped="True"](#35313) </details> - [Android] Fix CollectionView scrolling performance regression by @devanathan-vaithiyanathan in #35379 <details> <summary>🔧 Fixes</summary> - [[10.0.60] CollectionView scrolling performance regression](#35344) </details> - Optimize parent dynamic resource refresh by @AdamEssenmacher in #35408 <details> <summary>🔧 Fixes</summary> - [Memory usage increases when scrolling collectionview if resources count is more than 191](#22053) </details> - Fix CI failure for CollectionView Scrolling Feature Tests due to PR #35379 by @devanathan-vaithiyanathan in #35536 - [iOS & Mac] CarouselViewController2 leaks on iOS/MacCatalyst due to unremoved orientation notification observer by @SubhikshaSf4851 in #35532 <details> <summary>🔧 Fixes</summary> - [CarouselViewController2 leaks on iOS/MacCatalyst due to unremoved orientation notification observer](#35472) </details> - Fix CollectionView.SelectedItems leaks popped views when bound to a retained ObservableCollection by @HarishwaranVijayakumar in #35558 <details> <summary>🔧 Fixes</summary> - [`CollectionView.SelectedItems` leaks popped views when bound to a retained `ObservableCollection`](#35497) </details> - Fix for Android - Dynamic Updates to CollectionView Header/Footer and Templates Are Not Displayed by @SuthiYuvaraj in #28904 <details> <summary>🔧 Fixes</summary> - [Android - Dynamic Updates to CollectionView Header/Footer and Templates Are Not Displayed](#28676) </details> - [Windows] Fix CarouselView EmptyView display when filtering to zero items by @Shalini-Ashokan in #29247 <details> <summary>🔧 Fixes</summary> - [[Windows] [Scenario Day] EmptyView using Template displayed at the same time as the content](#7150) </details> - [Android/iOS] Fix IsEnabled=False on CollectionView not working by @devanathan-vaithiyanathan in #27749 <details> <summary>🔧 Fixes</summary> - [[iOS/Android] CollectionView IsEnabled Not Working](#27770) </details> - Fix CarouselView.Loop property does not update dynamically and fails to maintain the scroll position when the loop value is changed at runtime by @devanathan-vaithiyanathan in #29527 <details> <summary>🔧 Fixes</summary> - [[Android] CarouselView.Loop = false causes crash on Android when changed at runtime](#29411) - [Loop Binding in CarouselView Not Updating Dynamically at Runtime](#29449) </details> - [iOS / Mac] Fix CollectionView.ScrollTo(index) silently failing whenIsGrouped="True" by @Dhivya-SF4094 in #35609 <details> <summary>🔧 Fixes</summary> - [CollectionView.ScrollTo(index) doesn't work correctly when IsGrouped="True" on iOS, MacCatalyst, and Windows](#35326) </details> - Fix Android nested carousel scrolling by @AdamEssenmacher in #35656 <details> <summary>🔧 Fixes</summary> - [Vertical scrolling not working for CarouselView and CustomLayouts](#7814) </details> - [Inflight regression] Fixed Test failures ModalTabbedPagePushAsyncShouldOverlayBottomNavigationView and GroupedCollectionViewScrollToIndexScrollsToCorrectItem by @Dhivya-SF4094 in #35823 - Fix CarouselView tests fail in June 8 Candidate by @devanathan-vaithiyanathan in #35825 ## Core - Reduce allocations on AnimationManager by @pictos in #35612 <details> <summary>🔧 Fixes</summary> - [AnimationManager is allocating a lot](#35654) </details> ## Core Lifecycle - Fix device test memory by @pictos in #35487 <details> <summary>🔧 Fixes</summary> - [Memory leak Device.Test pass with false positive](#35485) </details> ## Datepicker - Fix MacCatalyst DatePicker focus handling by @AdamEssenmacher in #35553 <details> <summary>🔧 Fixes</summary> - [[mauipalooza] DatePicker focus only works first time](#5947) </details> ## DateTimePicker - [Android] Fix DatePicker dialog dismisses after the device is rotated by @HarishwaranVijayakumar in #34980 <details> <summary>🔧 Fixes</summary> - [[Android] [Regression] DatePicker dialog dismisses after the device is rotated](#34973) </details> ## Docs - doc: Add paragraph to README.md explaining how to fetch the `maui` project templates by @durandt in #34561 ## Drawing - [Android] Fix LinearGradientBrush rendering as opaque black box by @SubhikshaSf4851 in #35299 <details> <summary>🔧 Fixes</summary> - [[Regression] LinearGradientBrush broken on Android in 10.0.60](#35280) - [10.0.60 breaks transparency on Brushes (on Android?)](#35354) </details> - Fix polygon points collection handler leak by @AdamEssenmacher in #35526 <details> <summary>🔧 Fixes</summary> - [PolygonHandler and PolylineHandler leak when Points is replaced before disconnect](#35387) </details> ## Editor - [iOS] Fix Editor losing scrollability after rotation when CharacterSpacing is applied by @Vignesh-SF3580 in #35309 <details> <summary>🔧 Fixes</summary> - [[.NET 10][iOS] D2 - Editor can't be scrolled after rotating simulator.](#35114) </details> - [Inflight/Candidate][iOS & Mac] Fix for Editor height inconsistency when VerticalTextAlignment is Center or End on iOS and MacCatalyst by @BagavathiPerumal in #35662 <details> <summary>🔧 Fixes</summary> - [[MAUI] D13_Customize_Text_Alignment - Text Editor Height is not consistent](#35615) </details> ## Entry - [iOS/Mac] Fix Entry clear button retaining tint color after TextColor is reset to null by @SyedAbdulAzeemSF4852 in #35177 <details> <summary>🔧 Fixes</summary> - [[iOS/Mac]Entry ClearButtonVisibility color does not reset when TextColor is set to null](#35076) </details> - [iOS/MacCatalyst] Fix Entry clear button appearing dimmed compared to TextColor by @SyedAbdulAzeemSF4852 in #35541 <details> <summary>🔧 Fixes</summary> - [[MacCatalyst] [Entry] ClearButtonVisibility color appears dimmed compared to TextColor](#35517) </details> - Fix pill-shaped focus ring on macOS 26 by @Dhivya-SF4094 in #35393 <details> <summary>🔧 Fixes</summary> - [.Net 10 Picker item not centered and wrong focus outline of Entry on Mac](#34899) </details> - Fix Entry select all text on refocus not working on WinUI by @kubaflo in #35383 ## Essentials - [Android] Fix Capture video crashes after stopping recording on Android 12 by @HarishwaranVijayakumar in #35638 <details> <summary>🔧 Fixes</summary> - [Capture video crashes after stopping recording on Android 12](#28891) </details> - [Essentials] Browser.OpenAsync(External): drop visibility-filtered ResolveActivity pre-check by @Kebechet in #35652 <details> <summary>🔧 Fixes</summary> - [Browser.OpenAsync(External) on Android throws FeatureNotSupportedException for verified App Link owner URLs even with documented <queries> fix applied](#35651) </details> ## Essentials Texttospeech - [Mac, iOS, Windows] Fix for inconsistent Text-to-Speech rate behavior by @HarishwaranVijayakumar in #32850 <details> <summary>🔧 Fixes</summary> - [[Essentials] TTS rate](#32492) </details> ## Flyoutpage - [iOS/Mac] Fix FlyoutPage RTL FlowDirection is not working by @devanathan-vaithiyanathan in #34831 <details> <summary>🔧 Fixes</summary> - [[iOS/Mac] FlyoutPage RTL FlowDirection is not working properly](#34830) </details> - [Android] Fix for Android 16 Back button is not working after command from FlyoutPage by @BagavathiPerumal in #35196 <details> <summary>🔧 Fixes</summary> - [Android: BackButton on Android 16 not working after command from FlyOutPage](#33508) </details> ## Gestures - Fix DragGestureRecognizer.DropCompleted event not firing in Android platform by @KarthikRajaKalaimani in #35179 <details> <summary>🔧 Fixes</summary> - [[Android] DragGestureRecognizer.DropCompleted event not firing](#17554) </details> - Windows: Ensure layouts without background participate in hit testing by @jpd21122012 in #34364 <details> <summary>🔧 Fixes</summary> - [[Windows] TapGestureRecognizer does NOT work on a ContentView without Background](#32279) </details> - [iOS] Fix VoiceOver dropping child labels on layouts with SemanticProperties.Hint or TapGestureRecognizer by @Vignesh-SF3580 in #35590 <details> <summary>🔧 Fixes</summary> - [[iOS] VoiceOver does not correctly describe View with GestureRecognizers](#34380) </details> ## Hybridwebview - Fix RemovePossibleQueryString to also strip URL fragments by @kubaflo in #35551 <details> <summary>🔧 Fixes</summary> - [HybridWebViewQueryStringHelper.RemovePossibleQueryString removes '?' but not other special characters e.g. '#'](#31472) </details> - [Revert] - [Windows] Fix WebView blank rendering when used with HybridWebView by @SubhikshaSf4851 in #35814 ## Image - Avoid image source layout invalidation for fixed-size views by @AdamEssenmacher in #35369 <details> <summary>🔧 Fixes</summary> - [Image source swaps thrash layout under fixed constraints, tanking frame rate when scrolling virtualized collections](#32457) </details> - [Windows] Fix Image layout inconsistency caused by async decode race in GetDesiredSize by @praveenkumarkarunanithi in #34699 <details> <summary>🔧 Fixes</summary> - [[Windows] Image cropping produces inconsistent results when window is minimized or resized](#32393) </details> - [Testing] Include more testing around Windows Image Aspect recent fixes by @kubaflo in #35620 <details> <summary>🔧 Fixes</summary> - [[Testing] Include more testing around Windows Image Aspect recent fixes](#31686) </details> - Revert PR #30068 — Fix FontImageSource centering regression on Windows by @Shalini-Ashokan in #35642 <details> <summary>🔧 Fixes</summary> - [[Windows] Image with FontImageSource is not centered and gets clipped when WidthRequest/HeightRequest equals FontImageSource Size](#35618) </details> - [Android] Fix screenshot from WebView content not working by @kubaflo in #35384 <details> <summary>🔧 Fixes</summary> - [[Android] Loading the captured screenshot from webview content to Image control does not visible](#30010) </details> ## Label - Improve label mapping performance and ensure complete coverage including ToPlatform and subsequent property changes by @Tamilarasan-Paranthaman in #31159 - Fix for Label.FormattedText leaks labels when shared FormattedString is stored in Application.Resources by @BagavathiPerumal in #35582 <details> <summary>🔧 Fixes</summary> - [`Label.FormattedText` leaks labels when shared `FormattedString` is stored in `Application.Resources`](#35495) </details> - [iOS] Fix Label Span formatting test failures on candidate branch by @Vignesh-SF3580 in #35815 ## Layout - [iOS, Mac] Fix Item spacing not properly applied between items in Horizontal LinearItemsLayout by @Dhivya-SF4094 in #35445 <details> <summary>🔧 Fixes</summary> - [[CollectionView2] Item spacing not properly applied between items in Horizontal LinearItemsLayout](#35429) </details> - [Windows] Add Automation Id support for Layouts. by @SubhikshaSf4851 in #35562 <details> <summary>🔧 Fixes</summary> - [[Windows] AutomationId does not work for ContentView, Layouts and controls that inherit them](#4715) </details> - Avoid layout diagnostics allocations without listeners by @AdamEssenmacher in #35475 <details> <summary>🔧 Fixes</summary> - [MAUI 10 layout diagnostics no-consumer path is not zero-allocation](#35473) </details> - [Windows/Android] FlexLayout: Fix wrap misalignment due to floating-point precision by @SuthiYuvaraj in #31341 <details> <summary>🔧 Fixes</summary> - [FlexLayout Wrap Misalignment with Dynamically-Sized Buttons in .NET MAUI](#30957) </details> ## Listview - Fix Binding for ListView.IsRefreshing by @bill2004158 in #28516 <details> <summary>🔧 Fixes</summary> - [Bind ListView.IsRefreshing is not work.](#28514) </details> ## Map - Fix iOS/Catalyst MapPool retention with MapElements by @AdamEssenmacher in #35480 <details> <summary>🔧 Fixes</summary> - [iOS/Mac Catalyst MapHandler leaks MAUI Map views and MapElements through MapPool](#35479) </details> - Fix Android map view lifecycle cleanup by @AdamEssenmacher in #35476 <details> <summary>🔧 Fixes</summary> - [Navigating to a page with Maps multiple times Increase RAM Usage but doesn't reduce it back after navigating back](#15257) </details> - Fix Android map element options retention by @AdamEssenmacher in #35634 <details> <summary>🔧 Fixes</summary> - [[Regression] [Android] [Maps] Map locks up after rendering 50 Polylines](#20502) </details> ## Menubar - [MacCatalyst] Fix KeyboardAccelerator with Cmd+Shift modifiers breaks entire MenuBarItem on Mac Catalyst by @KarthikRajaKalaimani in #35318 <details> <summary>🔧 Fixes</summary> - [[Bug] KeyboardAccelerator with Cmd+Shift modifiers breaks entire MenuBarItem on Mac Catalyst](#35279) </details> ## Navigation - [iOS, Mac] Fix OnBackButtonPressed not invoked for NavigationPage and Shell by @Dhivya-SF4094 in #35072 <details> <summary>🔧 Fixes</summary> - [On Screen Back Button Does Not Fire OnBackButtonPressed in Android](#9095) - [ContentPage's OnBackButtonPressed not invoked on iOS and MacCatalyst](#8296) </details> - Fix Android stale ContainerView root leak by @AdamEssenmacher in #35372 <details> <summary>🔧 Fixes</summary> - [Android: Stale ContainerView retains replaced FlyoutPage graph](#35371) </details> - [Android] Fix for predictive back-to-home animation blocked by unconditional back callback registration by @BagavathiPerumal in #35223 <details> <summary>🔧 Fixes</summary> - [OnBackInvokedCallbacks block back-to-home animation](#34594) - [Migrate to OnBackPressedCallback](#24752) </details> - Revert [Android, iOS] - Flyout icon should remain visible when a page is pushed onto a NavigationPage or Shell page with the back button disabled. by @praveenkumarkarunanithi in #35604 ## Picker - [iOS] Fix Picker CharacterSpacing lost after item selection when Title is set by @SyedAbdulAzeemSF4852 in #34974 <details> <summary>🔧 Fixes</summary> - [[iOS] Picker loses CharacterSpacing after item selection when Title is set](#34971) </details> - [iOS] Fix Picker CharacterSpacing ignored on initial load by @SyedAbdulAzeemSF4852 in #34957 <details> <summary>🔧 Fixes</summary> - [[iOS] Picker ignores CharacterSpacing on initial load](#34955) </details> - [Windows] Fix for Picker CharacterSpacing Not Being Applied to Title and Dropdown Items by @SyedAbdulAzeemSF4852 in #30612 <details> <summary>🔧 Fixes</summary> - [[Windows] Picker CharacterSpacing property not applied to Title and PickerItems text](#30464) </details> - Fix Picker SelectedIndex deferred initialization by @AdamEssenmacher in #35629 <details> <summary>🔧 Fixes</summary> - [Picker Attribute "SelectedIndex" Not being respected on page load on Android?](#9150) </details> ## Progressbar - Fix iOS ProgressBar bounding box by @AdamEssenmacher in #35507 <details> <summary>🔧 Fixes</summary> - [[iOS] ProgressBar and Label don't correctly obey height and width at the core level](#7935) </details> ## RadioButton - [Windows, Android] Fix Border Color and Border Width Not applying for Radio Button by @HarishwaranVijayakumar in #35616 <details> <summary>🔧 Fixes</summary> - [[Windows, Android] Border Color and Border Width Not applying for Radio Button.](#35587) </details> - [inflight/current] Fixes a CS0111 build failure in RadioButton.cs caused by a duplicate OnPropertyChanged override by @HarishwaranVijayakumar in #35631 - Revert - Fix TalkBack not correctly narrating RadioButtons with Content by @devanathan-vaithiyanathan in #35625 <details> <summary>🔧 Fixes</summary> - [[Android] MissingMethodException AccessibilityNodeInfoCompat.set_Checked(bool) on 10.0.70 due to AndroidX.Core 1.17 breaking change](#35584) </details> ## Refreshview - [Windows] Fix RefreshView IsRefreshing property not working while binding by @devanathan-vaithiyanathan in #34845 <details> <summary>🔧 Fixes</summary> - [[Windows] RefreshView IsRefreshing property not working while binding](#30535) </details> - [Android] Fix for RefreshView triggering pull-to-refresh when scrolling inside a WebView with internal scrollable content by @BagavathiPerumal in #34614 <details> <summary>🔧 Fixes</summary> - [[Android] RefreshView triggers pull-to-refresh immediately when scrolling up inside a WebView](#33510) </details> ## SafeArea - [Android] Fix bottom safe area padding dropping to zero when keyboard is shown by @praveenkumarkarunanithi in #35084 <details> <summary>🔧 Fixes</summary> - [[Android] Bottom insets issues when keyboard is shown.](#32871) </details> - Gate SafeArea inset listeners in recycler items by @AdamEssenmacher in #35664 <details> <summary>🔧 Fixes</summary> - [[10.0.60] CollectionView scrolling performance regression](#35344) </details> ## ScrollView - [Windows] Fix COMException when restoring a ScrollView as ContentPage.Content after swapping it out by @Vignesh-SF3580 in #35360 <details> <summary>🔧 Fixes</summary> - [COMException when clone a page's content to a object and set it back later in mainthread on Windows](#35277) </details> - Fix - ScrollView.ScrollToAsync(x, y, animated) doesn't work when called from Page.OnAppearing by @Shalini-Ashokan in #35395 <details> <summary>🔧 Fixes</summary> - [[iOS] ScrollView.ScrollToAsync(x, y, animated) doesn't work when called from Page.OnAppearing](#31177) </details> ## Searchbar - [Android] Fix SearchBar IME full-screen extract mode in landscape orientation by @SubhikshaSf4851 in #35197 <details> <summary>🔧 Fixes</summary> - [[Android] Investigate SearchBar presentation in horizontal screen orientation ](#14708) </details> - [iOS 26] Fix SearchBar layout spacing issues for small HeightRequest values by @devanathan-vaithiyanathan in #35347 <details> <summary>🔧 Fixes</summary> - [Spacing problem with maui 10.0.60 iOS](#35286) </details> ## SearchBar - [Windows] Fix SearchHandler does not focus when ShowSoftInputAsync is called by @praveenkumarkarunanithi in #35079 <details> <summary>🔧 Fixes</summary> - [[Windows] SearchHandler.ShowSoftInputAsync() does not focus the SearchHandler](#34930) </details> ## Shell - Fix Android layout jump when navigating with IME open and NavBarIsVisible=false by @jpd21122012 in #34621 <details> <summary>🔧 Fixes</summary> - [Shell page without NavBar jumping when navigating with keyboard open](#34584) </details> - [Android] Add defensive not null check to SearchHandlerAppearanceTracker.FocusChange by @Transis-Felipe in #29939 - [Android] Fix for Shell colors change before navigation completes on Android in .NET 10 by @BagavathiPerumal in #35295 <details> <summary>🔧 Fixes</summary> - [Shell colors change before navigation completes on Android in .NET 10](#35060) </details> - [Windows] Fix Shell FlyoutItem not taking full width by @SubhikshaSf4851 in #35131 <details> <summary>🔧 Fixes</summary> - [MAUI WinUI Grids don't render properly in flyout menu](#19542) - [[Windows] [.NET 8 RC2] FlyoutItem Backgroundcolor Is not fully displaying](#18238) </details> - [Android, iOS, Catalyst] Fix SearchHandler.BackgroundColor cannot be reset to null by @HarishwaranVijayakumar in #35224 <details> <summary>🔧 Fixes</summary> - [[Android, iOS, Catalyst] SearchHandler.BackgroundColor cannot be reset to null](#35088) </details> - Fix for ApplyQueryAttributes being called on non-destination pages during back navigation by @BagavathiPerumal in #35392 <details> <summary>🔧 Fixes</summary> - [ApplyQueryAttributes gets called for not activated (navigated to) page on back](#35183) </details> - [Android] Fix Shell flyout background to follow Material 3 theme colors by @SyedAbdulAzeemSF4852 in #35148 <details> <summary>🔧 Fixes</summary> - [[Android] Shell Flyout ignores Material 3 surface color when UseMaterial3 is enabled](#35147) </details> - [Android] Fix Shell.FlyoutHeader background incorrect by @SyedAbdulAzeemSF4852 in #35489 <details> <summary>🔧 Fixes</summary> - [[Android] Shell.FlyoutHeader background is incorrect](#35416) </details> - [iOS/MacCatalyst] Fix Shell.BackgroundColor not applied to bottom TabBar by @Shalini-Ashokan in #35545 <details> <summary>🔧 Fixes</summary> - [[MacCatalyst] Shell.BackgroundColor not applied to bottom TabBar](#35380) - [[Catalyst] Shell.TabBarBackgroundColor is not applied](#35381) </details> - [Android] Fix Shell FlyoutIcon tint loss after navigation by @SyedAbdulAzeemSF4852 in #35561 <details> <summary>🔧 Fixes</summary> - [[Android] The flyout icon loses colours](#35390) </details> - [iOS] Fix Shell - opened keyboard on modal page shifts parent page/frame behind modal after update to 10.0.60 by @KarthikRajaKalaimani in #35559 <details> <summary>🔧 Fixes</summary> - [[iOS] Shell - opened keyboard on modal page shifts parent page/frame behind modal after update to 10.0.60](#35401) </details> - Fix intermediate pages not receiving query parameters in multi-page Shell navigation by @mattleibow in #35432 <details> <summary>🔧 Fixes</summary> - [Shell GoToAsync: no way to pass query parameters to intermediate pages in multi-segment navigation](#35107) </details> - [Windows] Fix Shell title bar overlap with window controls in RTL mode by @Shalini-Ashokan in #33109 <details> <summary>🔧 Fixes</summary> - [[Windows] Binding RTL FlowDirection in Shell causes Flyout MenuIcon and native window controls to overlap](#32476) </details> - [macOS] Fix IsEnabled property false not working on MenuBarItem by @devanathan-vaithiyanathan in #35546 <details> <summary>🔧 Fixes</summary> - [[macOS] IsEnabled property false not working on MenuBarItem](#34038) </details> - Fix Android Shell top inset when nav bar is hidden by @ne0rrmatrix in #35555 <details> <summary>🔧 Fixes</summary> - [wrong statusbar height when Android device has a notch](#35103) </details> - Fix Changing Content property of ShellContent doesn't change visual content by @devanathan-vaithiyanathan in #34630 <details> <summary>🔧 Fixes</summary> - [Changing Content property of ShellContent doesn't change visual content. ](#12669) </details> - Fixed a NullReferenceException when starting application with empty shell on Windows by @Shalini-Ashokan in #28879 <details> <summary>🔧 Fixes</summary> - [NullReferenceException when starting application with empty shell on Windows](#21562) - [Using SelectionChangedCommand with CollectionView in Shell.FlyoutContent results in Win32 Unhandled Exception](#10041) </details> ## Slider - [iOS] Slider: Scale ThumbImageSource to match default thumb size by @NirmalKumarYuvaraj in #34184 <details> <summary>🔧 Fixes</summary> - [[Slider] MAUI Slider thumb image is big on android](#13258) </details> ## Stepper - Fix iOS 26 Stepper overlap in landscape by @AdamEssenmacher in #35374 <details> <summary>🔧 Fixes</summary> - [[.NET10] D10-The number and buttons overlap after rotating the simulator.](#35211) </details> ## SwipeView - Fix SwipeViews with invoked properties crash the app in Release mode by @BagavathiPerumal in #35208 <details> <summary>🔧 Fixes</summary> - [[iOS/Catalyst] Swipeviews with invoked properties crash the app in Release](#18055) </details> - Fix SwipeItemView command leak by @AdamEssenmacher in #35510 <details> <summary>🔧 Fixes</summary> - [`SwipeItemView.Command` leaks row views and command parameters through `CanExecuteChanged`](#35498) </details> - [iOS/Android] Fix SwipeItem.IsVisible not refreshing native swipe items when binding changes by @SyedAbdulAzeemSF4852 in #35217 <details> <summary>🔧 Fixes</summary> - [SwipeItem.IsVisible doesn't properly refresh the native swipe items when the binding value changes dynamically](#34832) </details> - Fix SwipeView memory leak when SwipeItems are reused or replaced by @Vignesh-SF3580 in #35539 <details> <summary>🔧 Fixes</summary> - [SwipeView leaks when SwipeItems are reused or replaced](#35481) </details> - Fix SwipeItem IconImageSource color handling and rendering across platforms by @Shalini-Ashokan in #35632 <details> <summary>🔧 Fixes</summary> - [[Android] SwipeItem IconImageSource should allow more configuration](#23074) </details> ## Switch - [Android/Windows] Fix RadioButton gradient not clearing when switching background by @Shalini-Ashokan in #34997 <details> <summary>🔧 Fixes</summary> - [RadioButton Background does not reset when set to null at runtime](#34993) </details> - [Windows] Fix "PlatformView cannot be null here" exception during handler disconnect by @kubaflo in #35314 <details> <summary>🔧 Fixes</summary> - ["PlatformView cannot be null here" Exception in Switch control [Windows]](#27101) </details> - [iOS 26] Fix Switch ThumbColor and OffColor not applied on initial load by @SyedAbdulAzeemSF4852 in #35400 <details> <summary>🔧 Fixes</summary> - [iOS 26 Switch default color for Off and On is incorrect + Off Color is not applied at start + Thumb Colors is not applied](#35257) </details> - [Android] Fix AppBar flicker on CheckBox/Switch toggle with Material 3 by @Dhivya-SF4094 in #35181 <details> <summary>🔧 Fixes</summary> - [[Android] AppBar flicker while changing the CheckBox or Switch state after scrolling in Material 3](#35180) </details> - [Android] Fix Switch Shadow Does Not Follow Thumb when Toggle On or Off by @Dhivya-SF4094 in #35623 <details> <summary>🔧 Fixes</summary> - [[Android] Switch Shadow Does Not Follow Thumb when Toggle On or Off](#30046) </details> ## TabbedPage - [Android] Fix TabbedPage truncating tab titles instead of scrolling by @Shalini-Ashokan in #35086 <details> <summary>🔧 Fixes</summary> - [Maui migrating Xamarin to Maui - Tabbed Page Scroll Issue - Tabs are not scrolling](#16470) </details> - [Android] Fix BottomNavigationView remaining visible for TabbedPage inside modal NavigationPage after PushAsync by @Dhivya-SF4094 in #35359 <details> <summary>🔧 Fixes</summary> - [Android TabbedPage inside Modal Navigation does not overlay BottomNavigationView after PushAsync in .NET MAUI 10.0.60](#35331) </details> - [Android & iOS] TabbedPage leaks with shared GradientBrush. by @SubhikshaSf4851 in #35543 <details> <summary>🔧 Fixes</summary> - [TabbedPage leaks renderer/manager when BarBackground uses shared GradientBrush resource](#35469) </details> ## Templates - Bumps Syncfusion.Maui.Toolkit dependency to version 1.0.10 by @PaulAndersonS in #35608 ## Toolbar - Fix Android app bar inset background coloring by @ne0rrmatrix in #35601 <details> <summary>🔧 Fixes</summary> - [Android Edge-to-Edge: Shell and NavigationPage Top Bar colour is not used for status bar.](#35568) </details> ## Tooling - Add default .gitignore to MAUI project templates by @davidortinau in #34862 <details> <summary>🔧 Fixes</summary> - [Add a gitignore file to the Maui template in VS 2022](#4131) </details> - Fix: Propagate AdditionalProperties from ProjectReference in ResizetizeCollectItems by @mattleibow in #35575 <details> <summary>🔧 Fixes</summary> - [Resizetizer GetMauiItems does not propagate ProjectReference AdditionalProperties](#35574) </details> ## WebView - [Windows] Fix WebView blank rendering when used with HybridWebView by @SubhikshaSf4851 in #35092 <details> <summary>🔧 Fixes</summary> - [[Windows] WebView Regression from NET9 to NET10](#34558) </details> - Fix AOT integration test failures: suppress IL3050/IL2026 for HybridWebViewHandler in AddControlsHandlers by @mattleibow via @Copilot in #34868 - Fix Android activity result callback leak by @AdamEssenmacher in #35436 <details> <summary>🔧 Fixes</summary> - [Android WebView file chooser callbacks leak via ActivityResultCallbackRegistry](#35405) </details> - [Windows] Fix WebView Does Not Inherit App Theme by @devanathan-vaithiyanathan in #35037 <details> <summary>🔧 Fixes</summary> - [WebView on Windows Does Not Inherit App Theme](#34823) </details> - Fix for WebView leaks when reusing a shared WebViewSource by @BagavathiPerumal in #35524 <details> <summary>🔧 Fixes</summary> - [WebView leaks when reusing a shared WebViewSource](#35483) </details> - Destroy Android WebView on handler disconnect by @AdamEssenmacher in #35552 <details> <summary>🔧 Fixes</summary> - [Right way to dispose page with WebView](#18021) </details> ## Xaml - Fix: Enable VisualStateManager to set Style property dynamically by @Shalini-Ashokan in #33389 <details> <summary>🔧 Fixes</summary> - [Setting the `Style` property using the `VisualStateManager` within a Style resource does not work](#17175) </details> - Fix Implicit parameter conversion from integer to byte fails with source generated XAML by @KarthikRajaKalaimani in #35444 <details> <summary>🔧 Fixes</summary> - [Implicit parameter conversion from integer to byte fails with source generated XAML](#35396) </details> <details> <summary>🔧 Infrastructure (3)</summary> - Fix: Build fails when appicon is an empty (but valid) SVG by @Shalini-Ashokan in #35305 <details> <summary>🔧 Fixes</summary> - [Build fails when appicon is an empty (but valid) svg after upgrade to 10.0.60](#35293) </details> - [inflight/current] Fix CS0111 duplicate GetNativeCharacterSpacing in PickerHandlerTests.iOS by @SyedAbdulAzeemSF4852 in #35419 - Update WinAppSDK to 1.8.260508005 by @kubaflo in #35678 </details> <details> <summary>🧪 Testing (3)</summary> - Backport Test Fixes and Snapshots from SR to Inflight Branch by @Tamilarasan-Paranthaman in #35499 - Fix hardcoded version of Microsoft.DotNet.XHarness.TestRunners.Xunit in test projects by @akoeplinger in #29905 - [Testing] Fixed Build error on inflight/ candidate PR 35716 by @HarishKumarSF4517 in #35730 </details> <details> <summary>🏠 Housekeeping (1)</summary> - [HouseKeeping] Fix inconsistant namespace in HostApp by @NirmalKumarYuvaraj in #35210 </details> <details> <summary>📦 Other (8)</summary> - Add .cab and ReconnectModal.razor.js to signing config by @jesuszarate in #35026 - Fix typo in Clipboard.shared.cs by @Deadpikle in #35316 - Fix single modifier for NSMenuItem accelerators by @jeremy-visionaid in #35351 - Avoid unnecessary LINQ enumerations by @jeremy-visionaid in #35272 - [Testing] Replace retryDelay with retryTimeout in UI tests by @kubaflo in #35367 - Replace JavaFinalize() with Dispose(bool) in GenericAnimatorListener by @jonathanpeppers in #35548 - Fix incorrect SDK provisioning commands in integration-tests instructions by @davidnguyen-tech in #34992 - Fix VisualElement.ChangeVisualState() gets stuck in Selected state by @Dhivya-SF4094 in #35421 <details> <summary>🔧 Fixes</summary> - [VisualElement's ChangeVisualState gets stuck in Selected state](#35399) </details> </details> <details> <summary>📝 Issue References</summary> Fixes #4131, Fixes #4715, Fixes #5947, Fixes #7150, Fixes #7814, Fixes #7935, Fixes #8296, Fixes #9095, Fixes #9150, Fixes #10041, Fixes #12669, Fixes #13258, Fixes #14708, Fixes #15257, Fixes #16470, Fixes #17175, Fixes #17554, Fixes #17698, Fixes #18021, Fixes #18055, Fixes #18238, Fixes #19542, Fixes #19668, Fixes #20502, Fixes #20615, Fixes #21562, Fixes #22053, Fixes #23074, Fixes #24752, Fixes #27101, Fixes #27627, Fixes #27770, Fixes #27922, Fixes #28514, Fixes #28676, Fixes #28891, Fixes #29411, Fixes #29449, Fixes #30010, Fixes #30046, Fixes #30404, Fixes #30464, Fixes #30535, Fixes #30957, Fixes #31048, Fixes #31177, Fixes #31472, Fixes #31686, Fixes #32279, Fixes #32393, Fixes #32404, Fixes #32457, Fixes #32476, Fixes #32492, Fixes #32731, Fixes #32871, Fixes #33508, Fixes #33510, Fixes #33780, Fixes #34038, Fixes #34104, Fixes #34257, Fixes #34380, Fixes #34522, Fixes #34558, Fixes #34584, Fixes #34594, Fixes #34823, Fixes #34830, Fixes #34832, Fixes #34899, Fixes #34930, Fixes #34955, Fixes #34971, Fixes #34973, Fixes #34993, Fixes #35060, Fixes #35076, Fixes #35088, Fixes #35103, Fixes #35107, Fixes #35113, Fixes #35114, Fixes #35147, Fixes #35180, Fixes #35183, Fixes #35211, Fixes #35214, Fixes #35244, Fixes #35257, Fixes #35277, Fixes #35279, Fixes #35280, Fixes #35286, Fixes #35293, Fixes #35313, Fixes #35326, Fixes #35331, Fixes #35344, Fixes #35354, Fixes #35371, Fixes #35380, Fixes #35381, Fixes #35387, Fixes #35390, Fixes #35396, Fixes #35397, Fixes #35399, Fixes #35401, Fixes #35405, Fixes #35416, Fixes #35429, Fixes #35469, Fixes #35472, Fixes #35473, Fixes #35479, Fixes #35481, Fixes #35483, Fixes #35485, Fixes #35492, Fixes #35495, Fixes #35497, Fixes #35498, Fixes #35513, Fixes #35517, Fixes #35568, Fixes #35573, Fixes #35574, Fixes #35584, Fixes #35587, Fixes #35615, Fixes #35618, Fixes #35651, Fixes #35654 </details> **Full Changelog**: main...inflight/candidate
Issue details:
A regression was introduced by PR #34521 on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3.
Description of changes:
Fully reverts PR #34521. Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #34322 and their helper methods.
Issues Fixed
Fixes #35584