Repository navigation
docs: Fix hardcoded path and add library overview in Essentials.AI README - #35194
Conversation
- Replace contributor-specific absolute path in the sharpie bind command with a <repo-root> placeholder and an explanatory comment so any developer can follow the instructions without a path-not-found error. - Add an Overview section at the top describing what the library does, supported platforms, how to add the PackageReference, and a pointer to the sample app at src/AI/samples/Essentials.AI.Sample/. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35194Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35194" |
There was a problem hiding this comment.
Pull request overview
Updates the Essentials.AI package README to be more user-friendly by adding an introductory overview and improving the “Generating Files” instructions to avoid machine-specific paths.
Changes:
- Added an Overview section describing the library, supported platforms, how to reference the package, and where to find a sample.
- Updated the “Generating Files” section to use a cleaner fenced
bashcode block and replace the previous machine-specific path prefix.
|
/review |
|
✅ Expert Code Review completed successfully! |
There was a problem hiding this comment.
Expert Code Review — PR #35194
Methodology: 3 independent reviewers with adversarial consensus. Findings are included only when 2+ reviewers independently identified the same root cause.
Summary
The hardcoded path fix (Users/matthew/... → <repo-root>/...) and the bash syntax highlighting are solid improvements. However, the new overview section contains several claims that don't match the current codebase, which could mislead developers.
Findings
| # | Severity | Finding | Consensus | Line(s) |
|---|---|---|---|---|
| 1 | 🟡 MODERATE | Platform table marks Android/Windows as ✅ but no implementations exist for those platforms | 3/3 reviewers | 11–14 |
| 2 | 🟡 MODERATE | Overview claims IChatClient/embedding abstractions work "across all platforms" — only Apple platforms have implementations | 2/3 reviewers | 5 |
| 3 | 🟡 MODERATE | Version="*-*" is unconventional floating version; may confuse consumers or resolve to broken builds |
2/3 reviewers | 19 |
| 4 | 🟢 MINOR | Sample app uses Azure OpenAI (cloud), contradicting the "on-device AI" positioning | 2/3 reviewers | 26 |
| 5 | 🟢 MINOR | EssentialsAI-485fe build-specific hash remains in path, undermining portability goal |
2/3 reviewers | 43 |
| 6 | 🟢 MINOR | Missing trailing newline at end of file | 2/3 reviewers | EOF |
Discarded (single reviewer only): --sdk=iphoneos26.1 becoming stale — 1/3 reviewers, not corroborated.
CI & Test Coverage
This is a documentation-only change (single README.md file), so no CI build or test impact is expected. No tests are needed for this change.
What's Good
- ✅ Removing the hardcoded user-specific path is the right fix
- ✅ Adding
bashsyntax highlighting improves readability - ✅ The overall structure (overview → platforms → install → sample → generating) is well-organized
- ✅ The experimental/preview disclaimer is a good addition
Generated by Expert Code Review for issue #35194 · ● 8.1M
- Clarify Apple-only support; mark Android/Windows as planned - Split macOS and Mac Catalyst into separate rows - Soften 'across all platforms' claim to match shipped providers - Replace Version="*-*" with concrete preview-version example + CPM note - Note that the sample uses cloud (OpenAI) AI, not on-device - Remove <repo-root> placeholder; document that EssentialsAI-XXXXX is build-generated Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Thanks for the reviews! Pushed 2814a9a addressing the actionable feedback: Applied:
No suggestions were skipped. |
…ADME (#35194) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Two improvements to `src/AI/src/Essentials.AI/README.md`: 1. **Remove hardcoded absolute path**: Replace machine-specific path with a relative path that works in any environment 2. **Add library overview**: Add a short description explaining what the Essentials.AI library provides, so readers understand the purpose of the package at a glance --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: kubaflo <kubaflo@users.noreply.github.com>
…ADME (#35194) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Two improvements to `src/AI/src/Essentials.AI/README.md`: 1. **Remove hardcoded absolute path**: Replace machine-specific path with a relative path that works in any environment 2. **Add library overview**: Add a short description explaining what the Essentials.AI library provides, so readers understand the purpose of the package at a glance --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: kubaflo <kubaflo@users.noreply.github.com>
…ADME (#35194) > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ## Summary Two improvements to `src/AI/src/Essentials.AI/README.md`: 1. **Remove hardcoded absolute path**: Replace machine-specific path with a relative path that works in any environment 2. **Add library overview**: Add a short description explaining what the Essentials.AI library provides, so readers understand the purpose of the package at a glance --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: kubaflo <kubaflo@users.noreply.github.com>
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Summary
Two improvements to
src/AI/src/Essentials.AI/README.md: