Skip to content

Comments

Revert "Remove InternalsVisibleTo attributes for .NET MAUI Community …#34047

Merged
PureWeen merged 1 commit intodotnet:mainfrom
dartasen:revert/internalvisibletotoolkit
Feb 15, 2026
Merged

Revert "Remove InternalsVisibleTo attributes for .NET MAUI Community …#34047
PureWeen merged 1 commit intodotnet:mainfrom
dartasen:revert/internalvisibletotoolkit

Conversation

@dartasen
Copy link
Contributor

@dartasen dartasen commented Feb 13, 2026 •
edited
Loading

Description of Change

This reverts commit 8e96657. (from #33442)

Context : #29321

Revert for now because the timing doesn't line up yet. We don't have a version of the Toolkit that uses the public types so with this change, the .NET 10 preview templates (using --sample-content) using the Toolkit will break immediately.

This is still not true as per the time we're discussing this, so there's no good reason to introduce those changes (from #33442) in a service release, as this is a massive breaking change. Making the version unusable for everyone using the toolkit.

Not to mention that 10.0.40 has some important bug fixes related to different crashes, which makes this situation quite annoying

Issues Fixed

Fixes #34035
Fixes #34034
Fixes #34048

Toolkit issues related

CommunityToolkit/Maui#3089
CommunityToolkit/Maui#3092

Copilot AI review requested due to automatic review settings February 13, 2026 17:09
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 13, 2026
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 13, 2026

Hey there @@dartasen! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot AI reviewed Feb 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the earlier removal of InternalsVisibleTo declarations for the .NET MAUI Community Toolkit, restoring toolkit access to MAUI internals to avoid breakages/regressions for toolkit consumers (notably in the .NET 10 preview templates and MAUI 10.0.40 scenarios).

Changes:

  • Restores InternalsVisibleTo entries for CommunityToolkit.Maui* assemblies in Essentials, Core, Controls Core, and Controls Xaml.
  • Re-adds Toolkit-related visibility for CommunityToolkit.Maui.Embedding where it previously existed (Controls assemblies).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/Essentials/src/AssemblyInfo/AssemblyInfo.shared.cs Re-adds Toolkit InternalsVisibleTo declarations for Essentials internals.
src/Core/src/Properties/AssemblyInfo.cs Re-adds Toolkit InternalsVisibleTo declarations for Core internals.
src/Controls/src/Xaml/Properties/AssemblyInfo.cs Re-adds Toolkit InternalsVisibleTo declarations for Controls.Xaml internals (including Embedding).
src/Controls/src/Core/Properties/AssemblyInfo.cs Re-adds Toolkit InternalsVisibleTo declarations for Controls.Core internals (including Embedding).

@dartasen dartasen force-pushed the revert/internalvisibletotoolkit branch from 56883c4 to 1cf2d27 Compare February 13, 2026 18:39
@dartasen dartasen requested a review from Copilot February 13, 2026 18:40
Copilot AI reviewed Feb 13, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@PureWeen
Copy link
Member

PureWeen commented Feb 13, 2026

@dartasen have you validated that these nugets fix you?

@PureWeen PureWeen added this to the .NET 10 SR4.1 milestone Feb 13, 2026
@dartasen
Copy link
Contributor Author

dartasen commented Feb 13, 2026 •
edited
Loading

@PureWeen Installed 10.0.50-ci.pr34047.26113.37 on a local feed, and tested on Community Toolkit sample to confirm that the toolkit can compile again and works with the revert. And also tested on my production app

image

@PureWeen
Copy link
Member

PureWeen commented Feb 13, 2026

/backport to release/10.0.1xx-sr4

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Started backporting to release/10.0.1xx-sr4 (link to workflow run)

@github-actions github-actions bot mentioned this pull request Feb 13, 2026
Merged
Copilot AI added a commit that referenced this pull request Feb 14, 2026
@PureWeen
Improve documentation for ToolkitTests
4f7ab60 
Added comprehensive documentation explaining:
- Purpose: Catch regressions breaking third-party package compatibility
- Pattern: Similar to SampleTests.cs
- Context: Reference to PR #34047
- Ecosystem impact: Ensures MAUI build system remains compatible with community packages

Co-authored-by: PureWeen <5375137+PureWeen@users.noreply.github.com>
Copilot AI mentioned this pull request Feb 14, 2026
Draft
@github-actions github-actions bot mentioned this pull request Feb 14, 2026
Closed
PureWeen pushed a commit that referenced this pull request Feb 14, 2026
@github-actions @dartasen
[release/10.0.1xx-sr4] Revert "Remove InternalsVisibleTo attributes f…
10e274a 
…or .NET MAUI Community … (#34052)

Backport of #34047 to release/10.0.1xx-sr4

/cc @PureWeen @dartasen

Co-authored-by: dartasen <cleeeemove@gmail.com>
@PureWeen
Copy link
Member

PureWeen commented Feb 14, 2026

/azp run maui-pr-uitests, maui-pr-devicetests

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 14, 2026

Azure Pipelines successfully started running 2 pipeline(s).

This was referenced Feb 14, 2026
Open
Open
@PureWeen PureWeen merged commit 2c26b34 into dotnet:main Feb 15, 2026
164 of 172 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in MAUI SDK Ongoing Feb 15, 2026
@github-actions github-actions bot mentioned this pull request Feb 16, 2026
Closed
@jfversluis jfversluis mentioned this pull request Feb 16, 2026
Draft
@github-actions github-actions bot mentioned this pull request Feb 17, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment