ai-summary-comment: Simplify PR finalize to two collapsible sections #33771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
📋 PR Finalization ReviewTitle: ✅ GoodCurrent: Description: ✅ ExcellentThe description is comprehensive and accurately reflects the implementation: ✅ Before/After comparison clearly explains the structural change
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the PR finalization comment system to simplify the format and logic. Previously, the script maintained multiple numbered reviews (Review 1, Review 2, etc.) by merging new reviews with existing content. Now it produces a single comment with two collapsible sections (Title and Description) that always replaces the entire comment on updates.
Changes:
- Removed
ReviewNumberandReviewDescriptionparameters and related aggregation logic - Changed from accumulating multiple review sections to always replacing the entire comment
- Restructured comment format with two top-level collapsible sections (Title and Description) instead of per-review collapsibles
- Updated title status auto-detection to look for explicit "Status:" field in Title Assessment section with fallback to recommended title check
- Increased GitHub API comment fetch limit from default (30) to 100 per page
- Simplified examples and documentation to reflect new parameter set
.github/skills/ai-summary-comment/scripts/post-pr-finalize-comment.ps1
Outdated
Show resolved
Hide resolved
kubaflo
force-pushed
the
pr-finalize-comment-improvements
branch
from
41bcc0a to
71a9485
Compare
kubaflo
changed the title
kubaflo
added
the
area-ai-agents
kubaflo
force-pushed
the
pr-finalize-comment-improvements
branch
from
71a9485 to
1ef5cfd
Compare
kubaflo
changed the title
kubaflo
changed the title
Refactor PR finalize comment format and logic Restructure post-pr-finalize-comment.ps1 to produce a single PR finalize comment composed of two collapsible sections (Title and Description) instead of per-review collapsibles. Remove legacy ReviewNumber and ReviewDescription parameters and associated aggregation logic; TitleStatus is now auto-detected from a dedicated Title Assessment section fallback. Always replace the existing finalize comment (instead of merging/adding reviews) and build separate title/description sections with updated formatting for issues and recommendations. Also update docs/examples, broaden GH API comment fetch to ?per_page=100, and simplify defaulting behavior. Add TitleIssues parameter to post-pr-finalize-comment.ps1 The script was missing a parameter to pass title issues directly when using manual parameters (instead of loading from SummaryFile). This caused errors when trying to specify title issues without a summary file. - Add TitleIssues parameter documentation - Add TitleIssues to param block - Initialize $titleIssues from parameter when not loading from SummaryFile
kubaflo
force-pushed
the
pr-finalize-comment-improvements
branch
from
1ef5cfd to
5ae55f6
Compare
Member
Review FeedbackThe script changes look good and work correctly! I tested with Suggestion: Update SKILL.mdLines 59-62 of
Since this PR changes the behavior to always replace the comment with a single Title + Description structure, consider updating that section to reflect the new behavior, e.g.:
This could be done in this PR or as a follow-up. |
PureWeen
approved these changes
Jan 29, 2026
kubaflo
added a commit
to kubaflo/maui
that referenced
this pull request
Feb 2, 2026
…otnet#33771) <!-- Please let the below note in for people that find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you! ### Description of Change Refactors `post-pr-finalize-comment.ps1` to produce a cleaner, more readable PR finalization comment format: **Before:** Single collapsible section per review with merged Title/Description content **After:** Two separate collapsible sections (Title and Description) for better scannability #### Changes: - Replace per-review collapsible sections with dedicated Title and Description sections - Remove legacy `ReviewNumber` and `ReviewDescription` parameters (no longer needed) - Add `TitleIssues` parameter for direct title issue specification - Auto-detect `TitleStatus` from "Title Assessment" section in summary files - Always replace existing finalize comment instead of merging reviews - Broaden GitHub API comment fetch to `?per_page=100` to handle PRs with many comments - Simplify status defaulting logic ### Issues Fixed N/A - Internal tooling improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Refactors
post-pr-finalize-comment.ps1to produce a cleaner, more readable PR finalization comment format:Before: Single collapsible section per review with merged Title/Description content
After: Two separate collapsible sections (Title and Description) for better scannability
Changes:
ReviewNumberandReviewDescriptionparameters (no longer needed)TitleIssuesparameter for direct title issue specificationTitleStatusfrom "Title Assessment" section in summary files?per_page=100to handle PRs with many commentsIssues Fixed
N/A - Internal tooling improvement