Skip to content

[XSG] Improve diagnostic reporting during binding compilation #32905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 13 commits into from
Jan 14, 2026
Merged

[XSG] Improve diagnostic reporting during binding compilation #32905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
38f07c2
Initial plan
Copilot Nov 28, 2025
f2c9816
Improve diagnostic reporting in binding compilation logic
Copilot Nov 28, 2025
1b3724e
Address code review feedback
Copilot Nov 28, 2025
546374f
Change diagnostic prefix from MAUIX to MAUIG and remove unreachable code
Copilot Nov 28, 2025
314002f
Add missing test scenarios for MAUIG2024 and MAUIG2043 diagnostics
Copilot Nov 28, 2025
d5879df
Change binding diagnostics severity from Error to Warning
simonrozsival Nov 28, 2025
24ff9d3
Revert "Change binding diagnostics severity from Error to Warning"
simonrozsival Nov 28, 2025
70a7d05
Support NoWarn metadata for source generator diagnostics in XAML files
simonrozsival Nov 28, 2025
52eb3d9
Fix indexer bindings and correct MAUIG2045 severity to Error
simonrozsival Jan 8, 2026
5758764
Fix MAUIG2024 diagnostic reporting and correct BindingIndexerTypeUnsu…
simonrozsival Jan 8, 2026
e2428d3
Add MAUIG2045 to NoWarn list for test XAML files with intentional bin…
simonrozsival Jan 8, 2026
e9a6621
Change MAUIG2045 severity from Error to Warning
simonrozsival Jan 8, 2026
6f682dd
Fix alignment
simonrozsival Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/SourceGen/AnalyzerConfigOptionsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public static string GetValueOrDefault(this AnalyzerConfigOptions options, strin

public static T GetValueOrDefault<T>(this AnalyzerConfigOptions options, string key, T defaultValue, Func<string, T> parse)
=> options.TryGetValue(key, out var value) ? parse(value) : defaultValue;

public static string? GetValueOrNull(this AnalyzerConfigOptions options, string key)
=> options.TryGetValue(key, out var value) ? value : null;
}
6 changes: 6 additions & 0 deletions src/Controls/src/SourceGen/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@ MAUIX2003 | XamlInflation | Error | Descriptors
MAUIX2004 | XamlInflation | Error | Descriptors
MAUIX2005 | XamlInflation | Warning | Descriptors
MAUIX2006 | XamlParsing | Warning | PropertyElementWithAttribute
MAUIG2024 | XamlInflation | Warning | BindingWithXDataTypeFromOuterScope
MAUIG2041 | XamlInflation | Error | BindingIndexerNotClosed
MAUIG2042 | XamlInflation | Error | BindingIndexerEmpty
MAUIG2043 | XamlInflation | Error | BindingIndexerTypeUnsupported
MAUIG2045 | XamlInflation | Warning | BindingPropertyNotFound
MAUIG2064 | XamlInflation | Error | NamescopeDuplicate
7 changes: 4 additions & 3 deletions src/Controls/src/SourceGen/CodeBehindCodeWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public static string GenerateXamlCodeBehind(XamlProjectItemForCB? xamlItem, Comp

var generateInflatorSwitch = compilation.AssemblyName == "Microsoft.Maui.Controls.Xaml.UnitTests" && !generateDefaultCtor;
var xamlInflators = projItem.Inflator;

//if there's only the XamlC inflator, prevent non-assigned errors
if (xamlInflators == XamlInflator.XamlC)
sb.AppendLine("#pragma warning disable CS0649");
Expand Down Expand Up @@ -174,7 +174,8 @@ public static string GenerateXamlCodeBehind(XamlProjectItemForCB? xamlItem, Comp
InitComp("InitializeComponent");
else if ((xamlInflators & XamlInflator.XamlC) == XamlInflator.XamlC)
InitComp("InitializeComponent");
else if ((xamlInflators & XamlInflator.SourceGen) == XamlInflator.SourceGen) {
else if ((xamlInflators & XamlInflator.SourceGen) == XamlInflator.SourceGen)
{
InitComp("InitializeComponent", partialsignature: true);
//generate InitCompRuntime for HotReload fallback
if (projItem.EnableDiagnostics)
Expand All @@ -199,7 +200,7 @@ void InitComp(string methodName, bool empty = false, bool partialsignature = fal
if (namedFields != null && namedFields.Any())
{
sb.AppendLine($"#if NET5_0_OR_GREATER");
foreach ((var fname, _, _) in namedFields)
foreach ((var fname, _, _) in namedFields)
sb.AppendLine($"\t\t[global::System.Diagnostics.CodeAnalysis.MemberNotNullAttribute(nameof({EscapeIdentifier(fname)}))]");

sb.AppendLine($"#endif");
Expand Down
15 changes: 10 additions & 5 deletions src/Controls/src/SourceGen/CompilationReferencesComparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,21 +90,26 @@ private static void AppendType(StringBuilder sb, INamedTypeSymbol type)
{
case IFieldSymbol f:
sb.Append(f.DeclaredAccessibility).Append(' ');
if (f.IsStatic) sb.Append("static ");
if (f.IsStatic)
sb.Append("static ");
sb.Append(f.Type.ToFQDisplayString()).Append(' ').Append(f.Name).Append(';');
break;

case IPropertySymbol p:
sb.Append(p.DeclaredAccessibility).Append(' ');
if (p.IsStatic) sb.Append("static ");
if (p.IsStatic)
sb.Append("static ");
sb.Append(p.Type.ToFQDisplayString()).Append(' ').Append(p.Name);
if (p.GetMethod != null) sb.Append("{get;}");
if (p.SetMethod != null) sb.Append("{set;}");
if (p.GetMethod != null)
sb.Append("{get;}");
if (p.SetMethod != null)
sb.Append("{set;}");
break;

case IMethodSymbol m when m.MethodKind == MethodKind.Ordinary:
sb.Append(m.DeclaredAccessibility).Append(' ');
if (m.IsStatic) sb.Append("static ");
if (m.IsStatic)
sb.Append("static ");
sb.Append(m.ReturnType.ToFQDisplayString()).Append(' ').Append(m.Name);
sb.Append('(');
sb.Append(string.Join(",", m.Parameters.Select(p => p.Type.ToFQDisplayString())));
Expand Down
Loading
Loading