Return stub IAlertManagerSubscription for standard AlertManager#32646
Merged
PureWeen merged 1 commit intodotnet:inflight/currentfrom Nov 18, 2025
Conversation
Contributor
|
Hey there @@drasticactions! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in .NET 10 MAUI where the standard AlertManager implementation throws NotImplementedException when CreateSubscription is called. This breaks test scenarios where MAUI controls are used outside the standard MAUI UI TFMs without dependency injection services configured.
Key changes:
- Returns a no-op
AlertRequestHelperstub instead of throwingNotImplementedExceptionin the standard AlertManager - Aligns with .NET 9 behavior where this scenario would silently no-op
- Matches the pattern of platform-specific implementations (Android, iOS, Windows, Tizen) which all return concrete instances
PureWeen
approved these changes
Nov 18, 2025
PureWeen
pushed a commit
that referenced
this pull request
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.NET 10 MAUI introduced a new internal implementation of IAlertManagerSubscription. This includes a standard implementation with a NotImplementedException for CreateSubscription.
maui/src/Controls/src/Core/Platform/AlertManager/AlertManager.Standard.cs
Lines 8 to 11 in 3680b04
This creates a problem if you are using .NET implementations of the controls from outside the standard .NET MAUI UI TFMs (Such as test cases for controls outside of the MAUI repo). Window calls on an internal AlertManager implementation,
maui/src/Controls/src/Core/Window/Window.cs
Lines 696 to 700 in 3680b04
This calls on that standard AlertManager, which then fails with a not implemented exception. in .NET 9 and previous, this would no-op.
Returning the stub AlertManagerHelper fixes this and lets it continue. For 99.999% of users (scientifically speaking), they shouldn't notice a difference in behavior.