[iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden#32622
Merged
PureWeen merged 3 commits intodotnet:inflight/currentfrom Nov 18, 2025
Conversation
… Back to a ContentPage with NavigationBar Hidden
Contributor
|
Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an iOS-specific Shell navigation bar visibility bug where navigating back to a ContentPage with a hidden navigation bar would incorrectly show the navigation bar. The issue was introduced in PR #29279.
Key Changes
- Core Fix: Added a call to
SetNavigationBarHiddenin theWillShowViewControllermethod to apply the calculated navigation bar visibility state during iOS navigation transitions - Test Coverage: Added comprehensive UI tests with screenshot verification for iOS and Android platforms
- Test Implementation: Created test pages demonstrating the issue scenario (main page with hidden nav bar → message page with visible nav bar → back to main page)
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ShellSectionRenderer.cs | Added SetNavigationBarHidden call in WillShowViewController to apply nav bar visibility during transitions with proper animation support |
| Issue32583.cs (HostApp) | Test page implementation with main page (hidden nav bar) and message page (visible nav bar) to reproduce the issue |
| Issue32583.cs (Tests) | UI test that navigates forward and back, then verifies with screenshot that nav bar remains hidden |
| NavigationBarShouldRemainHiddenAfterNavigatingBack.png (iOS) | Baseline screenshot for iOS test verification |
| NavigationBarShouldRemainHiddenAfterNavigatingBack.png (Android) | Baseline screenshot for Android test verification |
PureWeen
approved these changes
Nov 18, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 18, 2025
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
github-actions bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
PureWeen
pushed a commit
that referenced
this pull request
Nov 21, 2025
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
… Back to a ContentPage with NavigationBar Hidden (#32622) * [iOS] Fix for Shell Navigation Bar Remaining Visible After Navigating Back to a ContentPage with NavigationBar Hidden * Added test cases and snapshots for both iOS and Android platforms * Added snapshot for windows platform
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issue Details
Break/Regression Information
Root Cause
Description of Change
Issues Fixed
Fixes #32583
Validated the behaviour in the following platforms
Output
Before.mov
After.mov