Fixed NavigationPage and FlyoutPage both call OnNavigatedTo, so it is called twice #31931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
community ✨
|
/azp run |
jsuarezruiz
added
area-navigation
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Oct 9, 2025
| { | ||
| App.WaitForElement("Go to Third Page"); | ||
| App.Tap("ThirdPageButton"); | ||
| await Task.Delay(300); |
There was a problem hiding this comment.
Include a comment explaining it, waiting to navigation animations to complete.
|
|
||
| internal void SendNavigatedTo(NavigatedToEventArgs args) | ||
| { | ||
| if (HasNavigatedTo) |
There was a problem hiding this comment.
Will this blocks OnNavigatedTo after the first call, even when navigating away and back to the page? (NavigationPage, TabbedPage, FlyoutPage).
|
|
||
| [Test] | ||
| [Category(UITestCategories.Navigation)] | ||
| public async Task Issue23902NavigationTest() |
There was a problem hiding this comment.
Can include more tests?
I would like to verify Re-Navigation cases:
OnNavigatedToCalledAgainOnReNavigation. Navigate to PageA, navigate back, then navigate to PageA again. OnNavigatedTo should be called twice (once per navigation TO the page). Expected: NavigatedTo count = 2OnNavigatedToCalledAgainOnReFlyoutNavigation. Same using a FluyoutPage.
|
|
||
| internal void SendNavigatedTo(NavigatedToEventArgs args) | ||
| { | ||
| if (HasNavigatedTo) |
There was a problem hiding this comment.
Will this blocks OnNavigatedTo after the first call, even when navigating away and back to the page? (NavigationPage, TabbedPage, FlyoutPage).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details:
On Android, the OnNavigatedTo method of the content page is being called twice when Detail page of FlyoutPage is navigation page.
Root Cause:
The duplicate invocation occurs due to two separate triggers:
i) Setting the Detail property of the FlyoutPage explicitly calls OnNavigatedTo.
ii) The OnHandlerChangedCore method also triggers OnNavigatedTo. This method is invoked from the overridden OnFragmentResumed in StackNavigationManager, which is itself called from the native Android framework during the fragment lifecycle.
As a result, both the framework-level and platform-level calls cause OnNavigatedTo to execute, leading to the observed duplication.
Description of Change:
To prevent duplicate calls, the OnNavigatedTo method is not invoked again if the same page has already been navigated to. This check is handled within the SendNavigatedTo method of the Page class.
Tested the behavior in the following platforms.
Reference:
N/A
Issues Fixed:
Fixes #23902
Screenshots
Screen.Recording.2025-10-09.at.11.25.36.AM.mov
Screen.Recording.2025-10-09.at.11.22.43.AM.mov