[iOS, Catalyst] Fixed CollectionView items height appears larger in Developer Balance sample #31902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @@karthikraja-arumugam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a layout issue in CollectionView where cards appeared larger than expected on iOS and Mac platforms. The issue was caused by incorrect sizing behavior when content size wasn't initially available.
Key changes:
- Modified the sizing logic to consider CollectionView orientation when determining content size
- Added scroll direction awareness to prevent incorrect sizing in horizontal layouts
- Included comprehensive UI tests to validate the fix
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Controls/src/Core/Handlers/Items2/ItemsViewHandler2.iOS.cs |
Updated GetDesiredSize method to handle orientation-aware sizing logic |
src/Controls/src/Core/Handlers/Items2/iOS/ItemsViewController2.cs |
Added GetScrollDirection method to expose CollectionView orientation |
src/Controls/tests/TestCases.HostApp/Issues/Issue31897.cs |
Created UI test page with horizontal CollectionView to reproduce the issue |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue31897.cs |
Added automated test to verify CollectionView height behavior |
karthikraja-arumugam
changed the title
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
sheiksyedm
added
the
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Details
In the Developer Balance sample, the CollectionView items appear larger than expected on iOS and Mac. Additional vertical space is observed within the cards.
Root Cause
Breaking PR: #30978
In that PR, when the content size isn’t set, the desired size of the CollectionView is used. This causes the issue when a horizontal CollectionView stretches to full size without resizing to its actual height.
Description of change
Instead of returning the desired size from the base, the content size is now updated based on the CollectionView orientation, ensuring proper size constraints are applied
Validated the behaviour in the following platforms
Issues Fixed
Fixes #31897
Screenshots