Skip to content

Clean up Extensions.cs by removing TODO comments #31901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

Clean up Extensions.cs by removing TODO comments #31901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/Templates/src/templates/maui-aspire-servicedefaults/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,6 @@ private static TBuilder AddOpenTelemetryExporters<TBuilder>(this TBuilder builde
builder.Services.AddOpenTelemetry().UseOtlpExporter();
}

// TODO MAUI: this code comes from the Aspire service defaults, we will want to check if this works for us and if yes
// how integration works for us because the AspNetCore package cannot be added to a MAUI project and we can't read the connection string like this
// Uncomment the following lines to enable the Azure Monitor exporter (requires the Azure.Monitor.OpenTelemetry.AspNetCore package)
//if (!string.IsNullOrEmpty(builder.Configuration["APPLICATIONINSIGHTS_CONNECTION_STRING"]))
//{
// builder.Services.AddOpenTelemetry()
// .UseAzureMonitor();
//}

return builder;
}
}
Loading