[X] avoid enumerating 3 times #31622
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the XAML type lookup performance by eliminating redundant enumeration operations. The change addresses issue #31172 by reducing multiple iterations over the same collection to a single enumeration with materialization.
- Materializes the type collection early by calling
.Distinct().ToList()instead of repeatedly enumerating - Replaces LINQ operations (
Any(),Skip(1).Any(),FirstOrDefault()) with direct list operations for better performance - Maintains the same logical behavior while reducing computational overhead
StephaneDelcroix
force-pushed
the
dev/stdelc/fix31172
branch
from
a3d9efd to
3c68f70
Compare
mattleibow
approved these changes
Sep 15, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
StephaneDelcroix
force-pushed
the
dev/stdelc/fix31172
branch
from
3c68f70 to
6ff94fe
Compare
PureWeen
approved these changes
Sep 16, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed