Use ToLowerInvariant().Contains(...) for .NET Framework - #31353
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an MSBuild error by replacing deprecated StringComparison enum usage in MSBuild target files with a more compatible string comparison approach. The change ensures the XAML inflator type checking works correctly across different MSBuild versions.
- Replaces
StringComparison.OrdinalIgnoreCasewithToLowerInvariant().Contains()for case-insensitive string matching - Updates three conditional statements that categorize MauiXaml items by inflator type
- Maintains the same logical behavior while using MSBuild-compatible string operations
Member
|
@StephaneDelcroix / @mattleibow can you backport this to this branch as well please? release/10.0.1xx-rc1 |
Member
|
/backport to release/10.0.1xx-rc1 |
Contributor
|
Started backporting to release/10.0.1xx-rc1: https://github.com/dotnet/maui/actions/runs/17241840407 |
mattleibow
approved these changes
Aug 26, 2025
dalexsoto
approved these changes
Aug 26, 2025
mattleibow
changed the title
ToLowerInvariant().Contains(...) for .NET Framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Replaces
Contains(..., StringComparison.OrdinalIgnoreCase)withToLowerInvariant().Contains(...)for case-insensitive string matching because .NET Standard 2.0 and/or .NET Framework 4.x does not have the nice new overloads.