[Net10] [iOS] ScrollView content offset RTL - fix #30723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request is part of a systematic effort to suppress CS0618 obsolete warnings throughout the .NET MAUI Controls codebase, specifically focusing on ListView and TableView related components. The changes primarily add #pragma warning disable/restore CS0618 directives around code that uses obsolete ListView, TableView, and Cell APIs.
Key Changes:
- Addition of
#pragma warning disable/restore CS0618pragmas around obsolete ListView, TableView, and Cell API usage - Addition of obsolete attributes to Cell-related classes (ViewCell, TextCell, SwitchCell, ImageCell, EntryCell)
- Suppression of obsolete warnings in compatibility handlers for ListView on iOS, Windows, and Android platforms
Reviewed Changes
Copilot reviewed 287 out of 1252 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/ | Multiple iOS ListView handler files with CS0618 pragma suppressions around obsolete Cell and ListView API usage |
| src/Controls/src/Core/Compatibility/Handlers/ListView/Windows/ | Windows ListView handler files with CS0618 pragma suppressions |
| src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ | Android ListView handler files with CS0618 pragma suppressions |
| src/Controls/src/Core/Cells/ | Cell classes marked with Obsolete attributes |
| Various other files | Miscellaneous changes including pragma suppressions, typo fixes, and minor updates |
|
|
||
| #pragma warning disable CA1416, CA1422 // TODO: 'UITableViewCell.TextLabel', DetailTextLabel is unsupported on: 'ios' 14.0 and later | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| #pragma warning disable CS0618 // Type or member is obsolete |
There was a problem hiding this comment.
[nitpick] Multiple consecutive #pragma warning disable directives for the same warning (CS0618) could be consolidated into a single directive that spans the entire method or class section.
Comment on lines
102
to
108
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| if (_previousFrame != Frame) | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| _previousFrame = Frame; | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| } |
There was a problem hiding this comment.
[nitpick] Nested pragma warning directives make the code harder to read. Consider using a single pragma warning disable at the method level instead of multiple nested ones.
Suggested change
| #pragma warning disable CS0618 // Type or member is obsolete | |
| if (_previousFrame != Frame) | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| _previousFrame = Frame; | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| } | |
| if (_previousFrame != Frame) | |
| #pragma warning restore CS0618 // Type or member is obsolete |
Comment on lines
70
to
102
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| var realCell = (EntryCellTableViewCell)GetRealCell(entryCell); | ||
|
|
||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| if (e.PropertyName == EntryCell.LabelProperty.PropertyName) | ||
| UpdateLabel(realCell, entryCell); | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| else if (e.PropertyName == EntryCell.TextProperty.PropertyName) | ||
| UpdateText(realCell, entryCell); | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| else if (e.PropertyName == EntryCell.PlaceholderProperty.PropertyName) | ||
| UpdatePlaceholder(realCell, entryCell); | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| else if (e.PropertyName == EntryCell.KeyboardProperty.PropertyName) | ||
| UpdateKeyboard(realCell, entryCell); | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| else if (e.PropertyName == EntryCell.LabelColorProperty.PropertyName) | ||
| UpdateLabelColor(realCell, entryCell); | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| else if (e.PropertyName == EntryCell.HorizontalTextAlignmentProperty.PropertyName) | ||
| UpdateHorizontalTextAlignment(realCell, entryCell); | ||
| else if (e.PropertyName == Cell.IsEnabledProperty.PropertyName) | ||
| UpdateIsEnabled(realCell, entryCell); | ||
| else if (e.PropertyName == VisualElement.FlowDirectionProperty.PropertyName) | ||
| UpdateHorizontalTextAlignment(realCell, entryCell); | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| #pragma warning restore CS0618 // Type or member is obsolete |
There was a problem hiding this comment.
[nitpick] Multiple consecutive restore directives should match the corresponding disable directives. The pattern of multiple nested pragma directives creates maintenance burden and reduces readability.
Suggested change
| #pragma warning restore CS0618 // Type or member is obsolete | |
| var realCell = (EntryCellTableViewCell)GetRealCell(entryCell); | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| if (e.PropertyName == EntryCell.LabelProperty.PropertyName) | |
| UpdateLabel(realCell, entryCell); | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.TextProperty.PropertyName) | |
| UpdateText(realCell, entryCell); | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.PlaceholderProperty.PropertyName) | |
| UpdatePlaceholder(realCell, entryCell); | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.KeyboardProperty.PropertyName) | |
| UpdateKeyboard(realCell, entryCell); | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.LabelColorProperty.PropertyName) | |
| UpdateLabelColor(realCell, entryCell); | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.HorizontalTextAlignmentProperty.PropertyName) | |
| UpdateHorizontalTextAlignment(realCell, entryCell); | |
| else if (e.PropertyName == Cell.IsEnabledProperty.PropertyName) | |
| UpdateIsEnabled(realCell, entryCell); | |
| else if (e.PropertyName == VisualElement.FlowDirectionProperty.PropertyName) | |
| UpdateHorizontalTextAlignment(realCell, entryCell); | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| var realCell = (EntryCellTableViewCell)GetRealCell(entryCell); | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| if (e.PropertyName == EntryCell.LabelProperty.PropertyName) | |
| UpdateLabel(realCell, entryCell); | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.TextProperty.PropertyName) | |
| UpdateText(realCell, entryCell); | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.PlaceholderProperty.PropertyName) | |
| UpdatePlaceholder(realCell, entryCell); | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.LabelColorProperty.PropertyName) | |
| UpdateLabelColor(realCell, entryCell); | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| #pragma warning disable CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == EntryCell.HorizontalTextAlignmentProperty.PropertyName) | |
| UpdateHorizontalTextAlignment(realCell, entryCell); | |
| #pragma warning restore CS0618 // Type or member is obsolete | |
| else if (e.PropertyName == Cell.IsEnabledProperty.PropertyName) | |
| UpdateIsEnabled(realCell, entryCell); | |
| else if (e.PropertyName == VisualElement.FlowDirectionProperty.PropertyName) | |
| UpdateHorizontalTextAlignment(realCell, entryCell); |
Contributor
Author
|
Closed in favour of #30724 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This PR #30453 regressed the fix introduced here #29469. The regression hasn't been caught by a flaky UI test, so I've improved it