[Android] Editor and Entry don't update placeholder and text color on theme change - fix #30603
+111
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Editor and Entry controls on Android don't update their placeholder and text colors when the system theme changes between light and dark modes. The fix implements theme-aware color fallbacks and ensures proper event handling for theme changes.
Key changes:
- Enhanced EditText extension methods to fall back to system theme colors when no explicit color is set
- Added theme change event handling in InputView to trigger property updates
- Fixed event timing in Application class for proper theme change propagation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Core/src/Platform/Android/EditTextExtensions.cs |
Enhanced color update methods to use system theme colors as fallback and fixed layout direction reference |
src/Controls/src/Core/InputView/InputView.cs |
Added theme change event subscription to trigger color property updates |
src/Controls/src/Core/Application/Application.cs |
Reordered property change notification timing for theme changes |
Comments suppressed due to low confidence (1)
|
Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/android
area-controls-entry
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
requested changes
Jul 14, 2025
| { | ||
| App.WaitForElement("changeThemeButton"); | ||
| App.Tap("changeThemeButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Could be also interesting to modify the test to set the system theme.
Can do it using
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-30602
branch
from
ce1738b to
9e5c8a7
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Aug 25, 2025
PureWeen
pushed a commit
that referenced
this pull request
Sep 5, 2025
… theme change (#30603) Added a UI Test CR changes Added snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #30602
Screen.Recording.2025-07-14.at.00.52.51.mov
Screen.Recording.2025-07-14.at.00.50.47.mov