[Android] SearchBar does not update colors on theme change - fix #30601

kubaflo · 2025-07-13T18:08:30Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issues Fixed

Fixes #30600
Fixes #25153

Before	After
Screen.Recording.2025-07-13.at.19.44.33.mov	Screen.Recording.2025-07-13.at.19.36.48.mov

dotnet-policy-service · 2025-07-13T18:08:54Z

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot

Pull Request Overview

This PR ensures that the Android SearchBar’s placeholder, text, and cancel‐button colors correctly update when the app’s theme changes.

Update SearchViewExtensions to pull hint/text colors from the current Android theme.
Hook into Application.RequestedThemeChanged in SearchBar to reapply color properties.
Extend the Android handler mapping to call the new text‐color update logic.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/Core/src/Platform/Android/SearchViewExtensions.cs	Read hint/text colors from theme and apply on placeholder, text, and cancel button
src/Core/src/Handlers/SearchBar/SearchBarHandler.Android.cs	Invoke `UpdateTextColor` on the platform view as well as the query editor
src/Controls/src/Core/SearchBar/SearchBar.cs	Subscribe/unsubscribe to theme‐change events and trigger property updates
src/Controls/src/Core/Application/Application.cs	Move `UserAppTheme` property‐changed notification before raising the `RequestedThemeChanged` event

Comments suppressed due to low confidence (1)

src/Controls/src/Core/SearchBar/SearchBar.cs:134

There are no automated UI tests covering the dynamic theme‐change behavior for Android SearchBar. Please add a HostApp UI page and corresponding NUnit tests in TestCases.Shared.Tests to validate that placeholder, text, and cancel‐button colors update correctly.

		private void OnRequestedThemeChanged(object sender, AppThemeChangedEventArgs e)

Copilot · 2025-07-13T18:09:32Z

src/Core/src/Platform/Android/SearchViewExtensions.cs

+					editText.Resources?.GetColor(typedValue.ResourceId, theme) is Color textColorHint)
 				{


The pattern matching GetColor(...) is Color textColorHint will never match because GetColor returns an int, not an Android.Graphics.Color. You should capture the returned int and construct a Color (e.g., new Color(resources.GetColor(...))) before applying it.

Suggested change

editText.Resources?.GetColor(typedValue.ResourceId, theme) is Color textColorHint)

{

editText.Resources?.GetColor(typedValue.ResourceId, theme) is int colorInt)

{

var textColorHint = new Color(colorInt);

Copilot · 2025-07-13T18:09:33Z

src/Core/src/Platform/Android/SearchViewExtensions.cs

+				editText.Resources?.GetColor(typedValue.ResourceId, theme) is Color color)
+			{


Same issue here: GetColor returns an int, so the is Color color check will fail. Use the returned int to create an Android.Graphics.Color instance before calling SetTextColor.

Suggested change

editText.Resources?.GetColor(typedValue.ResourceId, theme) is Color color)

{

editText.Resources?.GetColor(typedValue.ResourceId, theme) is int colorInt)

{

var color = Color.ValueOf(colorInt);

Copilot · 2025-07-13T18:09:33Z

src/Core/src/Platform/Android/SearchViewExtensions.cs

+							theme.ResolveAttribute(Android.Resource.Attribute.TextColorPrimary, typedValue, true) &&
+							image.Resources?.GetColor(typedValue.ResourceId, theme) is Color imageColor)
+						{


The expression GetColor(...) is Color imageColor will never succeed since GetColor returns an int. Construct an Android.Graphics.Color from the int result to apply the tint correctly.

Suggested change

theme.ResolveAttribute(Android.Resource.Attribute.TextColorPrimary, typedValue, true) &&

image.Resources?.GetColor(typedValue.ResourceId, theme) is Color imageColor)

{

theme.ResolveAttribute(Android.Resource.Attribute.TextColorPrimary, typedValue, true))

{

var colorInt = image.Resources?.GetColor(typedValue.ResourceId, theme) ?? 0;

var imageColor = Color.ValueOf(colorInt);

jsuarezruiz · 2025-07-14T06:03:24Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-07-14T06:03:37Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-07-14T06:07:03Z

src/Controls/src/Core/SearchBar/SearchBar.cs

+			if (Application.Current == null)
+				return;
+
+			if (args.NewHandler == null)


You're only unsubscribing when NewHandler is null, but you should unsubscribe whenever there's an OldHandler.

jsuarezruiz · 2025-07-14T06:07:23Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue30601.cs

+	{
+		App.WaitForElement("changeThemeButton");
+		App.Tap("changeThemeButton");
+		VerifyScreenshot();


Pending snapshots, running a build.

SearchBar does not update colors on theme change - fix

fc4c334

Copilot AI review requested due to automatic review settings July 13, 2025 18:08

kubaflo requested a review from a team as a code owner July 13, 2025 18:08

kubaflo requested review from jfversluis and jsuarezruiz July 13, 2025 18:08

kubaflo self-assigned this Jul 13, 2025

dotnet-policy-service bot added the community ✨ Community Contribution label Jul 13, 2025

kubaflo added platform/android area-controls-searchbar SearchBar control community ✨ Community Contribution and removed community ✨ Community Contribution labels Jul 13, 2025

Copilot AI reviewed Jul 13, 2025

View reviewed changes

Added a UI Test

b6b0c32

jsuarezruiz requested changes Jul 14, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Android] SearchBar does not update colors on theme change - fix #30601

[Android] SearchBar does not update colors on theme change - fix #30601

Uh oh!

kubaflo commented Jul 13, 2025

Uh oh!

dotnet-policy-service bot commented Jul 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 13, 2025

Uh oh!

Copilot AI Jul 13, 2025

Uh oh!

Copilot AI Jul 13, 2025

Uh oh!

jsuarezruiz commented Jul 14, 2025

Uh oh!

azure-pipelines bot commented Jul 14, 2025

Uh oh!

jsuarezruiz Jul 14, 2025

Uh oh!

jsuarezruiz Jul 14, 2025

Uh oh!

Uh oh!

		editText.Resources?.GetColor(typedValue.ResourceId, theme) is Color textColorHint)
		{

-					editText.Resources?.GetColor(typedValue.ResourceId, theme) is Color textColorHint)
-				{
+					editText.Resources?.GetColor(typedValue.ResourceId, theme) is int colorInt)
+				{
+					var textColorHint = new Color(colorInt);

-							theme.ResolveAttribute(Android.Resource.Attribute.TextColorPrimary, typedValue, true) &&
-							image.Resources?.GetColor(typedValue.ResourceId, theme) is Color imageColor)
-						{
+							theme.ResolveAttribute(Android.Resource.Attribute.TextColorPrimary, typedValue, true))
+						{
+							var colorInt = image.Resources?.GetColor(typedValue.ResourceId, theme) ?? 0;
+							var imageColor = Color.ValueOf(colorInt);

[Android] SearchBar does not update colors on theme change - fix #30601

Are you sure you want to change the base?

[Android] SearchBar does not update colors on theme change - fix #30601

Uh oh!

Conversation

kubaflo commented Jul 13, 2025

Issues Fixed

Uh oh!

dotnet-policy-service bot commented Jul 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jul 14, 2025

Uh oh!

azure-pipelines bot commented Jul 14, 2025

Uh oh!

jsuarezruiz Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!