Skip to content

Revert "Fix up relevant CA1416 warnings - Set 3 (#26751)" #30421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Jul 7, 2025
Merged

Revert "Fix up relevant CA1416 warnings - Set 3 (#26751)" #30421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed src/Controls/tests/TestCases.Android.Tests/snapshots/android/VerifyFontImage.png
View file
Open in desktop
Binary file not shown.
27 changes: 0 additions & 27 deletions src/Controls/tests/TestCases.HostApp/Issues/FontImageUITest.cs
View file
Open in desktop

This file was deleted.

Binary file removed src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyFontImage.png
View file
Open in desktop
Binary file not shown.
23 changes: 0 additions & 23 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/FontImageUITest.cs
View file
Open in desktop

This file was deleted.

Binary file removed src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyFontImage.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/VerifyFontImage.png
View file
Open in desktop
Binary file not shown.
22 changes: 9 additions & 13 deletions src/Graphics/src/Graphics/Platforms/iOS/UIImageExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,17 @@ public static UIImage ScaleImage(this UIImage target, float maxWidth, float maxH

public static UIImage ScaleImage(this UIImage target, CGSize size, bool disposeOriginal = false)
{
using (var renderer = new UIGraphicsImageRenderer(size))
{
var resultImage = renderer.CreateImage((UIGraphicsImageRendererContext imageContext) =>
{
var cgcontext = imageContext.CGContext;
cgcontext.DrawImage(new CGRect(CGPoint.Empty, size), target.CGImage);

if (disposeOriginal)
{
target.Dispose();
}
});
UIGraphics.BeginImageContext(size);
Copy link

Copilot AI Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using UIGraphics.BeginImageContext without specifying options may produce images at the wrong scale (non-retina) and is less efficient. Consider using UIGraphicsBeginImageContextWithOptions(size, opaque: false, scale: UIScreen.MainScreen.Scale) or reinstating UIGraphicsImageRenderer to ensure correct scaling and performance.

Suggested change
UIGraphics.BeginImageContext(size);
UIGraphics.BeginImageContextWithOptions(size, false, UIScreen.MainScreen.Scale);

Copilot uses AI. Check for mistakes.
target.Draw(new CGRect(CGPoint.Empty, size));
var image = UIGraphics.GetImageFromCurrentImageContext();
UIGraphics.EndImageContext();

return resultImage;
if (disposeOriginal)
{
target.Dispose();
}

return image;
}

public static UIImage NormalizeOrientation(this UIImage target, bool disposeOriginal = false)
Expand Down
Loading