[Android] Fixed the Label Width related issues #29620

Ahamed-Ali · 2025-05-22T15:53:06Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause of the issue

When using the label inside the collectionview , on orientation change of device cause the Layout.Width not properly measured, due to the small width , clipping issue occurred.

Description of Change

Instead of relying on the Layout property , we can use the StaticLayout from the TextLayoutUtils Extensions and working fine properly

Issues Fixed

Fixes #29542
Fixes #29727
Fixes #28928

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Screenshot

Before Issue Fix	After Issue Fix
CollectionViewLabelIssue.mov	CollectionViewLabelFix.mov
BlankSpaceIssue.mov	BlankSpaceIssuefixed.mov

dotnet-policy-service · 2025-05-22T15:53:28Z

Hey there @@Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-05-22T16:47:54Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-22T16:48:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR fixes label clipping issues on Android when rotating devices by switching to a static layout measurement and adds automated UI tests to verify correct sizing in a CollectionView scenario.

Replaces reliance on Layout with TextLayoutUtils.CreateLayout in MauiTextView.OnMeasure
Introduces a UI test (Issue29542) to ensure labels size properly after orientation changes
Adds a HostApp reproduction page for the issue with a CollectionView and test automation IDs

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

File	Description
src/Core/src/Platform/Android/MauiTextView.cs	Use `StaticLayout` from `TextLayoutUtils` for width measurement instead of the native `Layout` logic
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29542.cs	Added a UI test that rotates the emulator and verifies label sizing in a `CollectionView`
src/Controls/tests/TestCases.HostApp/Issues/Issue29542.cs	Provided a sample page with a `CollectionView` and navigation button to reproduce the clipping bug

Comments suppressed due to low confidence (1)

src/Core/src/Platform/Android/MauiTextView.cs:28

[nitpick] The local variable layout shadows the Layout property from the base class; consider renaming it to something more descriptive like staticLayout to avoid confusion.

var layout = TextLayoutUtils.CreateLayout(Text, Paint, availableWidth - totalPadding, Android.Text.Layout.Alignment.AlignNormal);

Copilot · 2025-05-23T11:42:53Z

src/Core/src/Platform/Android/MauiTextView.cs

 		protected override void OnMeasure(int widthMeasureSpec, int heightMeasureSpec)
 		{
-			if (MeasureSpec.GetMode(widthMeasureSpec) == MeasureSpecMode.AtMost && Layout is not null)
+			if (MeasureSpec.GetMode(widthMeasureSpec) == MeasureSpecMode.AtMost && !string.IsNullOrEmpty(Text))
 			{
-				// Ensure the Layout is valid and measured before reading LineCount or GetLineWidth(i) to avoid unnecessary calculations.
-				if (Layout.Width > 0)
-				{
-					// Calculate the total width needed based on text content plus padding
-					int contentWidth = (int)Math.Ceiling(GetMaxLineWidth(Layout));
-					int totalPadding = CompoundPaddingLeft + CompoundPaddingRight;
-					int requiredWidth = contentWidth + totalPadding;
-
-					// Constrain to maximum available width from original spec
-					int availableWidth = MeasureSpec.GetSize(widthMeasureSpec);
-					int desiredWidth = Math.Min(requiredWidth, availableWidth);
-					widthMeasureSpec = MeasureSpec.MakeMeasureSpec(desiredWidth, MeasureSpecMode.AtMost);
-				}
+				int availableWidth = MeasureSpec.GetSize(widthMeasureSpec);
+				int totalPadding = CompoundPaddingLeft + CompoundPaddingRight;
+				var layout = TextLayoutUtils.CreateLayout(Text, Paint, availableWidth - totalPadding, Android.Text.Layout.Alignment.AlignNormal);
+				int contentWidth = (int)Math.Ceiling(GetMaxLineWidth(layout));


Creating a new StaticLayout on every measure may be expensive; consider caching the layout when the text or width changes to avoid redundant allocations.

Instead of creating a new layout every time OnMeasure is called, caching the layout if the text and width haven’t changed might improve performance

I have created a new layout only when necessary to improve performance. @jsuarezruiz

Copilot · 2025-05-23T11:42:54Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29542.cs

@@ -0,0 +1,25 @@
+#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.


The preprocessor directive uses && which means the test will only compile when both macros are defined; likely you intended || so it’s excluded on either platform where it fails.

Suggested change

#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.

#if TEST_FAILS_ON_CATALYST || TEST_FAILS_ON_WINDOWS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.

jsuarezruiz · 2025-05-26T07:19:25Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-26T07:19:41Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-27T07:44:40Z

src/Core/src/Platform/Android/MauiTextView.cs

 		protected override void OnMeasure(int widthMeasureSpec, int heightMeasureSpec)
 		{
-			if (MeasureSpec.GetMode(widthMeasureSpec) == MeasureSpecMode.AtMost && Layout is not null)
+			if (MeasureSpec.GetMode(widthMeasureSpec) == MeasureSpecMode.AtMost && !string.IsNullOrEmpty(Text))


You check !string.IsNullOrEmpty(Text), but if Text is empty later, will the component resize correctly?

I have verified this by dynamically setting the text to an empty string (string.Empty); it resizes correctly, just as it did before the fix.

jsuarezruiz · 2025-05-27T07:45:03Z

src/Core/src/Platform/Android/MauiTextView.cs

 		protected override void OnMeasure(int widthMeasureSpec, int heightMeasureSpec)
 		{
-			if (MeasureSpec.GetMode(widthMeasureSpec) == MeasureSpecMode.AtMost && Layout is not null)
+			if (MeasureSpec.GetMode(widthMeasureSpec) == MeasureSpecMode.AtMost && !string.IsNullOrEmpty(Text))
 			{
-				// Ensure the Layout is valid and measured before reading LineCount or GetLineWidth(i) to avoid unnecessary calculations.
-				if (Layout.Width > 0)
-				{
-					// Calculate the total width needed based on text content plus padding
-					int contentWidth = (int)Math.Ceiling(GetMaxLineWidth(Layout));
-					int totalPadding = CompoundPaddingLeft + CompoundPaddingRight;
-					int requiredWidth = contentWidth + totalPadding;
-
-					// Constrain to maximum available width from original spec
-					int availableWidth = MeasureSpec.GetSize(widthMeasureSpec);
-					int desiredWidth = Math.Min(requiredWidth, availableWidth);
-					widthMeasureSpec = MeasureSpec.MakeMeasureSpec(desiredWidth, MeasureSpecMode.AtMost);
-				}
+				int availableWidth = MeasureSpec.GetSize(widthMeasureSpec);
+				int totalPadding = CompoundPaddingLeft + CompoundPaddingRight;
+				var layout = TextLayoutUtils.CreateLayout(Text, Paint, availableWidth - totalPadding, Android.Text.Layout.Alignment.AlignNormal);
+				int contentWidth = (int)Math.Ceiling(GetMaxLineWidth(layout));


Instead of creating a new layout every time OnMeasure is called, caching the layout if the text and width haven’t changed might improve performance

jsuarezruiz · 2025-05-27T07:45:42Z

src/Core/src/Platform/Android/MauiTextView.cs

+				// Calculate the required width based on the content and padding
+				int requiredWidth = contentWidth + totalPadding;
+				int desiredWidth = Math.Min(requiredWidth, availableWidth);
+				widthMeasureSpec = MeasureSpec.MakeMeasureSpec(desiredWidth, MeasureSpecMode.AtMost);


Assumes that desiredWidth is always valid. If padding is larger than available width, does this result in unexpected behavior?

I tested with a higher padding value, and it behaves the same as before the fix.
However, I have restricted the creation of a new layout if the padding exceeds the available width, as base.Measure can handle this scenario. @jsuarezruiz

jsuarezruiz · 2025-05-29T09:20:56Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-29T09:21:08Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz

Is similar to 294542 but, could you include another test using the sample case from #29727?

Ahamed-Ali · 2025-06-02T05:33:18Z

Is similar to 294542 but, could you include another test using the sample case from #29727?

Yes, I have added another test using the sample case from issue #29727. @jsuarezruiz

jsuarezruiz · 2025-06-02T06:57:27Z

/azp run

azure-pipelines · 2025-06-02T06:57:46Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-06-04T07:54:40Z

/azp run

azure-pipelines · 2025-06-04T07:55:01Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen

LabelShouldSizeProperlyOnCollectionViewWithoutBlankSpace is failing

Ahamed-Ali · 2025-06-05T05:23:39Z

LabelShouldSizeProperlyOnCollectionViewWithoutBlankSpace is failing

I modified the test case to resolve the test failure. @PureWeen

PureWeen · 2025-06-06T16:47:04Z

/azp run

azure-pipelines · 2025-06-06T16:47:23Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen

I'm a bit curious about the build up of changes from OnMeasure that started here

#28215

If I run all the tests from this PR and 28215 and I completely revert all the changes added into OnMeasure everything seems to work fine.

There's a slight adjustment of text size but the issue articulated here #27614 doesn't reproduce

Here's the diff when I revert this PR and 28215 against the tests added in 28215

Also here's the test added to this PR with all changes reverted

I'm not sure I'm seeing a use case yet for why we keep adding code into OnMeasure ?

PureWeen · 2025-06-18T19:19:05Z

Closing in favor of
#30023

Ahamed-Ali added 4 commits May 21, 2025 15:17

Fixed the label width related issues

99ddaad

Committed the Test sample and test case for the fix

9c16661

Changed the fix based on StaticLayout

5910a19

Using the utils method

b08d565

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 22, 2025

jsuarezruiz added the area-controls-label Label, Span label May 22, 2025

Resave image from CI

68ab77a

Ahamed-Ali marked this pull request as ready for review May 23, 2025 11:40

Copilot AI review requested due to automatic review settings May 23, 2025 11:40

Ahamed-Ali requested a review from a team as a code owner May 23, 2025 11:40

Ahamed-Ali requested review from StephaneDelcroix and tj-devel709 May 23, 2025 11:40

sheiksyedm added the platform/android label May 23, 2025

Copilot AI reviewed May 23, 2025

View reviewed changes

mattleibow added platform/android and removed platform/android labels May 23, 2025

sheiksyedm mentioned this pull request May 25, 2025

[REGRESSION, 9.0.60 Android] Many labels are of wrong size #28928

Closed

jsuarezruiz suggested changes May 27, 2025

View reviewed changes

Optimize the fix to improve performace

c988924

prakashKannanSf3972 mentioned this pull request May 29, 2025

I1 - Vertical list for Item Height- After rotating the Android emulator, some text boxes have extra blank space #29727

Closed

jsuarezruiz suggested changes May 30, 2025

View reviewed changes

Added the related test and snapshots

4d89377

Added Teardown method to avoid flakey test

3c44f2e

PureWeen added this to MAUI SDK Ongoing Jun 2, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Jun 2, 2025

PureWeen added this to the .NET 9 SR8 milestone Jun 2, 2025

PureWeen added the p/0 Current heighest priority issues that we are targeting for a release. label Jun 2, 2025

PureWeen moved this from Todo to Ready To Review in MAUI SDK Ongoing Jun 2, 2025

PureWeen requested changes Jun 4, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Jun 4, 2025

Modified the test case to resolve the failures

ba78473

PureWeen modified the milestones: .NET 9 SR8, .NET 9 SR9 Jun 10, 2025

PureWeen requested changes Jun 13, 2025

View reviewed changes

PureWeen closed this Jun 18, 2025

github-project-automation bot moved this from Changes Requested to Done in MAUI SDK Ongoing Jun 18, 2025

github-actions bot locked and limited conversation to collaborators Jul 19, 2025

		@@ -0,0 +1,25 @@
		#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.

	#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.
	#if TEST_FAILS_ON_CATALYST \|\| TEST_FAILS_ON_WINDOWS //The test fails on Windows and MacCatalyst because the SetOrientation method, which is intended to change the device orientation, is only supported on mobile platforms iOS and Android.

[Android] Fixed the Label Width related issues #29620

[Android] Fixed the Label Width related issues #29620

Uh oh!

Conversation

Ahamed-Ali commented May 22, 2025 • edited by PureWeen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause of the issue

Description of Change

Issues Fixed

Tested the behaviour in the following platforms

Screenshot

Uh oh!

dotnet-policy-service bot commented May 22, 2025

Uh oh!

jsuarezruiz commented May 22, 2025

Uh oh!

azure-pipelines bot commented May 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali May 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 26, 2025

Uh oh!

azure-pipelines bot commented May 26, 2025

Uh oh!

jsuarezruiz May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali May 29, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz May 27, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali May 29, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 29, 2025

Uh oh!

azure-pipelines bot commented May 29, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented Jun 2, 2025

Uh oh!

jsuarezruiz commented Jun 2, 2025

Uh oh!

azure-pipelines bot commented Jun 2, 2025

Uh oh!

jsuarezruiz commented Jun 4, 2025

Uh oh!

azure-pipelines bot commented Jun 4, 2025

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented Jun 5, 2025

Uh oh!

PureWeen commented Jun 6, 2025

Uh oh!

azure-pipelines bot commented Jun 6, 2025

Uh oh!

Ahamed-Ali commented May 22, 2025 •

edited by PureWeen

Loading