Skip to content

iOS: Fix permission warnings when using RequestAsync on main thread #29580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 6 commits into from
Closed

iOS: Fix permission warnings when using RequestAsync on main thread #29580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd1ba0f
Initial plan for issue
Copilot May 19, 2025
e7ee91a
Fix iOS permission warnings by using main thread only for UI operations
Copilot May 19, 2025
109198d
Remove main thread requirement for iOS permission requests
Copilot May 19, 2025
c0caf4f
Remove EnsureMainThread and add device/UI tests for iOS permissions
Copilot May 19, 2025
8018021
Address review feedback for iOS permission fixes
Copilot May 19, 2025
6c02a14
Address review feedback on iOS permission tests and code comments
Copilot May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Essentials/src/Permissions/Permissions.ios.tvos.watchos.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ public override async Task<PermissionStatus> RequestAsync()
if (status == PermissionStatus.Granted || status == PermissionStatus.Disabled)
return status;

EnsureMainThread();

#pragma warning disable CA1416 // https://github.com/xamarin/xamarin-macios/issues/14619
#pragma warning disable CA1422 // Validate platform compatibility
return await RequestLocationAsync(true, lm => lm.RequestWhenInUseAuthorization());
Expand Down
2 changes: 0 additions & 2 deletions src/Essentials/src/Permissions/Permissions.ios.watchos.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,8 +264,6 @@ public override async Task<PermissionStatus> RequestAsync()
if (status == PermissionStatus.Granted)
return status;

EnsureMainThread();

#pragma warning disable CA1416 // https://github.com/xamarin/xamarin-macios/issues/14619
return await LocationWhenInUse.RequestLocationAsync(false, lm => lm.RequestAlwaysAuthorization());
#pragma warning restore CA1416
Expand Down
48 changes: 44 additions & 4 deletions src/Essentials/test/DeviceTests/Tests/Permissions_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,52 @@ internal async Task Request(string permission, PermissionStatus expectedStatus)

[Fact]
[Trait(Traits.UI, Traits.FeatureSupport.Supported)]
public async Task Request_NotMainThread()
public async Task Request_NotMainThread_LocationWhenInUse()
{
await Task.Run(async () =>
// Location permissions can now be requested from any thread
if (DeviceInfo.Platform == DevicePlatform.iOS || DeviceInfo.Platform == DevicePlatform.MacCatalyst)
{
await Assert.ThrowsAsync<PermissionException>(async () => await Permissions.RequestAsync<Permissions.LocationWhenInUse>()).ConfigureAwait(false);
}).ConfigureAwait(false);
await Task.Run(async () =>
{
// Should not throw an exception
var status = await Permissions.RequestAsync<Permissions.LocationWhenInUse>().ConfigureAwait(false);
// Status could be various things depending on system state, but we should get a result
Assert.NotEqual(PermissionStatus.Unknown, status);
}).ConfigureAwait(false);
}
else
{
// On Android and other platforms, keep original behavior for now
await Task.Run(async () =>
{
await Assert.ThrowsAsync<PermissionException>(async () => await Permissions.RequestAsync<Permissions.LocationWhenInUse>()).ConfigureAwait(false);
}).ConfigureAwait(false);
}
}

[Fact]
[Trait(Traits.UI, Traits.FeatureSupport.Supported)]
public async Task Request_NotMainThread_LocationAlways()
{
// Location permissions can now be requested from any thread
if (DeviceInfo.Platform == DevicePlatform.iOS || DeviceInfo.Platform == DevicePlatform.MacCatalyst)
{
await Task.Run(async () =>
{
// Should not throw an exception
var status = await Permissions.RequestAsync<Permissions.LocationAlways>().ConfigureAwait(false);
// Status could be various things depending on system state, but we should get a result
Assert.NotEqual(PermissionStatus.Unknown, status);
}).ConfigureAwait(false);
}
else
{
// On Android and other platforms, keep original behavior for now
await Task.Run(async () =>
{
await Assert.ThrowsAsync<PermissionException>(async () => await Permissions.RequestAsync<Permissions.LocationAlways>()).ConfigureAwait(false);
}).ConfigureAwait(false);
}
}

[Fact
Expand Down