[Testing] Update failing CarouselView2 tests to use CarouselView1 in sample #29315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @@nivetha-nagalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates UI tests to instantiate CarouselView1 instead of CarouselView2 to ensure the test suite runs successfully while CarouselView2 issues are being tracked separately.
- Updated two test files to use CarouselView1.
- Added inline comments with references to the corresponding GitHub issues.
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678_1.cs | Replaced CarouselView with CarouselView1 and added a comment referencing issue #29310 |
| src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678.cs | Replaced CarouselView with CarouselView1 and added a comment referencing issue #29310 |
Files not reviewed (5)
- src/Controls/tests/TestCases.HostApp/Elements/CarouselViewCoreGalleryPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/CarouselViewPositionVisibility.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/CarouselViewUpdateCurrentItem.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/CarouselViewUpdatePosition.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/Issue25192.xaml: Language not supported
Comments suppressed due to low confidence (2)
src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678_1.cs:33
- Ensure that the updated test in this file is appropriately covered by a corresponding test in TestCases.Shared.Tests to validate CarouselView1 behavior.
var carouselView = new CarouselView1
src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678.cs:32
- Ensure that the updated test in this file is supported by a corresponding test case in TestCases.Shared.Tests to validate CarouselView1 behavior consistency.
var carouselView = new CarouselView1
ghost
requested review from
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates failing UI tests by switching the instantiation from CarouselView2 to CarouselView1, ensuring that the test suite remains stable while the underlying issues with CarouselView2 are being tracked.
- Modified tests in Issue7678_1.cs and Issue7678.cs to use CarouselView1 instead of CarouselView2
- Added inline comments referencing the related tracking issue (#29310)
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678_1.cs | Updated CarouselView instantiation and added comment with issue reference |
| src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678.cs | Updated CarouselView instantiation and added comment with issue reference |
Files not reviewed (5)
- src/Controls/tests/TestCases.HostApp/Elements/CarouselViewCoreGalleryPage.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/CarouselViewPositionVisibility.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/CarouselViewUpdateCurrentItem.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/CarouselViewUpdatePosition.xaml: Language not supported
- src/Controls/tests/TestCases.HostApp/Issues/Issue25192.xaml: Language not supported
src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678_1.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678.cs
Outdated
Show resolved
Hide resolved
…1.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 tasks
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsuarezruiz
approved these changes
May 6, 2025
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…sample (dotnet#29315) * Applied CV1 to all the failing test cases. * Update src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678_1.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.HostApp/Issues/XFIssue/Issue7678.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Addressed the feedback --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As we plan to integrate CarouselView2 into the CI pipeline (PR #29283), this PR modifies the UI tests that are currently failing with CarouselView2 to use CarouselView1 instead. This approach ensures the test suite continues to run successfully while we track and resolve the issues related to CarouselView2 separately.
Changes
New Issues Created
All issues have been linked to the CarouselView2 epic: #28978