-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Windows] Remove workarounds from WinUI.targets
#29256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mattleibow
merged 1 commit into
dotnet:main
from
MartyIX:feature/2025-04-29-Windows-remove-WinUI-workarounds
May 3, 2025
Merged
[Windows] Remove workarounds from WinUI.targets
#29256
mattleibow
merged 1 commit into
dotnet:main
from
MartyIX:feature/2025-04-29-Windows-remove-WinUI-workarounds
May 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @mattleibow |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
commented
Apr 30, 2025
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| <!-- |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was introduced in #23247
jsuarezruiz
approved these changes
Apr 30, 2025
Member
|
Wow, so green. |
mattleibow
approved these changes
May 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
I noticed that the workarounds for issues:
appear to be fixed:
I'm not sure they are but I figured it's reasonable to get an opinion from the CI.