Revert "Cleanup virtual layer measure invalidation"#28872
Merged
Conversation
This reverts commit 82b018a.
Contributor
There was a problem hiding this comment.
Copilot reviewed 9 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt: Language not supported
Comments suppressed due to low confidence (1)
src/Controls/tests/Core.UnitTests/PageTests.cs:572
- Replacing 'LabelInvalidateMeasureCheck' with 'Label' removes custom invalidation counting logic. Verify that this test still adequately verifies measure invalidation propagation as originally intended.
var label = new Label()
| } | ||
|
|
||
| internal virtual void InvalidateMeasureInternal(InvalidationTrigger trigger) | ||
| internal void InvalidateMeasureInternal(InvalidationTrigger trigger) |
There was a problem hiding this comment.
Changing the method from 'virtual' to a non-virtual implementation may affect subclasses that previously overrode this method. Confirm that this reversion does not break any intended override behavior in descendant classes.
albyrock87
added a commit
to albyrock87/maui
that referenced
this pull request
Apr 8, 2025
)" (dotnet#28872)" This reverts commit 4ff875a.
rmarinho
pushed a commit
that referenced
this pull request
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #28756
The PR had failing unit tests