[release/9.0.1xx-sr4] [iOS] CollectionView footer sizing when source is empty - fix - #28794
Merged
rmarinho merged 5 commits intoApr 4, 2025
Merged
Conversation
PureWeen
requested review from
mattleibow and
rmarinho
and removed request for
a team
April 3, 2025 14:54
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports the fix for CollectionView footer sizing when the data source is empty to the release branch. The changes include adding new test cases for the issue in both Shared.Tests and HostApp, and updating the header and footer layout logic in the iOS StructuredItemsViewController.
- Added a new UITest (Issue28580) in Shared.Tests.
- Introduced a corresponding HostApp page for the issue.
- Modified header/footer update conditions in StructuredItemsViewController for proper layout.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28580.cs | New test case to validate footer sizing when the CollectionView is empty |
| src/Controls/tests/TestCases.HostApp/Issues/Issue28580.xaml.cs | New HostApp view to support the UI test for Issue28580 |
| src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs | Updated header/footer frame update logic to correctly size the views |
Files not reviewed (1)
- src/Controls/tests/TestCases.HostApp/Issues/Issue28580.xaml: Language not supported
kubaflo
approved these changes
Apr 3, 2025
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
rmarinho
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #28610 to release/9.0.1xx-sr4
/cc @PureWeen @kubaflo