[xamlc] convert {OnIdiom} to OnIdiomExtension<T>
#28700
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @simonrozsival |
This comment was marked as outdated.
This comment was marked as outdated.
| @@ -94,6 +95,39 @@ public void Visit(ElementNode node, INode parentNode) | |||
| return; | |||
| } | |||
|
|
|||
| // Convert OnIdiomExtension to OnIdiomExtension<T> | |||
| if (typeref.FullName == "Microsoft.Maui.Controls.Xaml.OnIdiomExtension") | |||
There was a problem hiding this comment.
can't we handle this as a compiled markup extension (the lines just after these ones) ?
| typeof(IValueConverterProvider), | ||
| typeof(IXmlLineInfoProvider), | ||
| typeof(IConverterOptions)])] | ||
| internal class OnIdiomExtension<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicParameterlessConstructor)] T> : IMarkupExtension |
There was a problem hiding this comment.
if it's used by generated code, it has to be public (the tests passes cause there's an internalsvisibleto for the unit tests project)
you can decorate it with a [EditorBrowseable] attribute, or even [Obsolete] it to prevent usage... or move it to a namespace with 'Internals' in the name...
There was a problem hiding this comment.
So, this might be the cause of the current CI failures. I'll try a public type in the *.Internals namespace.
|
it's really annoying that, unlike OnPlatform, we can't know at build time which idiom will be used... |
jonathanpeppers
changed the title
{OnIdiom} to OnIdiomExtension<T>
Fixes: #22142 The `dotnet new maui -sc` template has trimmer warnings such as: obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Resources_Styles_Styles.xaml.sg.cs(33): Trim analysis warning IL2026: __XamlGeneratedCode__.__Type608CCEEBECE9213C.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Resources_Styles_Styles.xaml.sg.cs(33): Trim analysis warning IL2026: __XamlGeneratedCode__.__Type608CCEEBECE9213C.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Resources_Styles_AppStyles.xaml.sg.cs(33): Trim analysis warning IL2026: __XamlGeneratedCode__.__Type675A47C870224F5D.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Resources_Styles_AppStyles.xaml.sg.cs(33): Trim analysis warning IL2026: __XamlGeneratedCode__.__Type675A47C870224F5D.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Resources_Styles_AppStyles.xaml.sg.cs(33): Trim analysis warning IL2026: __XamlGeneratedCode__.__Type675A47C870224F5D.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Resources_Styles_AppStyles.xaml.sg.cs(33): Trim analysis warning IL2026: __XamlGeneratedCode__.__Type675A47C870224F5D.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_Controls_TaskView.xaml.sg.cs(25): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.Controls.TaskView.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_Controls_TaskView.xaml.sg.cs(25): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.Controls.TaskView.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_Controls_CategoryChart.xaml.sg.cs(27): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.Controls.CategoryChart.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_ManageMetaPage.xaml.sg.cs(25): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.ManageMetaPage.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_ManageMetaPage.xaml.sg.cs(25): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.ManageMetaPage.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_ManageMetaPage.xaml.sg.cs(25): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.ManageMetaPage.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_TaskDetailPage.xaml.sg.cs(25): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.TaskDetailPage.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. obj/Release/net10.0-ios/ios-arm64/Microsoft.Maui.Controls.SourceGen/Microsoft.Maui.Controls.SourceGen.CodeBehindGenerator/Pages_ProjectDetailPage.xaml.sg.cs(25): Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.ProjectDetailPage.InitializeComponent(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. ILC : Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.ProjectDetailPage.<InitializeComponent>_anonXamlCDataTemplate_5.LoadDataTemplate(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. ILC : Trim analysis warning IL2026: dotnet_new_maui_samplecontent.Pages.ProjectDetailPage.<InitializeComponent>_anonXamlCDataTemplate_6.LoadDataTemplate(): Using member 'Microsoft.Maui.Controls.Xaml.OnIdiomExtension.OnIdiomExtension()' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The OnIdiomExtension is not trim safe. Use OnIdiom<T> instead. Most these are due to simple `{OnIdiom}` usage in XAML files like: ```xml <Label Text="{OnIdiom Default=default, Desktop=desktop, Phone=phone}" /> ```` One way we could fix this: * Make an internal `OnIdiomExtension<T>` class with no trimmer warnings * XamlC looks up the target type for `{OnIdiom}` and uses `OnIdiomExtension<T>` instead of `OnIdiomExtension` when generating the code. This currently duplicates the `OnIdiomExtension` class, which I'll investigate if that can be done a different way.
jonathanpeppers
force-pushed
the
dev/peppers/onidiom
branch
from
1f72ae8 to
86c547f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #22142
The
dotnet new maui -sctemplate has trimmer warnings such as:Most these are due to simple
{OnIdiom}usage in XAML files like:One way we could fix this:
Make an internal
OnIdiomExtension<T>class with no trimmer warningsXamlC looks up the target type for
{OnIdiom}and usesOnIdiomExtension<T>instead ofOnIdiomExtensionwhen generating the code.This currently duplicates the
OnIdiomExtensionclass, which I'll investigate if that can be done a different way.