Fix iOS CollectionView not reacting properly to orientation changes#28670
Merged
PureWeen merged 11 commits intodotnet:mainfrom Apr 3, 2025
Merged
Fix iOS CollectionView not reacting properly to orientation changes#28670PureWeen merged 11 commits intodotnet:mainfrom
PureWeen merged 11 commits intodotnet:mainfrom
Conversation
albyrock87
force-pushed
the
fix-28657
branch
2 times, most recently
from
85a4fbb to
affd989
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
added
platform/ios
area-controls-collectionview
albyrock87
force-pushed
the
fix-28657
branch
3 times, most recently
from
8145874 to
81b57d2
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
added
the
p/0
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
albyrock87
force-pushed
the
fix-28657
branch
2 times, most recently
from
45f892e to
bd56392
Compare
Member
|
/azp run |
PureWeen
reviewed
Apr 1, 2025
src/Controls/src/Core/Handlers/Items/iOS/ItemsViewController.cs
Outdated
Show resolved
Hide resolved
PureWeen
reviewed
Apr 1, 2025
src/Controls/src/Core/Handlers/Items/iOS/ItemsViewController.cs
Outdated
Show resolved
Hide resolved
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
previously approved these changes
Apr 2, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
Member
|
/rebase |
github-actions
bot
force-pushed
the
fix-28657
branch
from
d07b35c to
61e90ea
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
# Conflicts: # src/Controls/src/Core/Handlers/Items/iOS/StructuredItemsViewController.cs
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Apr 3, 2025
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
While rotating the device, and under other circumstances, a layout pass is being triggered without going through
PreferredLayoutAttributesFittingAttributesfirst.This is causing an
Arrangepass which is not in sync with measurements.On top of that, due to auto-layout, the platform view
Framewas being set without going through anArrangepass.We're now taking control over arranging the MAUI platform view as if the
TemplatedCellwas some kind ofMauiView.This also has the nice side effect of finally making the
Margins work in the collection view.This PR also fixes a small issue on CV1 where simple-string (non-MAUI) headers/footers where not being properly placed.
Issues Fixed
Fixes #28657
Fixes #28658