Fixed Stepper allows incrementing beyond the maximum value#28398
Merged
PureWeen merged 3 commits intodotnet:inflight/currentfrom Mar 18, 2025
Merged
Fixed Stepper allows incrementing beyond the maximum value#28398PureWeen merged 3 commits intodotnet:inflight/currentfrom
PureWeen merged 3 commits intodotnet:inflight/currentfrom
Conversation
Contributor
|
Hey there @SubhikshaSf4851! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug where the Stepper permitted incrementing beyond its maximum value when the minimum and maximum were equal.
- Changed the validation logic in Stepper.cs to allow maximum and minimum to be equal instead of requiring strict inequality.
- Added/updated test cases in both HostApp and Shared.Tests to verify that increment and decrement actions are disabled when the value equals the boundary.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/Issues/Issue28330.cs | Hosts a test page to visually check the stepper’s behavior on various platforms. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue28330.cs | Contains automated UI tests ensuring the stepper does not increment or decrement when at its limits. |
| src/Controls/src/Core/Stepper/Stepper.cs | Updates the validation conditions for Maximum and Minimum properties to allow equality. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Mar 18, 2025
PureWeen
pushed a commit
that referenced
this pull request
Mar 26, 2025
* Fix for stepper allows to increment value * Updating naming concern * Updates on minimum value and test case sample
PureWeen
pushed a commit
that referenced
this pull request
Mar 26, 2025
* Fix for stepper allows to increment value * Updating naming concern * Updates on minimum value and test case sample
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
* Fix for stepper allows to increment value * Updating naming concern * Updates on minimum value and test case sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
Description of Change:
Tested the behaviour in the following platforms
Issue Fixed:
Fixes: #28330
Output
Issue28330BeforeFix.mp4
Issue28330AfterFix.mp4