Skip to content

Comments

WinUI ContentDialog: respect dynamic theme changes#28126

Merged
jfversluis merged 2 commits intodotnet:inflight/currentfrom
sferhah:patch-1
Aug 28, 2025
Merged

WinUI ContentDialog: respect dynamic theme changes#28126
jfversluis merged 2 commits intodotnet:inflight/currentfrom
sferhah:patch-1

Conversation

@sferhah
Copy link
Contributor

@sferhah sferhah commented Mar 2, 2025 •
edited
Loading

Description of Change

Issues Fixed

Fixes #

Screen.Recording.2025-03-03.013957.mp4

Sample app used to create the video:
App.zip

@sferhah sferhah requested a review from a team as a code owner March 2, 2025 14:00
@sferhah sferhah requested review from jfversluis and rmarinho March 2, 2025 14:00
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 2, 2025
@MartyIX
Copy link
Contributor

MartyIX commented Mar 2, 2025

There is no issue that this PR marks as fixed. In such cases, people often upload "before" and "after" videos like here. IMHO it would be a great addition to your PR, if you have time to do it.

@sferhah
Copy link
Contributor Author

sferhah commented Mar 3, 2025 •
edited
Loading

There is no issue that this PR marks as fixed. In such cases, people often upload "before" and "after" videos like here. IMHO it would be a great addition to your PR, if you have time to do it.

@MartyIX I have added a video as you suggested. Sorry, did not have much time in hand to create a descriptive pull request.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 3, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 3, 2025

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz suggested changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would add an UI test using the attached example https://github.com/user-attachments/files/19045619/App.zip. We have extension methods to change the system theme (Light, Dark) in tests and we can also compare a snapshot with a reference to validate that the color is correct. Could you add it? Let me know if can help with something.

@MartyIX MartyIX mentioned this pull request Mar 4, 2025
Open
jsuarezruiz
jsuarezruiz suggested changes Mar 28, 2025
View reviewed changes
@jfversluis
Copy link
Member

jfversluis commented Aug 12, 2025 •
edited
Loading

/rebase

@jfversluis
Copy link
Member

jfversluis commented Aug 28, 2025 •
edited
Loading

/azp run MAUI-public

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 28, 2025

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Aug 28, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis jfversluis changed the base branch from main to inflight/current August 28, 2025 12:49
@jfversluis jfversluis merged commit 55e473f into dotnet:inflight/current Aug 28, 2025
1 check passed
@jfversluis jfversluis added this to the .NET 9 SR11 milestone Aug 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jfversluis jfversluis jfversluis approved these changes

@rmarinho rmarinho Awaiting requested review from rmarinho rmarinho was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-controls-dialog community ✨ Community Contribution platform/windows

Projects

None yet

Milestone

.NET 9 SR11

Development

Successfully merging this pull request may close these issues.

4 participants

@sferhah @MartyIX @jsuarezruiz @jfversluis