[Android] Properly Resolve File Paths in FilePicker When MANAGE_EXTERNAL_STORAGE is Granted#27975
Merged
jfversluis merged 2 commits intodotnet:mainfrom Feb 24, 2025
Merged
Conversation
Contributor
|
Hey there @bhavanesh2001! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jfversluis
reviewed
Feb 22, 2025
jfversluis
approved these changes
Feb 22, 2025
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jfversluis can this be backported to .NET 8? |
Member
|
@KieranDevvs that is highly unlikely since .NET MAUI built against .NET 8 will go out of support in a few months: https://dotnet.microsoft.com/platform/support/policy/maui |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Summary
The
FilePicker APIfor Android currently does not properly handle file access whenMANAGE_EXTERNAL_STORAGEis granted. This leads to an incorrect behavior where the absolute file path is not resolved, and instead, the FilePicker returns a cached copy.Root Cause
EnsurePhysicalPathalways forcesrequireExtendedAccess = true, which preventsResolveDocumentPathfrom executing when Scoped Storage is enforced on Android 10+ (API 29+).MANAGE_EXTERNAL_STORAGEis granted, meaning it doesn't attempt to resolve the path even when the permission is granted.Fix
requireExtendedAccess = falsewhenMANAGE_EXTERNAL_STORAGEis granted to allowResolveDocumentPathto execute.Current Behaviour:
current_behaviour.mp4
After Fix
after_fix.mp4
Issues Fixed
Fixes #6015