Skip to content

Comments

[iOS] CollectionView 1's doesn't adjust its offset when resizing a footer#27963

Merged
rmarinho merged 1 commit intodotnet:mainfrom
kubaflo:CollectionView-1's-footer-doesn't-resize-when-changing-visibility
Feb 24, 2025
Merged

[iOS] CollectionView 1's doesn't adjust its offset when resizing a footer#27963
rmarinho merged 1 commit intodotnet:mainfrom
kubaflo:CollectionView-1's-footer-doesn't-resize-when-changing-visibility

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Feb 21, 2025 •
edited
Loading

Description of Change

A small improvement to the mechanism of resizing the header and footer that moves the offset only when the header would be visible. Thanks to it, the CollectionView 1's properly adjust its offset when resizing a footer

Issues Fixed

Fixes #27962

Before After
cv1.mov
fixed.mov

@kubaflo kubaflo requested a review from a team as a code owner February 21, 2025 15:24
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 21, 2025
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Feb 21, 2025

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/ios area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution and removed community ✨ Community Contribution labels Feb 21, 2025
@kubaflo kubaflo changed the title CollectionView 1's footer doesn't resize when changing visibility - fix [iOS] CollectionView 1's doesn't adjust its offset when resizing a footer Feb 21, 2025
@rmarinho
Copy link
Member

rmarinho commented Feb 21, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 21, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@samhouts samhouts requested a review from Copilot February 21, 2025 19:20
Copilot AI reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@rmarinho
Copy link
Member

rmarinho commented Feb 22, 2025

Not an issue on CV2 ?

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 22, 2025

Not an issue on CV2 ?

It works but when scrolling up and down after resizing

Screen.Recording.2025-02-22.at.19.30.01.mov

@kubaflo
Copy link
Contributor Author

kubaflo commented Feb 22, 2025

Not an issue on CV2 ?

It works but when scrolling up and down after resizing

Screen.Recording.2025-02-22.at.19.30.01.mov

@rmarinho I've tackled the issue with CV2 here #27076 some time ago

@rmarinho rmarinho enabled auto-merge (squash) February 24, 2025 10:17
@rmarinho rmarinho self-assigned this Feb 24, 2025
@rmarinho rmarinho added this to the .NET 9 SR5 milestone Feb 24, 2025
@rmarinho rmarinho merged commit 2b44413 into dotnet:main Feb 24, 2025
123 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@rmarinho rmarinho rmarinho approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow was automatically assigned from dotnet/dotnet-maui-reviewers

Assignees

@rmarinho rmarinho

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution platform/ios

Projects

None yet

Milestone

.NET 9 SR5

Development

Successfully merging this pull request may close these issues.

[iOS] CollectionView 1's doesn't adjust its offset when resizing a footer

2 participants

@kubaflo @rmarinho