[iOS] DatePicker | Remove unnecessary UpdateDate() call in UpdateTextColor() by bhavanesh2001 · Pull Request #27811 · dotnet/maui

bhavanesh2001 · 2025-02-14T19:41:47Z

Description of Change

This change removes an unnecessary call to UpdateDate() from UpdateTextColor() for iOS.

Root Cause

UpdateTextColor() was incorrectly triggering UpdateDate(), which overrode the expected locale-based date format with the virtual view's default format
As a result, the DatePicker initially displayed the wrong format instead of following the device's locale settings
However, text color updates do not require a date update, and this call was redundant.

Fix

Removed the unnecessary UpdateDate() invocation inside UpdateTextColor().
Verified that text color changes are still applied correctly without triggering UpdateDate().

Issues Fixed

Fixes #27803

rmarinho

The comment does say it was needed. Can you add a test where changing the color will still update on the UI?

bhavanesh2001 · 2025-02-15T05:11:16Z

@rmarinho I added a test. However , text color is a styling property, and Appium does not provide a way to verify it directly. The current test confirms that the binding updates correctly, but it does not guarantee that the UI visually reflects the color change.
If i'm missing something here please let me know. That said, the UI is updating as expected.

Edit: Never mind I figured it's need to be verified comparing snapshots.

Screen.Recording.mov

jsuarezruiz · 2025-02-17T07:02:50Z

/azp run

bhavanesh2001 · 2025-02-20T10:03:00Z

/rebase

bhavanesh2001 · 2025-02-25T08:29:05Z

@jfversluis Could you run pipelines?

azure-pipelines · 2025-02-25T08:30:37Z

Azure Pipelines successfully started running 3 pipeline(s).

bhavanesh2001 · 2025-02-26T02:06:51Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27803.cs

+
+	public override string Issue => "DatePicker default format on iOS";
+
+#if !MACCATALYST


The DatePicker seems inconsistent on Mac. The TextColor property definitely isn't working. Check #20904

Are you able to wrap the whole file with a #if TEST_FAILS_ON_CATALYST?

See

maui/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9794.cs

Line 1 in 0dde841

#if TEST_FAILS_ON_CATALYST // This test fails on catalyst, unable to click the back button as its does not have an identifier.

I am not sure if we have something that is watching files for these lines to give us stats or something. AI or someting maybe.

azure-pipelines · 2025-02-27T10:34:27Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2025-02-27T15:24:16Z

/rebase

rmarinho · 2025-02-27T15:25:09Z

/azp run

azure-pipelines · 2025-03-07T14:51:17Z

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow

Code looks good. Nice test.

I think there may be some tech involved with the way to exclue failing tests on some platforms. Added a comment.

mattleibow · 2025-03-12T15:52:04Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27803.cs

+
+	public override string Issue => "DatePicker default format on iOS";
+
+#if !MACCATALYST


Are you able to wrap the whole file with a #if TEST_FAILS_ON_CATALYST?

See

maui/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9794.cs

Line 1 in 0dde841

#if TEST_FAILS_ON_CATALYST // This test fails on catalyst, unable to click the back button as its does not have an identifier.

I am not sure if we have something that is watching files for these lines to give us stats or something. AI or someting maybe.

PureWeen · 2025-03-18T16:25:54Z

/azp run

azure-pipelines · 2025-03-18T16:26:17Z

Azure Pipelines successfully started running 3 pipeline(s).

dotnetaspire · 2025-04-11T13:31:35Z

This didn't go with 9.6? 😔

Changes made

…Color() (#27811) * remove excessive UpdateDate() call * adding Ui test * update UItest * adding snapshots * add a static date in test case * match date with snapshots * change preprocessor directive * add comment

…Color() (dotnet#27811) * remove excessive UpdateDate() call * adding Ui test * update UItest * adding snapshots * add a static date in test case * match date with snapshots * change preprocessor directive * add comment

bhavanesh2001 requested a review from a team as a code owner February 14, 2025 19:41

bhavanesh2001 requested review from jfversluis and jsuarezruiz February 14, 2025 19:41

dotnet-policy-service bot added the community ✨ Community Contribution label Feb 14, 2025

bhavanesh2001 changed the title ~~[iOS] Remove unnecessary UpdateDate() call in UpdateTextColor()~~ [iOS] DatePicker | Remove unnecessary UpdateDate() call in UpdateTextColor() Feb 14, 2025

rmarinho requested changes Feb 14, 2025

View reviewed changes

bhavanesh2001 force-pushed the ios_datepicker_fomat branch 2 times, most recently from eac116b to 0f17f8f Compare February 15, 2025 04:59

bhavanesh2001 requested a review from rmarinho February 15, 2025 05:03

This comment was marked as off-topic.

Sign in to view

jsuarezruiz added platform/ios area-controls-datetimepicker DatePicker, TimePicker labels Feb 17, 2025

github-actions bot force-pushed the ios_datepicker_fomat branch from 35716ba to b302eb0 Compare February 20, 2025 10:03

bhavanesh2001 force-pushed the ios_datepicker_fomat branch from b302eb0 to acb4b23 Compare February 26, 2025 02:03

bhavanesh2001 commented Feb 26, 2025

View reviewed changes

bhavanesh2001 added 5 commits February 27, 2025 15:24

remove excessive UpdateDate() call

5413101

adding Ui test

a55db44

update UItest

42618dc

adding snapshots

21f19e1

add a static date in test case

8f70f14

github-actions bot force-pushed the ios_datepicker_fomat branch from 8f9ee10 to 8f70f14 Compare February 27, 2025 15:24

This comment was marked as outdated.

Sign in to view

PureWeen added this to MAUI SDK Ongoing Mar 5, 2025

github-project-automation bot moved this to Todo in MAUI SDK Ongoing Mar 5, 2025

jfversluis moved this from Todo to Ready To Review in MAUI SDK Ongoing Mar 7, 2025

jfversluis self-assigned this Mar 7, 2025

Merge branch 'dotnet:main' into ios_datepicker_fomat

284139b

mattleibow previously requested changes Mar 12, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Mar 12, 2025

change preprocessor directive

b2253a3

bhavanesh2001 requested a review from mattleibow March 12, 2025 16:35

bhavanesh2001 added 2 commits March 15, 2025 09:44

Merge branch 'dotnet:main' into ios_datepicker_fomat

7f6ccff

add comment

ada1337

PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Mar 18, 2025

PureWeen modified the milestones: .NET 9 SR6, .NET 9 SR7 Mar 24, 2025

rmarinho approved these changes Apr 14, 2025

View reviewed changes

rmarinho moved this from Ready To Review to Approved in MAUI SDK Ongoing Apr 14, 2025

PureWeen changed the base branch from main to inflight/current April 22, 2025 22:09

PureWeen merged commit 685914d into dotnet:inflight/current Apr 22, 2025
128 checks passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Apr 22, 2025

PureWeen mentioned this pull request May 5, 2025

[2025/04/28] Candidate - In Flight Branch #29158

Merged

github-actions bot locked and limited conversation to collaborators May 23, 2025


		public override string Issue => "DatePicker default format on iOS";

		#if !MACCATALYST

Comments

Conversation

bhavanesh2001 commented Feb 14, 2025

Description of Change

Issues Fixed

Uh oh!

rmarinho left a comment

Choose a reason for hiding this comment

Uh oh!

bhavanesh2001 commented Feb 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsuarezruiz commented Feb 17, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

bhavanesh2001 commented Feb 20, 2025

Uh oh!

bhavanesh2001 commented Feb 25, 2025

Uh oh!

azure-pipelines bot commented Feb 25, 2025

Uh oh!

bhavanesh2001 Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

mattleibow Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

rmarinho commented Feb 27, 2025

Uh oh!

rmarinho commented Feb 27, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

azure-pipelines bot commented Mar 7, 2025

Uh oh!

mattleibow left a comment

Choose a reason for hiding this comment

Uh oh!

mattleibow Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

PureWeen commented Mar 18, 2025

Uh oh!

azure-pipelines bot commented Mar 18, 2025

Uh oh!

dotnetaspire commented Apr 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bhavanesh2001 commented Feb 15, 2025 •

edited

Loading

jsuarezruiz commented Feb 17, 2025 •

edited by jfversluis

Loading

rmarinho commented Feb 27, 2025 •

edited by jfversluis

Loading