[Android] Fixed the SoftInputMode issues with modal pages#27553
Merged
jfversluis merged 1 commit intodotnet:mainfrom Feb 13, 2025
Merged
[Android] Fixed the SoftInputMode issues with modal pages#27553jfversluis merged 1 commit intodotnet:mainfrom
jfversluis merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27242.cs:35
- The method name 'WindowSoftInputModeAdjustSetToPanForModalpage' should be 'WindowSoftInputModeAdjustSetToPanForModalPage' to maintain consistency in naming conventions.
public void WindowSoftInputModeAdjustSetToPanForModalpage()
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
In the OnCreateDialog method,
CustomComponentDialogis used to create the dialog, and its SoftInputMode defaults toAdjustUnspecified. As a result, the behavior varies based on the layout:If a ScrollView is present, the window appears to resize.
Otherwise, it behaves as a pan.
Additionally, setting
SoftInputModeat the sample level does not apply to the dialog.Description of Change
SoftInputModefrom the Context and apply it to thedialog. This ensures consistent behavior and proper functionality, even when SoftInputMode is set at the sample level.Regressed PR
DecorViewwas used for modal pages, but it has now been replaced byDialogFragmentfor improvements.Issues Fixed
Tested the behaviour in the following platforms
Screenshot
ModalPageIssue.mov
ModalPageFix.mov