Page cannot scroll to the bottom while using RoundRectangle#27451
Merged
jfversluis merged 7 commits intodotnet:mainfrom Feb 13, 2025
Merged
Page cannot scroll to the bottom while using RoundRectangle#27451jfversluis merged 7 commits intodotnet:mainfrom
jfversluis merged 7 commits intodotnet:mainfrom
Conversation
Contributor
|
Hey there @Dhivya-SF4094! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
StephaneDelcroix
approved these changes
Feb 13, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Details:
The iOS platform page cannot scroll to the bottom while using shapes like RoundRectangle, Rectangle.
Root Cause:
The height of the RoundRectangle control is not being returned correctly and instead defaults to the predefined height.
Description of Change:
Updated the Stretch.Fill case to properly consider the heightConstraint, widthConstraint, and HeightRequest/WidthRequest values when determining the final dimensions. This fix ensures that the correct height is returned by properly evaluating constraints and requested values.
Tested the behavior in the following platforms.
Issues Fixed:
Fixes #26877
Fixes #18628
Fixes #27265
Fixes #16492
Screenshots
iOS
26877_iOS_BeforeFix.mov
26877_iOS_AfterFix.mov
Android