Skip to content

Revert CollectionView, the footer moves to the bottom of the page when the empty view or empty view template is enabled#27288

Merged
rmarinho merged 7 commits intomainfrom
revert_24997
Jan 24, 2025
Merged

Revert CollectionView, the footer moves to the bottom of the page when the empty view or empty view template is enabled#27288
rmarinho merged 7 commits intomainfrom
revert_24997

Conversation

@PureWeen
Copy link
Member

@PureWeen PureWeen commented Jan 22, 2025 •
edited
Loading

Description of Change

Changes made in #24997 modified the EmptyView so that it doesn't always take up the entire height and instead sizes to the content. Though this is a valid scenario, the changes shifted the behavior too far the other direction. We need to look at some options around the use of LayoutOptions to influence the sizing here to allow users more flexibility.

Issues Fixed

Fixes #27229
Fixes #26838

@PureWeen
Revert "CollectionView, the footer moves to the bottom of the page wh…
248598b 
…en the empty view or empty view template is enabled (#24997)"

This reverts commit 763b6f5.

# Conflicts:
#	src/Controls/src/Core/Handlers/Items/iOS/ItemsViewController.cs
#	src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24966.cs
@PureWeen
- update testing
8007d0f
Copilot AI review requested due to automatic review settings January 22, 2025 19:08
@PureWeen PureWeen requested a review from a team as a code owner January 22, 2025 19:08
@PureWeen PureWeen added this to the .NET 9 SR3.1 milestone Jan 22, 2025
Copilot AI reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • src/Controls/tests/TestCases.HostApp/Issues/Issue24966.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/Issues/Issue27229.xaml: Language not supported
  • src/Controls/tests/TestCases.HostApp/Issues/Issue24966.xaml.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24966.cs: Evaluated as low risk

This was referenced Jan 22, 2025
Open
Open
@jsuarezruiz jsuarezruiz self-requested a review January 23, 2025 15:14
rmarinho
rmarinho reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So on windows seems it does t actually center, per screenshot added. So it was like that in the past right?

@PureWeen PureWeen mentioned this pull request Jan 23, 2025
Closed
@PureWeen
Copy link
Member Author

PureWeen commented Jan 23, 2025 •
edited
Loading

So on windows seems it does t actually center, per screenshot added. So it was like that in the past right?

yea, we have a tracking issue here

I deleted the image and commented out the WinUI Test

@PureWeen
Copy link
Member Author

PureWeen commented Jan 23, 2025

/backport to release/9.0.1xx-sr3

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Started backporting to release/9.0.1xx-sr3: https://github.com/dotnet/maui/actions/runs/12938420967

@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
@rmarinho rmarinho merged commit 41a1ff5 into main Jan 24, 2025
104 checks passed
@rmarinho rmarinho deleted the revert_24997 branch January 24, 2025 11:44
@PureWeen PureWeen modified the milestones: .NET 9 SR3.1, .NET 9 SR4 Jan 28, 2025
@PureWeen PureWeen mentioned this pull request Feb 13, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR4

Development

Successfully merging this pull request may close these issues.

CollectionView.EmptyView not respecting layout. [MAUI]After entering the string, ‘any records’ is not displayed.

4 participants

@PureWeen @rmarinho @jsuarezruiz