Skip to content

Comments

[iOS] Fixed the ScrollView sizing issue that occurred in version 9.0.30#27283

Closed
Tamilarasan-Paranthaman wants to merge 3 commits intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-27169
Closed

[iOS] Fixed the ScrollView sizing issue that occurred in version 9.0.30#27283
Tamilarasan-Paranthaman wants to merge 3 commits intodotnet:mainfrom
Tamilarasan-Paranthaman:fix-27169

Conversation

@Tamilarasan-Paranthaman
Copy link
Member

Root Cause of the Issue

  • Previously, the platform content was wrapped in a ContentView by default, which helped prevent sizing issues. However, in PR Simplify iOS ScrollView #26763, the ContentView was removed, and the platform content was added directly as a subview of UIScrollView, resulting in the observed sizing problem.

Regressed PR

Description of Change

  • Reintroduced the ContentView wrapping for platform content, restoring the behavior that prevented sizing issues. This adjustment ensures that the platform content is correctly sized and resolves the problem caused by adding it directly as a subview of UIScrollView.

Issues Fixed

Fixes #27169

Tested the behaviour in the following platforms

  • iOS
  • Mac
  • Windows
  • Android

Screenshot

Before Issue Fix After Issue Fix
BeforeFix.mov
AfterFix.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 22, 2025
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 22, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman changed the title [iOS] Fixed the ScrollView clipping issue in version 9.0.33. [iOS] Fixed the ScrollView sizing issue that occurred in version 9.0.33 Jan 22, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 22, 2025 15:17
Copilot AI review requested due to automatic review settings January 22, 2025 15:17
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 22, 2025 15:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman changed the title [iOS] Fixed the ScrollView sizing issue that occurred in version 9.0.33 [iOS] Fixed the ScrollView sizing issue that occurred in version 9.0.30 Jan 22, 2025
@PureWeen PureWeen added this to the .NET 9 SR3.1 milestone Jan 22, 2025
@albyrock87
Copy link
Contributor

@Tamilarasan-Paranthaman the scroll view can't be the source of the issue.
The fact that we removed that layer in the iOS scroll view probably revealed a different bug we still have to discover.

image

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dartasen
Copy link
Contributor

Shouldn't those kind of issues be take care of by the MAUI team ?
It's a bit annoying to beta test random changes in Service Release by discovering new bugs on basic controls

@albyrock87
Copy link
Contributor

@dartasen if only this was a real bug... while IMHO it is exactly a "fix on basic controls" :)

#27169 (comment)

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).


if (scrollView.PresentedContent is { } content)
{
var contentContainer = new ContentView()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we know if want a ContentView or a GeneralWrapperView ? Woudln't the second one handle the layout better?

@albyrock87
Copy link
Contributor

albyrock87 commented Jan 23, 2025

@dartasen if only this was a real bug... while IMHO it is exactly a "fix on basic controls" :)

#27169 (comment)

@dartasen lol, in the end this was a real regression, I'm sorry!
I was not thinking about the VerticalOptions.Start applied to the grid in combination with the infinite height constraint caused by the scroll view.

I created a simpler fix within #27298.

@PureWeen
Copy link
Member

Closed in favor of #27298

@PureWeen PureWeen closed this Jan 23, 2025
@dartasen
Copy link
Contributor

dartasen commented Feb 1, 2025

@dartasen if only this was a real bug... while IMHO it is exactly a "fix on basic controls" :)
#27169 (comment)

@dartasen lol, in the end this was a real regression, I'm sorry! I was not thinking about the VerticalOptions.Start applied to the grid in combination with the infinite height constraint caused by the scroll view.

I created a simpler fix within #27298.

Thank's for figuring out :)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman deleted the fix-27169 branch January 20, 2026 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-scrollview ScrollView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[iOS][9.0.30] View getting clipped while it shouldn't?

7 participants