[Binding SG] Removed deprecated InterceptsLocationAttribute#27145
Merged
PureWeen merged 2 commits intodotnet:mainfrom Jan 24, 2025
Merged
[Binding SG] Removed deprecated InterceptsLocationAttribute#27145PureWeen merged 2 commits intodotnet:mainfrom
InterceptsLocationAttribute#27145PureWeen merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated 3 comments.
Files not reviewed (7)
- src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj: Language not supported
- src/Controls/tests/BindingSourceGen.UnitTests/Controls.BindingSourceGen.UnitTests.csproj: Language not supported
- src/Controls/tests/BindingSourceGen.UnitTests/BindingRepresentationGenTests.cs: Evaluated as low risk
- src/Controls/tests/BindingSourceGen.UnitTests/IntegrationTests.cs: Evaluated as low risk
- src/Controls/tests/BindingSourceGen.UnitTests/BindingTransformerTests.cs: Evaluated as low risk
- src/Controls/tests/BindingSourceGen.UnitTests/IncrementalGenerationTests.cs: Evaluated as low risk
- src/Controls/tests/BindingSourceGen.UnitTests/BindingCodeWriterTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Controls/src/BindingSourceGen/BindingSourceGenerator.cs:44
- [nitpick] The variable name 'location' is ambiguous. It should be renamed to 'simpleLocation'.
var location = binding.SimpleLocation;
jkurdek
force-pushed
the
fix-binding-sg-location-attribute
branch
from
38e0713 to
7c5553b
Compare
simonrozsival
approved these changes
Jan 20, 2025
jonathanpeppers
approved these changes
Jan 21, 2025
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
dotnet/roslyn is making some API changes for [InterceptsLocationAttribute], so we need to make changes here to react.
We are suppressing CS9270 for .NET 10:
So, after this is merged we will also need to take these changes to the net10.0 branch.
PureWeen
approved these changes
Jan 23, 2025
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
Tested and made sure this fixes the build errors I was seeing with 9.0.200
rmarinho
pushed a commit
that referenced
this pull request
Jan 28, 2025
…e` (#27408) * [Binding SG] Removed deprecated `InterceptsLocationAttribute` (#27145) Fixes: #27315 Backport of #27145 for .NET 10. * [Binding SG] Updated InterceptsLocationAttribute * Added System.Diagnostics.Conditional attribute * Restore `#pragma warning disable RSEXPERIMENTAL002` --------- Co-authored-by: Jeremi Kurdek <59935235+jkurdek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Roslyn team marked Interceptors as stable and started deprecating old APIs dotnet/roslyn#76312. This PR updates the
InterceptsLocationAttributeto use the overload recommend by the Roslyn team.This PR attempts to reduce the dependence on the new API in order to minimize visible impact to customers and make bumping version of the API in the future easy.
Issues Fixed #27144