Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
2 minor things. But this little optimization makes me happy!
Thanks for putting this together Pedro!
jfversluis
added
the
area-architecture
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
How do things like commands look? Also, maybe we should also do events for Button. HasClicked = (Clicked is not null)
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
|
||
| private protected override string GetDebuggerDisplay() | ||
| { | ||
| return $"IsRunning = {IsRunning}, " + base.GetDebuggerDisplay(); |
There was a problem hiding this comment.
Interpolating along with string concatenation ?
There was a problem hiding this comment.
would it cause any issue?
There was a problem hiding this comment.
would it cause any issue?
Typically one uses one or the other for consistency reasons, not both. I think one can do:
$"IsRunning = {IsRunning}, {(base.GetDebuggerDisplay())}";
There was a problem hiding this comment.
String concatenation should never be used in modern c#
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@pictos this needs a rebase for a failing UI test and not sure you want to address the feedback? For consistency might be nice |
|
@jfversluis I can do a rebase during the week. I can use just the interpolated string, but I don't see any issue on that |
pictos
force-pushed
the
pj/improve-debugger-display
branch
from
d0d0713 to
3507b52
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Co-authored-by: Gerald Versluis <gerald@verslu.is>
jfversluis
force-pushed
the
pj/improve-debugger-display
branch
from
3507b52 to
efc36b0
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
7 participants
Description of Change
This PR adds the
DebuggerDisplayattribute over a good amount of controls and, this is the first step into improving the debug experience of .NET MAUIYou can find more images in the related issue
Issues Fixed
Related to #27016