Fix up relevant CA1416 warnings - Set 4#26995
Merged
jfversluis merged 4 commits intodotnet:mainfrom Jan 20, 2025
Merged
Conversation
karthikraja-arumugam
added
the
partner/syncfusion
Member
Author
|
@dotnet-policy-service terminate |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PureWeen
requested changes
Jan 8, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Core/src/Handlers/Application/ApplicationHandler.iOS.cs:51
- [nitpick] The comment should specify that ActivateSceneSession requires iOS 17+ or MacCatalyst 17+ for clarity.
// ActivateSceneSession requires 17+
jfversluis
added
the
area-infrastructure
PureWeen
requested changes
Jan 9, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mattleibow
reviewed
Jan 14, 2025
Member
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
This feels almost done, just noticed that Apple has an api for all mac catalyst but only ios 17+
Member
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
PureWeen
approved these changes
Jan 15, 2025
mattleibow
approved these changes
Jan 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
force-pushed
the
reenable_CA1416_part_4
branch
from
c5f7939 to
c0ac7b6
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
Failing tests are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change