[Windows] Fixed IsEnabled Property not works on Tabs#26728
[Windows] Fixed IsEnabled Property not works on Tabs#26728jfversluis merged 22 commits intodotnet:inflight/currentfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5161.cs
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
2f4d28b to
b984797
Compare
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
b984797 to
3de2419
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
left a comment
There was a problem hiding this comment.
Some little changes, we try not use the private keyword, also we try to use the brackets for making sure we don't missing something that should be in the if statement.
When making the changes please rebase on top of main too.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellItemRenderer.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 3 pipeline(s). |
9cd908a to
131219b
Compare
@jfversluis I have validated this PR against the latest main after the recent iOS changes were merged. |
Issue Details
In the Shell, when the Tab.isEnabled property is set to false, the tab should be non-interactive and prevent user interaction. the current behavior allows the tab to be clicked.
Root Cause
In Windows, implementation property for IsEnabled property is not handled.
Description of change
For the Windows platform, a new IsEnabled property was introduced in NavigationViewItemViewModel and registered within NavigationViewItem in the TabbedPageXaml.Windows page. The BaseShellItem.IsEnabled property is now mapped to this newly added property in the view model. Additionally, support was added to handle runtime updates by responding to property-changed events, ensuring the enabled state reflects changes dynamically.
Validated the Behavior in the following Platforms
Issue fixed
Fixes #5161
Fixes #32996
Screenshots
BeforeFix_5161.mp4
AfterFix_5161.mp4