Skip to content

Comments

[Windows] Fixed IsEnabled Property not works on Tabs#26728

Merged
jfversluis merged 22 commits intodotnet:inflight/currentfrom
NirmalKumarYuvaraj:fix-5161
Feb 23, 2026
Merged

[Windows] Fixed IsEnabled Property not works on Tabs#26728
jfversluis merged 22 commits intodotnet:inflight/currentfrom
NirmalKumarYuvaraj:fix-5161

Conversation

@NirmalKumarYuvaraj
Copy link
Contributor

@NirmalKumarYuvaraj NirmalKumarYuvaraj commented Dec 19, 2024

Issue Details

In the Shell, when the Tab.isEnabled property is set to false, the tab should be non-interactive and prevent user interaction. the current behavior allows the tab to be clicked.

Root Cause

In Windows, implementation property for IsEnabled property is not handled.

Description of change

For the Windows platform, a new IsEnabled property was introduced in NavigationViewItemViewModel and registered within NavigationViewItem in the TabbedPageXaml.Windows page. The BaseShellItem.IsEnabled property is now mapped to this newly added property in the view model. Additionally, support was added to handle runtime updates by responding to property-changed events, ensuring the enabled state reflects changes dynamically.

Validated the Behavior in the following Platforms

  • Android
  • iOS
  • mac
  • WinUI

Issue fixed

Fixes #5161
Fixes #32996

Screenshots

Before Issue Fix After Issue Fix
BeforeFix_5161.mp4
AfterFix_5161.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 19, 2024
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 19, 2024
@NirmalKumarYuvaraj NirmalKumarYuvaraj marked this pull request as ready for review December 20, 2024 11:59
@NirmalKumarYuvaraj NirmalKumarYuvaraj requested a review from a team as a code owner December 20, 2024 11:59
@Redth

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@Redth
Copy link
Member

Redth commented Jan 2, 2025

/azp run

@azure-pipelines

This comment was marked as outdated.

@azure-pipelines

This comment was marked as off-topic.

@StephaneDelcroix
Copy link
Contributor

StephaneDelcroix commented Jan 10, 2025

/azp run

@azure-pipelines

This comment was marked as outdated.

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines

This comment was marked as outdated.

@StephaneDelcroix
Copy link
Contributor

StephaneDelcroix commented Jan 21, 2025

/azp run

@azure-pipelines

This comment was marked as outdated.

@jfversluis

This comment was marked as outdated.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little changes, we try not use the private keyword, also we try to use the brackets for making sure we don't missing something that should be in the if statement.

When making the changes please rebase on top of main too.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Dhivya-SF4094
Copy link
Contributor

@NirmalKumarYuvaraj looks like this is probably already fixed by #33369 and or #33337 can you confirm?

@jfversluis I have validated this PR against the latest main after the recent iOS changes were merged.
The issue is now fully resolved on the iOS platform by the merged PR, so the iOS-specific changes included in this PR are no longer required.
However, I re-verified the behavior on the Windows platform, and the issue still reproduces there. The Windows fix included in this PR is still necessary and works as expected.

@Dhivya-SF4094 Dhivya-SF4094 changed the title Fixed IsEnabled Property not works on Tabs [Windows] Fixed IsEnabled Property not works on Tabs Feb 23, 2026
@jfversluis jfversluis changed the base branch from main to inflight/current February 23, 2026 15:51
@jfversluis jfversluis merged commit 2b2580c into dotnet:inflight/current Feb 23, 2026
17 of 27 checks passed
@jfversluis jfversluis added this to the .NET 10 SR5 milestone Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls-tabbedpage TabbedPage community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) s/pr-needs-author-input PR needs an update from the author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] Shell Tab IsEnabled Not Working ShellContent IsEnabledProperty does not work

10 participants