Conversation
PureWeen
reviewed
Dec 10, 2024
Contributor
|
I wonder if there are maybe other internal UiViews that act as containers that should be replaced by this GeneralWrapperView? |
Member
|
General WrapperView 🫡 |
jfversluis
approved these changes
Dec 11, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
When the empty view only had 1 button , no layout, it wasn't renderer correctly , the height was always 0. So we can reuse the same approach from CV2 , and reuse the code to fix both approaches for now.
This pull request includes several changes to the iOS handlers and template helpers in the
src/Controls/src/Core/Handlers/Itemsdirectory. The most significant changes involve the introduction of a newGeneralWrapperViewclass to replaceUIContainerView2and updates to the handling of views in theTemplateHelpersandTemplatedCell2classes.Introduction of
GeneralWrapperView:GeneralWrapperViewclass insrc/Controls/src/Core/Platform/iOS/GeneralWrapperView.csto handle the wrapping of views, enabling better measurement and arrangement.Updates to
TemplateHelpers:RealizeViewmethod inTemplateHelpers.csto replaceUIContainerView2withGeneralWrapperView, improving the handling of views without templates.usingdirectives and added new ones to reflect the changes in dependencies.Updates to
TemplatedCell2:UIContainerView2withGeneralWrapperViewin theBindVirtualViewmethod to ensure consistent handling of views.UIContainerView2class fromTemplatedCell2.cs, as it is now replaced byGeneralWrapperView.Minor Cleanup:
ItemsViewController.csto maintain code cleanliness.To test
Test for issue #19609 should pass
Issues Fixed
Fixes #26508