Skip to content

[Android] BackgroundColor for GraphicsView #26320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Dec 3, 2024

Issues Fixed

Fixes #19568

Before After

@kubaflo kubaflo requested a review from a team as a code owner December 3, 2024 01:38
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 3, 2024
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android 🤖 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution and removed community ✨ Community Contribution labels Dec 3, 2024
@rmarinho
Copy link
Member

rmarinho commented Dec 3, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, just wondering why this is just on android and also what should a "null" color be?

@rmarinho
Copy link
Member

rmarinho commented Dec 4, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

{
public Issue19568()
{
Content = new GraphicsView()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the test a little bit?, add a Layout, and some content behind the GraphicsView. Then, add a button to add and remove the BackgroundColor to see if it works and can see/access to the element behind. Just to validate that can aadd/remove the background color at runtime.

Copy link
Contributor Author

@kubaflo kubaflo Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Done, I think

@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo
Copy link
Contributor Author

kubaflo commented Mar 30, 2025

I had a feeling this pr: #26368 would fix it, but it didn't

@kubaflo kubaflo self-assigned this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution platform/android 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphicsView does not change the Background/BackgroundColor on Android
4 participants