Skip to content

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Dec 3, 2024

Issues Fixed

Fixes #19568

Before After

@kubaflo kubaflo requested a review from a team as a code owner December 3, 2024 01:38
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 3, 2024
@dotnet-policy-service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution and removed community ✨ Community Contribution labels Dec 3, 2024
@rmarinho
Copy link
Member

rmarinho commented Dec 3, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, just wondering why this is just on android and also what should a "null" color be?

@rmarinho
Copy link
Member

rmarinho commented Dec 4, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

{
public Issue19568()
{
Content = new GraphicsView()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the test a little bit?, add a Layout, and some content behind the GraphicsView. Then, add a button to add and remove the BackgroundColor to see if it works and can see/access to the element behind. Just to validate that can aadd/remove the background color at runtime.

Copy link
Contributor Author

@kubaflo kubaflo Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Done, I think

@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo
Copy link
Contributor Author

kubaflo commented Mar 30, 2025

I had a feeling this pr: #26368 would fix it, but it didn't

@kubaflo kubaflo self-assigned this Mar 30, 2025
@jfversluis
Copy link
Member

/rebase

Copilot AI review requested due to automatic review settings August 12, 2025 10:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jfversluis jfversluis added this to the .NET 9 SR11 milestone Aug 12, 2025
@jfversluis jfversluis changed the base branch from main to inflight/current August 12, 2025 10:10
@jfversluis jfversluis merged commit cdf14c6 into dotnet:inflight/current Aug 12, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution platform/android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphicsView does not change the Background/BackgroundColor on Android

5 participants