Skip to content

Comments

Navigation from the 'more' tab#26292

Merged
PureWeen merged 3 commits intodotnet:mainfrom
kubaflo:fix-Issue18193
Jan 28, 2025
Merged

Navigation from the 'more' tab#26292
PureWeen merged 3 commits intodotnet:mainfrom
kubaflo:fix-Issue18193

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Dec 1, 2024 •
edited
Loading

Along with this @albyrock87's PR: #22574, the shell navigation should be flawless :)

Issues Fixed

Fixes #26165
Fixes #18193

Demo
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-30.at.17.55.22.mp4

@kubaflo kubaflo requested a review from a team as a code owner December 1, 2024 13:37
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 1, 2024
@kubaflo kubaflo added platform/ios area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Dec 1, 2024
@kubaflo kubaflo requested a review from PureWeen December 1, 2024 13:40
@kubaflo kubaflo mentioned this pull request Dec 1, 2024
Closed
@jfversluis
Copy link
Member

jfversluis commented Dec 2, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 2, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

PureWeen commented Dec 3, 2024

/rebase

@PureWeen
Copy link
Member

PureWeen commented Dec 3, 2024 •
edited by jfversluis
Loading

/azp run

@azure-pipelines

This comment was marked as outdated.

Sign in to view
@PureWeen PureWeen added this to the .NET 9 SR3 milestone Dec 3, 2024
@kubaflo kubaflo mentioned this pull request Dec 11, 2024
Closed
jfversluis
jfversluis requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing for this one!

@kubaflo kubaflo requested a review from jsuarezruiz as a code owner December 16, 2024 13:13
@azure-pipelines
Copy link

azure-pipelines bot commented Dec 16, 2024

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

PureWeen commented Dec 16, 2024

/rebase

@PureWeen
Copy link
Member

PureWeen commented Dec 16, 2024

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 16, 2024

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen
PureWeen requested changes Jan 6, 2025
View reviewed changes
@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 7, 2025

@PureWeen can we try again. The strange thing is that it passes locally though🤔
Screenshot 2025-01-07 at 14 59 56

I've also modified the other test

@PureWeen
Copy link
Member

PureWeen commented Jan 7, 2025

/azp run

@PureWeen PureWeen modified the milestones: .NET 9 SR3, .NET 9 SR4 Jan 14, 2025
mattleibow
mattleibow requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javier's comment on adding a test for the actual more tab is good. We need to make sure that navigating using links and then back should also work.

@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 15, 2025

@mattleibow @mattleibow I've extended the UiTest

@PureWeen
Copy link
Member

PureWeen commented Jan 16, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 16, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@mattleibow mattleibow mentioned this pull request Jan 17, 2025
Closed
@mattleibow
Copy link
Member

mattleibow commented Jan 17, 2025 •
edited
Loading

FYI: I created an issue with a task to re-enable these tests on Mac Catalyst when we get a chance : #27206

@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 17, 2025

FYI: I created an issue with a task to re-enable these tests on Mac Catalyst when we get a chance : #27206

Thanks!

@ghost
Copy link

ghost commented Jan 20, 2025

FYI: I created an issue with a task to re-enable these tests on Mac Catalyst when we get a chance : #27206

@mattleibow & @kubaflo I have gone through the test cases and observed that there are multiple click actions, with each click leading to a new page, requiring further interaction with the elements on those pages. I suggest that we could wait for the elements to before executing any click actions. This might be successful in Catalyst and avoid flakiness in CI.

image

@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 20, 2025

FYI: I created an issue with a task to re-enable these tests on Mac Catalyst when we get a chance : #27206

@mattleibow & @kubaflo I have gone through the test cases and observed that there are multiple click actions, with each click leading to a new page, requiring further interaction with the elements on those pages. I suggest that we could wait for the elements to before executing any click actions. This might be successful in Catalyst and avoid flakiness in CI.

image

Okay, thanks! I've added a commit🤞

@PureWeen
Copy link
Member

PureWeen commented Jan 21, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 21, 2025

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow
mattleibow previously approved these changes Jan 23, 2025
View reviewed changes
PureWeen
PureWeen requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ShellNavigationShouldWorkInMoreTab failing on iOS

@PureWeen
Copy link
Member

PureWeen commented Jan 24, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 24, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit c03601d into dotnet:main Jan 28, 2025
102 of 104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@PureWeen PureWeen PureWeen approved these changes

@mattleibow mattleibow mattleibow left review comments

@Eilon Eilon Awaiting requested review from Eilon Eilon was automatically assigned from dotnet/dotnet-maui-reviewers

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis

@jsuarezruiz jsuarezruiz Awaiting requested review from jsuarezruiz

Assignees

No one assigned

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/ios

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR4

Development

Successfully merging this pull request may close these issues.

MAUI 9 Shell Tabbar overrides tabbar title with page title. [iOS] Navigation doesn't work on sixth tab in shell

5 participants

@kubaflo @jfversluis @PureWeen @mattleibow @jsuarezruiz