Fixed the hide password hint which is showing when the entry is focused #25768
Merged
PureWeen merged 7 commits intodotnet:inflight/currentfrom Apr 22, 2025
Merged
Conversation
fix added
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 13, 2024
rmarinho
requested changes
Nov 18, 2024
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
As @jsuarezruiz comment I don t think this is the best way to do, hiding the popup should be an opt in option via a platform specific option. We do want to get the password popup because thats what users expect on the Mac .
sheiksyedm
added
the
partner/syncfusion
…sLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 0ddc794.
…msLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 4b9074c.
jsuarezruiz
suggested changes
Jan 10, 2025
Contributor
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
@devanathan-vaithiyanathan as @rmarinho mentioned before, could you create a platform specific?
Contributor
Author
Moved the changes to be specific to the macOS platform, aligning the implementation with Catalyst-specific requirements. Also included test case for above fix. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
suggested changes
Jan 31, 2025
jsuarezruiz
approved these changes
Mar 25, 2025
PureWeen
pushed a commit
that referenced
this pull request
Apr 23, 2025
…ed (#25768) * Update TextFieldExtensions.cs fix added * Revert "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 0ddc794. * Reapply "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 4b9074c. * Moved fix to platform specific for macOS * Updated Screenshot for mac --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
…ed (#25768) * Update TextFieldExtensions.cs fix added * Revert "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 0ddc794. * Reapply "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 4b9074c. * Moved fix to platform specific for macOS * Updated Screenshot for mac --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>
PureWeen
pushed a commit
that referenced
this pull request
May 2, 2025
…ed (#25768) * Update TextFieldExtensions.cs fix added * Revert "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 0ddc794. * Reapply "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (#26152)" This reverts commit 4b9074c. * Moved fix to platform specific for macOS * Updated Screenshot for mac --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>
SuthiYuvaraj
pushed a commit
to SuthiYuvaraj/maui
that referenced
this pull request
May 9, 2025
…ed (dotnet#25768) * Update TextFieldExtensions.cs fix added * Revert "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 0ddc794. * Reapply "Fixed CollectionViewHandler2 null reference exception if ItemsLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 4b9074c. * Moved fix to platform specific for macOS * Updated Screenshot for mac --------- Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Description of Change
It prioritizes the detection of one-time codes, which can affect the display of password hints. This is because the system recognizes the field as intended for a one-time code rather than a password, and thus, it doesn’t show password suggestions.
Issues Fixed
Fixes #17105
Tested the behaviour in the following platforms
Output Screenshots
17105_macOS_BeforeChanges.mov
17105_macOs_AfterChanges.mov