Templated indicator view - improvements #25642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
kubaflo
added
platform/android 🤖
platform/iOS 🍎
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 6, 2024
| for (int i = 0; i < 3; i++) | ||
| App.Click("AddItemButton"); | ||
|
|
||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Snapshots already available in the latest build.
Example, iOS:
|
|
||
| [Test] | ||
| [Category(UITestCategories.IndicatorView)] | ||
| public void IndicatorWithTemplateShouldBeVisible() |
There was a problem hiding this comment.
Test seems to crash on Windows:
The app was expected to be running still, investigate as possible crash
TearDown : The app was expected to be running still, investigate as possible crash
There was a problem hiding this comment.
I think there's something wrong with the UI test with the Carousel view with the data template on Windows. Probably we will have the same crash without any changes. Like we do in this PR: #24776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR addresses several issues with the IndicatorView when using a DataTemplate, particularly around collection updates. Specifically, it aims to resolve the following bugs:
Indicator disappears on empty collection: When all items are removed, the indicators disappear as expected. However, upon adding items back, the indicators do not reappear.
Last indicator not rendering: In certain cases, adding new elements to the collection does not render the final indicator properly.
Incorrect visual state for the current page indicator: When an item is removed from the collection, the visual state of the current page indicator becomes incorrect.
This pull request, alongside PR #21980, which addresses the rendering and sizing issues of IndicatorView with DataTemplate, should resolve all known issues with IndicatorView in this context. If any issues remain, I’ll be disappointed—but I’ll make sure to address them.
NotReAppearing.mov
IsSelectedNotWorkingCorrectly.mov
LastItemNotAppearing.mov
Working.mov
Issues Fixed
Fixes #25598