Fix for [iOS] Use non-overridden traits in AppInfoImplementation.RequestTheme#25497
Fix for [iOS] Use non-overridden traits in AppInfoImplementation.RequestTheme#25497PureWeen merged 8 commits intodotnet:mainfrom
Conversation
|
The fix ensures the theme updates correctly on the current page, but the main page still retains the previously requested theme, even when updating the application's current theme. @filipnavara, do you have any thoughts on this? |
I'll have to check again what is going on in the test app. That sounds like the exact behavior this was trying to fix... |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
81d3bad to
79cce0f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
79cce0f to
e69e76d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
left a comment
There was a problem hiding this comment.
/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue23411.xaml.cs(18,39): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-ios]
Removal async command
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Root Cause
While updating the requested theme, the default TrailCollection is obtained, which does not return non-overridden traits and does not take the system theme into account.
Description of Change
UIScreen.MainScreen.TraitCollection is obtained , which will return non overridden traits based on the system theme
Issues Fixed
Fixes #23411
Output Video
BeforeFix.mov
AfterFix.mov