2174059 MAUI hit testing ignores pages loaded by PushModalAsync#24109
Merged
Conversation
Updated VisualTreeElementExtension to get the MauiWinUiWindow Element, as its content member gets modal content in addition to underlying content
lizharems
requested review from
BretJohnson,
chabiss,
drasticactions and
spadapet
BretJohnson
reviewed
Aug 9, 2024
BretJohnson
left a comment
BretJohnson
left a comment
There was a problem hiding this comment.
I see that the fix is WinUI only. Did you also test on Android/iOS to confirm that they don't have this bug - that it's a WinUI only issue?
Contributor
Author
From testing I wasn't able to repro it on Android, I need to set up my iOS device to test as I don't have a good remote simulator setup to test. For context this code is windows only. |
mattleibow
reviewed
Aug 12, 2024
PureWeen
previously requested changes
Aug 14, 2024
Update the code to use the UI.Xaml.Window instead of the MauiWinUIWindow
mattleibow
approved these changes
Aug 20, 2024
mattleibow
approved these changes
Aug 21, 2024
Redth
pushed a commit
that referenced
this pull request
Aug 22, 2024
* MAUI hit testing ignores pages loaded by PushModalAsync Updated VisualTreeElementExtension to get the MauiWinUiWindow Element, as its content member gets modal content in addition to underlying content * PR Feedback Update the code to use the UI.Xaml.Window instead of the MauiWinUIWindow
samhouts
added
fixed-in-net9.0-nightly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Updated VisualTreeElementExtension to get the MauiWinUiWindow Element, as its content member gets modal content in addition to underlying content
Tested in Maui Windows and Android with a test project from the linked work item. Verified in the Maui Sandbox with fix and without.
Also verified the initial bug didn't repro on android.
Issues Fixed
Bug# 2174059