[Windows] Handle non-seekable streams in PlatformImage.FromStream (take 2)
#23824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
requested review from
Foda and
jonathanpeppers
and removed request for
Eilon and
tj-devel709
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jonathanpeppers
previously approved these changes
Jul 25, 2024
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
This looks good to me 👍, I triggered CI.
MartyIX
commented
Jul 26, 2024
MartyIX
commented
Jul 26, 2024
MartyIX
commented
Jul 26, 2024
MartyIX
force-pushed
the
feature/2024-07-25-PlatformImage.FromStream-seekable-optimized
branch
from
b41d163 to
45b9ff3
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
reviewed
Jul 29, 2024
Member
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
This is looking good!
Is it possible to create a test for this? You can fake a readonly stream with something like this: https://github.com/mono/SkiaSharp/blob/main/tests/Tests/Utils/NonSeekableReadOnlyStream.cs
Contributor
Author
Yes, I will try to come with one. |
MartyIX
force-pushed
the
feature/2024-07-25-PlatformImage.FromStream-seekable-optimized
branch
from
45b9ff3 to
d1e5a3e
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
deleted the
feature/2024-07-25-PlatformImage.FromStream-seekable-optimized
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #23626. This PR uses the
RecyclableMemoryStreamManagerto decrease allocations.Description of Change
AsRandomAccessStreamthrowsNotSupportedExceptionwhen the stream is not seekable. This PR is a simple workaround for it.The second commit adds an optimization. The idea is to remove
AsyncPump(introduced in dotnet/Microsoft.Maui.Graphics@4597923 and merged to MAUI in #8739) which does not seem to be necessary at all. I have tested the change with parallel loading of images and it did not break for me. But then again I don't really know whyAsyncPumpwas introduced in the first place. This commit is an alternative to #23624 approach and the improvement should be the same as in that PR: #23624 (comment) (9 seconds -> 1.3 seconds for a batch of images containing ~100 images).Test
Tested with provided sample code that reads images in parallel to make sure it works: https://gist.github.com/MartyIX/2513b1853ad8537a4d31b62c251115ad
Issues Fixed
Fixes #18954