Visual state change for disabled RadioButton #23471
Open
+60
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
platform/macOS 🍏
kubaflo
requested review from
dustin-wojciechowski
and removed request for
mattleibow
|
This looks good! Would you mind writing a test for it as well? :) |
|
@dustin-wojciechowski of course, I will write the test as soon as I find some time :) |
|
@dustin-wojciechowski I've added a UI test :) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-18668
branch
from
f037a64 to
db28cc0
Compare
|
/rebase |
github-actions
bot
force-pushed
the
fix-18668
branch
from
db28cc0 to
21ed209
Compare
jsuarezruiz
reviewed
Nov 14, 2024
| { | ||
| App.WaitForElement("button"); | ||
| App.Click("button"); | ||
|
|
There was a problem hiding this comment.
Could the test change the theme and verify the disabled RadioButton on Light and Dark theme?
There was a problem hiding this comment.
I'm not sure if this is necessary as changing the opacity is rather independent on user theme right?
| { | ||
| Property = Grid.OpacityProperty, | ||
| TargetName = "Grid", | ||
| Value = 0.4f |
There was a problem hiding this comment.
Should be a different value based on the system theme?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #18668
Fixes #18668 (comment)
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-07.at.02.01.55.mp4
Screen.Recording.2024-07-07.at.01.40.57.mov