Adopt chromium methodology for determining tablet on Windows#22809
Conversation
|
Hey there @daltzctr! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree [company="CTR Electronics"] |
|
@dotnet-policy-service agree company="CTR Electronics" |
|
Marking as draft until I confirm a device that is Windows that should be tablet is still tablet (I will test on my Surface Pro 7). Reviews are still welcome. |
rmarinho
requested review from
Foda,
jfversluis and
mattleibow
and removed request for
Eilon and
StephaneDelcroix
|
Surface Pro 7 (Windows 11): Keyboard Attached Surface Pro 7 (Windows 11): Keyboard Not-attached Also tested on XPS 15 which now correctly reports as not-tablet, |
|
This is ready for review and/or merge. |
|
Can you share what device was wrong before (using stable MAUI)? Was it a Windows laptop that just always returned |
|
XPS 15 reports as tablet. |
|
Can this get merged? |
|
@Foda is this blocked on something? |
|
@Foda just a courtesy ping |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
Congratulations on being a .NET MAUI contributor!
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.1.24453.9
and removed
fixed-in-net9.0-nightly
7 participants
Description of Change
Uses a more conservative approach of determining tablet mode on Windows. This approach is functionally identical to Chromium's implementation for determining tablet on Windows. Additionally, it adds a few documentation comments on the observed behavior.
I don't have a good idea on how to add a unit test for this, and it's a bit of an implicit breaking change (some users who had tablet layouts may have desktop layouts now), but I think that number of users affected will be near, or at 0.
Issues Fixed
Possibly fixes #22093